Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <06d33eb8-d2a9-4792-fa83-c64059ab7326@oracle.com>
Date:   Tue, 17 Jan 2023 08:45:05 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v8 1/9] perf pmu: Add #slots literal support for arm64
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>
Cc:     Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Andrew Kilroy <andrew.kilroy@arm.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1673940573-90503-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1673940573-90503-2-git-send-email-renyu.zj@linux.alibaba.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1673940573-90503-2-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGFNeWhoT0QxUmpRbnAxa1B5N2NYeWMwWmFMU2pQbWFOa1hMa3pScEFobm5h?=
 =?utf-8?B?N0VXaVEwck5tUGRoWmdsMVJ0MzNRSGVuZVNrVWRmVTZRRytEajlKYVorSFFI?=
 =?utf-8?B?N1hPaWtPQ3BaenQraEtvelN2VXJUYkIvR2tMRHUyUDgvUnJNR2lMNkFveE55?=
 =?utf-8?B?TE0ySStxdlNRdDd2b3hPUXFUeEVWKzYzNThyajljY2pFeFE4djg0WDlOVFJT?=
 =?utf-8?B?ZVNOelRpWDl0cWJXd1JpcUZZQndNQ2x4UlBDQStYZTBFcGFURkM2WGdFMWZk?=
 =?utf-8?B?eVFicFBkTEgrN1NQb1hTOXVERExvL09FOEV1VEJwcUp3Zyt5WGswRm84dWlv?=
 =?utf-8?B?djRubTQ3bjBkZU5WWEFaekhqVU00SllCMkNHMVdVNUk4M0E2QURyeksxWm1W?=
 =?utf-8?B?Z2FBMFZtWlFTOG5ia01hMUpMbW01Z2t2bVJQNExSZXluclRUTVdUSUJrUXJ0?=
 =?utf-8?B?KzZ0ZSs4YXdBYmJreHBYdkxZSVIwOGNhbGgwKzlxMDV2ZFBMTWVwZWZnVkdr?=
 =?utf-8?B?NG1hbVRiOHJQYWd2b3JYYWFKTys3R3BnSE9MNkxNZnRvdXZreVNYNzA4YmVO?=
 =?utf-8?B?aUpkM2pQY1BReTZKTStaVW8yYlJJbFRwcktLanZVZFlLZXRINm8zTmRYU1Zw?=
 =?utf-8?B?RXFUVTUxYWcweXZaamNIeCtGTkJRUnpWRG9BeU9PQkRtQmZHSXp0dVo1bk9K?=
 =?utf-8?B?QmJKYzJpdUNxdWVydlFjQXQyYXdPSVdvSWhTcmtwQ3VVZGhRWVVvVU5yMFMx?=
 =?utf-8?B?RnFCVXc2THgxVEZWM2FmdXBhRVNaeEdxQ0VBWGlzK081WVdwdUxPa1IwaVR0?=
 =?utf-8?B?ajFQQ3I2KzFINE9NVnhzSjZzMDVmNXcvU2xRTGdKRkNoZjNwOUdFdmRnN0hD?=
 =?utf-8?B?M0VSNjg2ODZUVVhwNXEyRSs5VVo5WThZaUZZbFkvM2xwMlV0YVBsY3JQc0xG?=
 =?utf-8?B?R1hzc29LUzBzNHBNMjJsRUtnSjJLR1haMTR5ODEyNzhGSjJLUTNiZlg5YzV0?=
 =?utf-8?B?enEzWXVOcm40WnBlYjIxdlc1MnlMUkgwVHlZbDdTTVkzZEM3SUtmakZvVTBN?=
 =?utf-8?B?bHVUZjVrVnYrMXFqbUh0U1JvZG81NytHZWVzZm1yTDNER0J3dU5OVWNMUHBi?=
 =?utf-8?B?NFg2d2pvWWZ4QzJ6MTJMTWxnVmJmd0lOZ3Vra3FDSDhaU3h2ajM4QlF3QWRV?=
 =?utf-8?B?dGdtS0M2L3FUS2ptYU1FV2xPd1R6ZGd5YU5TSDRYbjJyczJuUmFLYWxNV3Jq?=
 =?utf-8?B?RElmSkN3TTRpeGVIS04zSkZCLy9WeVRQREFRYmNHQ1U1dmZESnZSUU5KaVBt?=
 =?utf-8?B?MzFwM3J2NW5laVExd1JTYlpKNThDYTcyNklUS1J1UmdJcWtrNkx0YjZSSTBK?=
 =?utf-8?B?WXd2M01vN0Q2Uzc2STNXMlhUUlpnRDZ1MFNnYWM3Tm5EUlQvdlVob2NHcGJw?=
 =?utf-8?B?TzZha0QwUzlvSU5UbXIxNXdLYXhIVGVmNlM0NUxackJ3MFNzRzRhMEkvQ3lt?=
 =?utf-8?B?cVk1SmhzZGlIYnRYRTJGeFBtTzFiVHQzMXV6d2xkWUdCQWs5TzZVT0lSUmRz?=
 =?utf-8?B?dkNmN0JRWndCQzJqQ3A3azZCYWUzNnZmUGtrOVdmQllMNSthejd4SkJ2QUhO?=
 =?utf-8?B?MGtTZC9Ea3VMbCtDM202bURkbHE3OHQxN0xhZldqWDFqQnprOTVYVWVyKzNh?=
 =?utf-8?B?aFZNWWpwMTNMMHp1MDFZM1RnU09mUmhLUENJUVJQV0hBTU9kbDlUMDZnMnRV?=
 =?utf-8?B?TFJBaGNjajhVT2ZBbzRTdkdPN3FqUkRKL1BBNlFxYXppeDZ4ME1IQnpqaCs1?=
 =?utf-8?B?UmpVWERFbWpnK1JxeklHQzMzZnB0R0lVdk0vT2tjNVA1M0xYN3A0OGJQVk1v?=
 =?utf-8?B?TVlsMnd6Nmk3Q2tYTHo5Q2FXcm1HK3NJS3paWFA5UnR1SnBqZk0wR1poMVM3?=
 =?utf-8?B?aStwQ1k4SktnZm0reWxDNk5mT2ZZU2U1M0RTRzFWZm9VMmVYZXcxM2pOTVdu?=
 =?utf-8?B?UXZkdFA2R1Jwd2l3VzYvU0p4eGtIZUFWRitGUmRZcGtZSmRSUHRkKzNiV3ZB?=
 =?utf-8?B?RTI5VWFRVnR3Uk0wR3l2LzBKWC8yTXZDR0JZamFZY2xtUU5wOGRBUHR2T2Nk?=
 =?utf-8?Q?sLaR9zgfZc4o8rdFu2yluUnHq?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?aitUclRhSzNEVE02OExKZ3ZBcnlQSDR5S3U0d0d2VkdycXV5SDdteWxtK0l3?=
 =?utf-8?B?WGt2UnRWSXRqZWhKS3dBbTZmWFZkeGxUU3Jnd21SdGg2by9wa1JHN01mS3hl?=
 =?utf-8?B?TlZpR1JuaUFRSlNCWk14TnZTejI4VStkMUxkdER5cjJMRnhVKzV0VkFSODA1?=
 =?utf-8?B?VTUrUFQ1MDhrV1pTaGZtNW5sbmVWS3RsMWtJZVJSVzhLU3g3RzRDeUZ1ZUo5?=
 =?utf-8?B?ZS9tOXRKU0FldS9SMDdzUDFtRStic0tuS2x6RUxKTW9lSjNZa21jcEhqQTZI?=
 =?utf-8?B?Y3hJNjFDc2h2RVE0NWNvSWV2SG84Z1dDT1gzTnphRFFRTHdqdklQR3JhVGlV?=
 =?utf-8?B?YUVhTjllL1p6RTFkdHF3MGk1cG5KdXhXUC92Wm1tN0VCUkl4bTZ0azNOdnJO?=
 =?utf-8?B?U1h3M1dhYk5mUEZwWktLclAvTEE4T1ZIYVpRcjNPWTIxL1ZuSytaZ0t3cXg3?=
 =?utf-8?B?NlV2WTFPcjBrN1dYR2xnMG01LytmUmFaVVdNQlBTakI3ak9QQ1Q1Y0pTb25v?=
 =?utf-8?B?Uml5djg0UHhRVmEvTmllRXdSMXVRdWQ1OHVudWYvN1lxWGRVbDBQaXJQQncy?=
 =?utf-8?B?cThsY1BHWXhSWHJYanJEMTFpMVhYc2F3anVFWG1YdU9LYlNTNG9FT0VtR2R3?=
 =?utf-8?B?Umk0RFVhNTl0bHZvMERPQmJxcm5UVXp5bEdqQTN5K0lOWVdVK0c4bjY3QVVG?=
 =?utf-8?B?Q2hEUk01SUF3YjV0WTc1eURwbEZYMEwxWWd1Z2t6VmptVUtFVTREeGpmRGN1?=
 =?utf-8?B?QTFIbFRwVTBndzl6RVN5ZFJySDdSNk1nK3lhT25RdXkyOTBDMXNKOVNJY2VS?=
 =?utf-8?B?Zzg3bXdaSkI2VFF0VTlYZnNYb2RxVFM0SmVoTWxUcGhMQUlsQ0NESms4cWgz?=
 =?utf-8?B?MWgzdjVhakFGRXJmcHFoT0FMWjd2UW9jTFphd20waGxtUWRGcmtiYS85YU5H?=
 =?utf-8?B?WHF6Z09SUDFjWU1UbEQ3VFdoZkNoYnQya3ZjSmIyZmhiTGoxa2NrM2ErLzk5?=
 =?utf-8?B?TCs0NG12dW1xSHlVcHZaVm92RU9JTFpzNjFqMExXdk9USC85MGQvVGd6bnRw?=
 =?utf-8?B?UVpENERoa0YzNE10OXVpaUhoWC82TERXckVLVjNZOTJtUGx2d2RCcStnOHVK?=
 =?utf-8?B?MEprNUNLY0lDK0hHVWp0ay9ERlBqUWVUM0w0NDEyanAxakpZdjV2VWpaa1Ix?=
 =?utf-8?B?bmZKRnY3bmg5bHhaUXpQako4OUh3QmNJdG5sdW5MYU5WRWlXZkFaUEpqeFdt?=
 =?utf-8?B?THVJUXB0TE4vOGRnUWlvZVpZQVl2VU81aU5HRGJPTU1XZTlLdlBWWUxlWnly?=
 =?utf-8?B?cFg5VlZJZHRrcXFNNEltQ2VmbFZyRmFhZ1lPaldianp2bmFjNjRJZ3hVdHFX?=
 =?utf-8?B?NFpnYTN3NHpPSkR1c0o0ZXJHT1hpN29jS25oNkRkaXd5RFZCT1FkWHZOMDRl?=
 =?utf-8?B?QVZPSWs3Z3ZMREd6S3NULzNnbHRvV0ZlalQwOFVnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8492c9c-543d-4d1c-da89-08daf86725cd
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 08:45:12.8101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S/z8qUPoLV1glLZRXPjDDv/xdF4Y1e4B5tPiyE8UyMQZVwzKKEewyq1FaQmpkSFC9bqtfi/M8Pe6MP+TccNXNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6696
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-17_04,2023-01-13_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301170073
X-Proofpoint-GUID: rwX1q6YOP3JBBlMF3ZfKLSvJXETmP3V9
X-Proofpoint-ORIG-GUID: rwX1q6YOP3JBBlMF3ZfKLSvJXETmP3V9
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17/01/2023 07:29, Jing Zhang wrote:
> The slots in each architecture may be different, so add #slots literal
> to obtain the slots of different architectures, and the #slots can be
> applied in the metric. Currently, The #slots just support for arm64,
> and other architectures will return NAN.
> 
> On arm64, the value of slots is from the register PMMIR_EL1.SLOT, which
> I can read in /sys/bus/event_source/device/armv8_pmuv3_*/caps/slots.
> PMMIR_EL1.SLOT might read as zero if the PMU version is lower than
> ID_AA64DFR0_EL1_PMUVer_V3P4 or the STALL_SLOT event is not implemented.
> 
> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com>

Reviewed-by: John Garry <john.g.garry@oracle.com>