Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4491670rwb; Tue, 17 Jan 2023 01:20:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXv6ileYe8eCuNfMDwOj7krZWsBLn8BshG67f9Ux/ED0bwkQudSr+vlvQfvZxxqIA1fZhHzD X-Received: by 2002:a17:906:15da:b0:870:9346:ddc9 with SMTP id l26-20020a17090615da00b008709346ddc9mr2010603ejd.45.1673947211777; Tue, 17 Jan 2023 01:20:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673947211; cv=none; d=google.com; s=arc-20160816; b=RfpeOon1GVK/YLyGAPUO8p9MxO5mNBMRrCqNUlF7juuOIMJnarapee2krxDatgXll2 ZHtweja77Dw1LxM4rH+KcE2rMLmPKVOgROyxdifqmcloDVPuKlaHXbAlj5NZo492Ba0k MFpL8UGUy9UBxCUhzYv58IUd0KoqeTMKsPJabAUdP0EHAFRYQdT+jr3c8yZO+NPswHGX LSbLp/k1JDyd+J7w8LX/F22xMfd6MvjwUnIPUks0OlBL/KEl58iI7Y6f9IBzbrey76SA JobhCS+lYV23ANfQylfuJDgl+BD4pko93BpxAAQOG2fovCZGwXWd6CzzIRkczTwitlgl Keng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Svga7SsiFsN5UXzPSuWC3QCdzpcdEqH2j+9/f+MZ4Lk=; b=t8oEvUUeTQN0qrwZvOYYSEkCKSHjFfc3qWKIPl7YQW6XcnZgGjY9pZl+7MXxz8hlRA k2dspK05JXUXu9mphEV1xKnH5ueFU9NneHuOPR7JJAwVn0G6Pgc/STCrB3K9tntCM8XA d5CBXXUDT+5an3hV23sSl9bggaWSZ6jWUlCm0+8CP3DIB7pJNc3QVBABZvTK0OgexEwl sxIeZLerFmww/E6TBygGPYjvK6HBjDmWqkWWEGZ1wvCZHXISkCa1U1BHQyg8x/q6xrjV 3ijR/lhArl+QdN65sROm9MBuGYMPNdVftS2/MAoiRiQlYkovOqsU1uF8AcKy+qkpT1Rf JLiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dvqCifhK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb41-20020a170907962900b0084d44bd6939si29670257ejc.508.2023.01.17.01.19.58; Tue, 17 Jan 2023 01:20:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dvqCifhK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236416AbjAQJMk (ORCPT + 49 others); Tue, 17 Jan 2023 04:12:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236394AbjAQJMI (ORCPT ); Tue, 17 Jan 2023 04:12:08 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 189A43B65C; Tue, 17 Jan 2023 01:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673946337; x=1705482337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0aHYPToS/jABucyxHBUjjp3ckI/iQBTA/kh5jyn5eAU=; b=dvqCifhKMRekRHAjX3InjzFw9Ho93bCyYJBxl+LkeIZnwu2DEhHBwil/ ENLX5OknAIW7KLVs0/eiPV4cDU/xvJXgORNKQ9d2uUWTYqZ4RTQe3T5I4 JLdz+vmGOVwBrSja/y5fT9VhuUs800cLa8BkLa4TBy/bgW9aGgQahopEt PASYPHWvqBvKigYF1jq7WK3py0WI9/cUOHQcHq/vfqYgfeK43aVl0CqBb z2768nxpftNtJPwqXcQAp+sFhKF2z9N1MRl8pQNeBb3O2+95t/pQo4t0k 9qm7Fv/Abise6EM9LEJ6BDwsV609py5C29YYvjHZMRrDYECnNyD7n8SA9 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="324700983" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="324700983" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 01:04:46 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="783174107" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="783174107" Received: from tronach-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.252.40.3]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 01:04:43 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Rodolfo Giometti , Ulf Hansson , Johan Hovold , Samuel Iglesias Gonsalvez , linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v4 04/12] tty: moxa: Make local var storing tty_port_initialized() bool Date: Tue, 17 Jan 2023 11:03:50 +0200 Message-Id: <20230117090358.4796-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230117090358.4796-1-ilpo.jarvinen@linux.intel.com> References: <20230117090358.4796-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return type of tty_port_initialized() is bool, use matching type for the local variable. Also reorder the local vars to reverse-xmas-tree while at it. Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen --- drivers/tty/moxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index bc474f3c3f8f..2d9635e14ded 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -1664,8 +1664,8 @@ static int moxa_poll_port(struct moxa_port *p, unsigned int handle, u16 __iomem *ip) { struct tty_struct *tty = tty_port_tty_get(&p->port); + bool inited = tty_port_initialized(&p->port); void __iomem *ofsAddr; - unsigned int inited = tty_port_initialized(&p->port); u16 intr; if (tty) { -- 2.30.2