Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e594495-0eaa-6580-17eb-16f5db76865d@nxp.com>
Date:   Tue, 17 Jan 2023 11:09:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: add module parameter to ignore
 ready flag from remote processor
To:     "S.J. Wang" <shengjiu.wang@nxp.com>,
        "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        SOF-Team <sof-team@msteams.nxp.com>,
        MPU AUDIOSW-AUDIOSW <Mpuaudiosw@nxp.com>
Cc:     dl-linux-imx <linux-imx@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
References: <20230116225343.26336-1-iuliana.prodan@oss.nxp.com>
 <DB9PR04MB935597568D763916CA4ECA13E3C69@DB9PR04MB9355.eurprd04.prod.outlook.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <DB9PR04MB935597568D763916CA4ECA13E3C69@DB9PR04MB9355.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amcvdVc1VWRBWUpoUkdrMU9rcXFMMDBMUkFHUHEvVFNNS2R1NnFzcFRhUHlI?=
 =?utf-8?B?KzNPQXZpN3h4TVpWRWF1UmRwSmxZOGMwUHBHd2dCTzlKSkNlVDBUUWExNjZ5?=
 =?utf-8?B?UXNkM09wdndFN3ZXU0M0Wi8zUEIxT3FHWTZVaWFWQlF5YkV5N0hvRFhQL0Ri?=
 =?utf-8?B?bWhRVzZ6WVp2cVdSUmR5aTJZbVZWZzBOaWtEMEpYMWJrSUtPSzN4dXRZUlpp?=
 =?utf-8?B?Y0RKeFZ2alFnTU5xck1UaUUyWW5jVkVHNzdkVXRlU3Y3NFpDUkp2ZlE1c2Zu?=
 =?utf-8?B?aFJRSW1MUnJoNzQyZkwzN2cycUJzWUwvbjMrbExzZEw4SDlMRWR1NEJoamFP?=
 =?utf-8?B?VGdQQW41OU1KUTZ0RVFYWFRZWDhxWHF5UGlpUC9ESnV5NUZqVm9mZFNxVFJN?=
 =?utf-8?B?ZFlQbzZvR2xTdFVrVWVLRGNDbzd2cittaDVUenc3OGlaUXNhYjFSSWNjMktw?=
 =?utf-8?B?YUFzajJaRnVKUnQydi9MTFdDVXNBd0ZmSktGeHFKdVViMWhLaWJKRWdlT0dT?=
 =?utf-8?B?WGcwZHVZL3hOTzNzZlJQVTNjVDNsTkdBbnpEYVZxNFBVSFd6ZENDeG5sVHBH?=
 =?utf-8?B?Y3BhQVlqOTV0b3FQdzNFaHBtYmd6bWJLemYrcWdjMlFwdWFFZ3ozbFR0c1Zy?=
 =?utf-8?B?NG9VQTdQMGprb1VSU2E2bHh6RS9wSTNpS1JRdjM5d1BXNVhYdzZFbit1THE5?=
 =?utf-8?B?QXZLZ3ZrYzQ0UGRGdlN3Uko3blRudDNKVzBsWXc5ZVBJZ3N4Z2hNcnI1YjVC?=
 =?utf-8?B?bm9QK0V5eEZOUitSWWtCdjhXcHY4bGZwOE1SMUtxTnpPdm50NmF2YUV3Nm45?=
 =?utf-8?B?QlQ1N0dvb3AyeHUwbURNNkxNaEJDeWFKUUdaZ2pIbjhRaXhSdE5DVXY0VS9Z?=
 =?utf-8?B?ZXA2eHlDTWJOYkphcmJzdFdhRGRsNStzbVk5S1kwdEppdVZsSDJ0dmhyUFg4?=
 =?utf-8?B?WXF2aG9nd1dsL1BYSjVpbGhWZmNuU0xJNXpCbSsxem9LbWl3TzlaK0NqcGxS?=
 =?utf-8?B?MWRlM0tjaEx1V0pKMHovZ0o3UThZMkZ4eEd4RVZOeDJuQ3NLOG5ISlpOTFpo?=
 =?utf-8?B?eTVoOGZjQmZKcjY4YnhWRGhrclNWODZNbTRSYm0yTTZDRVMwZHc2UTV4UTVT?=
 =?utf-8?B?SGNZUnk0dlkvS0xUOXNQbHIvMFdEbnJQUWVuRjF2dytaR1BnWUtpWUt3ZGFj?=
 =?utf-8?B?Q2xIb3gyUlFFdzBkNVBydlErTi95WFlDMTVRRTM2MzlUeDBoQVBVS3FrQ2p0?=
 =?utf-8?B?QlhnbzZXNEcrVS9IcWladitnTFZFVy9tUDVWR3JDSmRXK2w2QUlFdXpjbmhD?=
 =?utf-8?B?ME1lZkJYeUtnWkJ5eng1ekUyL3RhYVJZdkovZzBIMTc1WVlpc3ZjL1EvMnAw?=
 =?utf-8?B?eVEwSWZiWjJTV3dscmk3Y0RtTnBWdlpIL1F4YWxnMzRJLzI3a21DQm5vWTRF?=
 =?utf-8?B?Z01TcjBhNGZoLy95MFRRVlI1bjFHQWxJVTRLcW9mN0tMWStrZi8rUlBCZys2?=
 =?utf-8?B?NlIrNnQycDBmNWtjV1NMQ0NBZlhPL2FJS0RkMk1MWHo3YjhWcW53c3Irc3Rp?=
 =?utf-8?B?ekJCaitYTytTNnRwUllhdU1qR0RVaS9IMm16dHIzWEJhTit6K1dsakU2NUJQ?=
 =?utf-8?B?Z21NY1h5S0lZM0ZGVXgrR0l3RUljRFZnTXZwQUppVkVZSyt3ZHFvRDI2OVFY?=
 =?utf-8?B?Z1YyRHR0ZjdIN0grZzBvTnpTK1dKaUE4emZLOFVZUm44UnF2L0MvRm8xRk1R?=
 =?utf-8?B?NkgwNVFjT3IzdnFVWDcybzRSV3ZmWExwL1JDMDNPVnQrOS9TWGVTeFU5RVFx?=
 =?utf-8?B?N0xMbmJhZTdEV0dMYi9OWG53RVZVUnJFK3F1eFJ4V1RJd3ZPTU92di85QXV4?=
 =?utf-8?B?b3U3MmorUFB5ZnU5dmtuRTBtc1ZLOFhZY1pWU0ZjekF3L2hOeHJlTlFFdGpi?=
 =?utf-8?B?TGFSOVBjVXF0ZHhOdDcxL1N0dy9BMDFici8wK3lDdG1vdXMwZUkrQXVsdFBF?=
 =?utf-8?B?MnJlcDl2RzhFT2JaUTI2VUxwNkNkUnl4dEFDb0ZRVUY0L3phZFFMeWc5WEpQ?=
 =?utf-8?B?eE1SWVlBRmg4ZEUrQjVRQUhUNTRHdTIySFl0dkZ5UTZLUngxRlVaenFVWDVT?=
 =?utf-8?B?VytRb0krTWtnWGxKMWF3bzQxY0NacFpIcDkwMktzWHVDSG9QdUl2SitvRVBn?=
 =?utf-8?B?Mnc9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58fae5f5-8e38-4058-b4f0-08daf86a8549
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9628.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 09:09:21.6686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6rxJJO7c+PDtHpxutS2qRjOupRrf3YQbHSF9dOG/YDdLNuZ0MyWEUJui+TbsBFyjdjE7cneVZ73U/qEyz/6a0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9050
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/17/2023 9:36 AM, S.J. Wang wrote:
>> There are cases when we want to test a simple "hello world"
>> application on the DSP and we don't have IPC between the cores.
>> Therefore, skip the wait for remote processor to start.
>>
>> Added "ignoreready" flag while inserting the module to ignore remote
>> processor reply after start.
>> By default, this is off - do not ignore reply from rproc.
>>
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>> ---
>>   drivers/remoteproc/imx_dsp_rproc.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/remoteproc/imx_dsp_rproc.c
>> b/drivers/remoteproc/imx_dsp_rproc.c
>> index 95da1cbefacf..ec298f8b019f 100644
>> --- a/drivers/remoteproc/imx_dsp_rproc.c
>> +++ b/drivers/remoteproc/imx_dsp_rproc.c
>> @@ -26,9 +26,20 @@
>>   #include "remoteproc_elf_helpers.h"
>>   #include "remoteproc_internal.h"
>>
>> +#define IMX_DSP_IGNORE_REMOTE_READY		0
>> +
>> +/*
>> + * Module parameters
>> + */
>> +static unsigned int imx_dsp_rproc_ignoreready =
>> +IMX_DSP_IGNORE_REMOTE_READY; module_param_named(ignoreready,
>> +imx_dsp_rproc_ignoreready, int, 0644); MODULE_PARM_DESC(ignoreready,
>> +		 "Ignore remote proc reply after start, default is 0 (off).");
>> +
>>   #define DSP_RPROC_CLK_MAX			5
>>
>>   #define REMOTE_IS_READY				BIT(0)
>> +#define REMOTE_SKIP_WAIT			BIT(31)
> Can we use a close bit with REMOTE_IS_READY,  like BIT(1)?

Sure, I'll send a v2.

Thanks,

Iulia