Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Cc:     linux-tip-commits@vger.kernel.org,
        Jason Gunthorpe <jgg@nvidia.com>, x86@kernel.org,
        maz@kernel.org
Subject: Re: [PATCH] irqchip/imx: Do not unconditionally enable GENERIC_MSI_IRQ
In-Reply-To: <Y8FL0ATYr/fYk8Gh@gmail.com>
References: <20221111122014.524842979@linutronix.de>
 <166869769649.4906.4149362707512771458.tip-bot2@tip-bot2>
 <Y8FL0ATYr/fYk8Gh@gmail.com>
Date:   Tue, 17 Jan 2023 10:25:24 +0100
Message-ID: <87wn5lldh7.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 13 2023 at 13:17, Ingo Molnar wrote:
>   config IMX_MU_MSI
>         tristate "i.MX MU used as MSI controller"
>         depends on OF && HAS_IOMEM
>         depends on ARCH_MXC || COMPILE_TEST
>         default m if ARCH_MXC
>         select IRQ_DOMAIN
>         select IRQ_DOMAIN_HIERARCHY
>         select GENERIC_MSI_IRQ
>         help
>
> But that's not unconditionally valid - for example on x86 UP kernel builds
> that have the local APIC disabled there's no MSI functionality - resulting
> in build failures like:
>
>   ./include/linux/gpio/driver.h:32:33: error: field =E2=80=98msiinfo=E2=
=80=99 has incomplete type
>   kernel/irq/msi.c:739:19: error: invalid use of incomplete typedef =E2=
=80=98msi_alloc_info_t=E2=80=99 {aka =E2=80=98struct irq_alloc_info=E2=80=
=99}

What prevents us from either

  - exposing msi_alloc_info_t unconditionally (it should not matter)

or

  - killing that 32bit UP && APIC=3Dn combo (which removes quite some
    ifdef cruft)


Thanks,

        tglx