Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Tue, 17 Jan 2023 10:06:48 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        kernel test robot <lkp@intel.com>,
        Shuah Khan <shuah@kernel.org>, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        linux-kselftest@vger.kernel.org
Subject: Re: [tip:sched/core 7/28] rseq.c:139:37: error: 'AT_RSEQ_ALIGN'
 undeclared; did you mean 'R_SH_ALIGN'?
Message-ID: <Y8ZlKOsN1wGk9tTc@gmail.com>
References: <202301170348.7WLKH1pl-lkp@intel.com>
 <bfa719c3-bd1f-5fc4-40ab-6dc6822b7628@efficios.com>
 <4449d8b5-b7a5-0f09-5b42-7b70ba00f8f6@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4449d8b5-b7a5-0f09-5b42-7b70ba00f8f6@linuxfoundation.org>
Precedence: bulk


* Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 1/16/23 13:18, Mathieu Desnoyers wrote:
> > On 2023-01-16 14:40, kernel test robot wrote:
> > > tree:?? https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
> > > head:?? 79ba1e607d68178db7d3fe4f6a4aa38f06805e7b
> > > commit: 03f5c0272d1b59343144e199becc911dae52c37e [7/28] selftests/rseq: Use ELF auxiliary vector for extensible rseq
> > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > > reproduce:
> > > ???????? # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=03f5c0272d1b59343144e199becc911dae52c37e
> > > ???????? git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > > ???????? git fetch --no-tags tip sched/core
> > > ???????? git checkout 03f5c0272d1b59343144e199becc911dae52c37e
> > > ???????? make O=/tmp/kselftest headers
> > > ???????? make O=/tmp/kselftest -C tools/testing/selftests
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > 
> > In order to fix this, I need to change -I../../../../usr/include/ for $(KHDR_INCLUDES) in tools/testing/selftests/rseq/Makefile
> > 
> > I can find 25 odd uses of the same pattern in the kernel selftests. Should I fix them all in one go ?
> 
> kselftest build depends on headers installed in the root directory.
> The main makefile enforces this dependency. If this test is being
> built without installing headers by itself, I think the scripts that
> build individual tests have to makes sure headers are installed first.

Why isn't the Makefile saying anything about it & enforcing it? self-tests 
are usually self-sufficient to build in the individual directories.

Thanks,

	Ingo