Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1187-g678636ba0d-fm-20230113.001-g678636ba
Mime-Version: 1.0
Message-Id: <a699e52a-db19-4374-a4bc-a3948ecc43ef@app.fastmail.com>
In-Reply-To: <20230117100845.16708-1-nikita.shubin@maquefel.me>
References: <20230117100845.16708-1-nikita.shubin@maquefel.me>
Date:   Tue, 17 Jan 2023 11:15:20 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Nikita Shubin" <nikita.shubin@maquefel.me>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Cc:     "Linus Walleij" <linus.walleij@linaro.org>,
        "Hartley Sweeten" <hsweeten@visionengravers.com>,
        "Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
        "Russell King" <linux@armlinux.org.uk>,
        "Lukasz Majewski" <lukma@denx.de>,
        "Bartosz Golaszewski" <brgl@bgdev.pl>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT
Content-Type: text/plain
Precedence: bulk

On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote:

> 
> +#ifdef CONFIG_OF
> +static const struct of_device_id ep93xx_gpio_match[] = {
> +	{ .compatible = "cirrus,ep93xx-gpio" },
> +	{ /* end of table */ },
> +};
> +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
> +#endif
> +
>  static struct platform_driver ep93xx_gpio_driver = {
>  	.driver		= {
>  		.name	= "gpio-ep93xx",
> +		.of_match_table = ep93xx_gpio_match,
>  	},
>  	.probe		= ep93xx_gpio_probe,

The #ifdef here is wrong and will cause a build failure because
of the unconditional reference to the variable.

Just remove the #ifdef/#endif.

    Arnd