Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4637433rwb; Tue, 17 Jan 2023 03:37:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXuvdVkLTZl9zf/hXtITGcRSwu436TwqRnUF/m424TEU1Un0AzgVEyQBvoz6ZK/W7uw4ZUvb X-Received: by 2002:a05:6402:1c10:b0:49c:fde2:a6f4 with SMTP id ck16-20020a0564021c1000b0049cfde2a6f4mr2511087edb.15.1673955469400; Tue, 17 Jan 2023 03:37:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673955469; cv=none; d=google.com; s=arc-20160816; b=R+0zgvE0vGk0skdp5NGpfbFPufn47cYlugJQTl8ZejHmlb5wUJLYX+9ojxhZVkLijT I42Xz8V9f51og8FWV/D6NLSQpXYC8j2QvOIjfX9Kx9qAQ23/maWJSjly5/IVpkLVK4wm ILMIWUbvkYSjKThgumxmPRfOF7UBaVlMxifbiJv/ednDyBJ/NNH6sLYb3kKa6RqbSgCt BBcJnJ1zZh0XjnlbU9RubQkyEi1AvTP5bQHDUCU6q5SvMSt09cV15s9PvzEy0OZaOVyB jnuqceVTmlOuItoEgE+VfDCo+FVrYDrEQrFIRGcatryJg0yZ/gVfQjkb/ZnEW5be0+qn GAWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=UU4vktItbYC+s7e52FldxEFBvYWh0qYYxPHBkPYFEMg=; b=un1OVH3jphKQLOK5Suhu0kRanSs66wZADVDwEQVzo6AXqT2sB51iMbnPenZvfkhbqk bQSomKDetcqQNI4SxmRKI3DlAw5Drxww7lXBvUfdMrhmiRit2GviTgpQr1bUrYZE1X3H BLCSn1krZnNzugVKRIo2IYP5s++pOxZozGA6DjSYJugTp/8SqQW94wuPBSHIf6xf5FYj pY6CeeYd9siZPz8lsJsl17pAkDeIgwNzM/vW4y02N8FGNlPzl6S4O8UVsIy9f5FXDwMj +JxBcqemurnsIGkJgutNgDQKjQArHxChX8hnbg/dVbyaJGXLyCjEtvGWvqPoRMYheZiK 5J9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mMO8keSE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht17-20020a170907609100b00871c59c032bsi4376837ejc.618.2023.01.17.03.37.36; Tue, 17 Jan 2023 03:37:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mMO8keSE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236874AbjAQLao (ORCPT + 48 others); Tue, 17 Jan 2023 06:30:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236812AbjAQLa0 (ORCPT ); Tue, 17 Jan 2023 06:30:26 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FF9C2DE57; Tue, 17 Jan 2023 03:30:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C22CCB815A2; Tue, 17 Jan 2023 11:30:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 7455FC433F0; Tue, 17 Jan 2023 11:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673955017; bh=uanmQl0XnnvrdM4uz2qfuTOC8CnMz0HQVeFeBnzZoqo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mMO8keSE91RebTkdCrhFdEGaW6K0pOB1KBkM9iSVijwttzY6TMfVTKos2ud5+dVYQ GqbX56S766aM4/AYPPw6cYUivV4DKI+pslV9vAERAGlCsb1tutjlY7bNtcULDUv/6q 0QA5AyfjF1cs8Yir/oCFHrS+/hC/w/6sxGE2fKoOllibS7UH2A8i5jshxAZrmbpAQ0 1xKvwMCx7qxBDzPi8cfyyFvF+q1DV16Vr948HW4ICBpgbXGvqaN43J2oZP2uEhCxpj fU8lT1SnDpzzEkCQX+9H1IEcflabpvy1aFswvQidC6fqzLA9m+SEeWIq5q84hTsIFt m3rqA/HAZBV4w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 56D5DC41670; Tue, 17 Jan 2023 11:30:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v3] inet: fix fast path in __inet_hash_connect() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <167395501735.22351.17426243090589547369.git-patchwork-notify@kernel.org> Date: Tue, 17 Jan 2023 11:30:17 +0000 References: <20230112-inet_hash_connect_bind_head-v3-1-b591fd212b93@diag.uniroma1.it> In-Reply-To: <20230112-inet_hash_connect_bind_head-v3-1-b591fd212b93@diag.uniroma1.it> To: Pietro Borrello Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, c.giuffrida@vu.nl, h.j.bos@vu.nl, jkl820.git@gmail.com, kuniyu@amazon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni : On Sat, 14 Jan 2023 13:11:41 +0000 you wrote: > __inet_hash_connect() has a fast path taken if sk_head(&tb->owners) is > equal to the sk parameter. > sk_head() returns the hlist_entry() with respect to the sk_node field. > However entries in the tb->owners list are inserted with respect to the > sk_bind_node field with sk_add_bind_node(). > Thus the check would never pass and the fast path never execute. > > [...] Here is the summary with links: - [net-next,v3] inet: fix fast path in __inet_hash_connect() https://git.kernel.org/netdev/net-next/c/21cbd90a6fab You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html