Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4657955rwb;
        Tue, 17 Jan 2023 03:58:32 -0800 (PST)
X-Google-Smtp-Source: AMrXdXvQMoHGbU0NWmJpVubcDAd5ovzI7b32exIcycAhOdvUf+WzAAKsmlJwtllQ845wdZB8uYeV
X-Received: by 2002:a17:906:6851:b0:873:343e:f814 with SMTP id a17-20020a170906685100b00873343ef814mr1001209ejs.40.1673956711824;
        Tue, 17 Jan 2023 03:58:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1673956711; cv=none;
        d=google.com; s=arc-20160816;
        b=yfZ9ZZZMmM8fRt6KM0GTGNk8i5lc/25ZQrziRzU0xmuDh/HJOXW35rAB0BhvJZldXc
         pwpPveOo/v2cmRgVeQ8C1LzEf0ozoGP90YqoLGkK/dF2hkJpqj7FG2Sorhz1FyfXOnUj
         BvXOQoEEmXymeiEtI8yc2CgZsEc+lKVpsaPmZUUzlIEphZFmXbqZoeL6hZj7jklvVjgN
         sEyvT027sxX2vwktRYOGtxT9Wkk9h5R3R1YXROTMYOK0YsszMZG59Z1bDvE8sm8cAdN9
         P92ZD30vswl0mJ1+wJJeaEm4HkDFLD8UDvVf+AYupT4V1wq7AojFRIoCMe2d2L+hWN0U
         3S6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=QA+EXaHDhgrT91L4b27jXr/sKibjqOXCePDQFBIba6M=;
        b=UCs85bkR0glZescJMVLUyWnh+RT2EHc28TkqPcjDSV4Y+SDMNjdq5jquWaDAjP0x01
         7N3xJ9t4hnBIavxCTA8stRBOhWjOsHpkcvX1q/6FtYdUPR+wKkWfIGcATfbe2873EdvG
         YeaK1xhUVKtUb7FxjlaYGG0l5oN7kFlKWeIed7ujGAOeIJstz1qvt+CHNcMqXCn//Hx2
         3jgtqSIiEE7rabzE8n5tvu70/77GPwXTJl7v36YRRBS4pjvJz19JdggKOR4YUh4XkdDT
         LzBJLgY/NdTwBJI1PTClJ5FeBEkfkjGzVScuysHXem3+35s7sIQqIJjUI4CwdRECSrk2
         8a3A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="l//Dxl90";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id js6-20020a17090797c600b0084d45d2e5ffsi2267982ejc.566.2023.01.17.03.58.19;
        Tue, 17 Jan 2023 03:58:31 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="l//Dxl90";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236610AbjAQLGC (ORCPT <rfc822;a.beregalov@gmail.com>
        + 49 others); Tue, 17 Jan 2023 06:06:02 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58656 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S236693AbjAQLFY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Jan 2023 06:05:24 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 331A932539;
        Tue, 17 Jan 2023 03:05:23 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id C422261259;
        Tue, 17 Jan 2023 11:05:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93F70C433D2;
        Tue, 17 Jan 2023 11:05:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1673953522;
        bh=F2V6EST1CT47fG0xpmIb+kkj3J1aCuuwZ9+tl+qRx9E=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=l//Dxl90JRSZPjmb2IY90kDDZKOIZQCTI2mUeZHxzVk5dAo0bSFoD8zxQsqQierjn
         efCqaJFdZZDt0erqG6gUUNjk4YywsyudY1cuVi8ci6nnEV97L1TBeYGLFx9t2aHCfZ
         3zforAP0/on3GCw34j4mdS1x0CPwY+/NWrnUp6MJmZXN7oOBGgipRupdzF4bnAEk8o
         yeqVzWxVDR48O22wWGvD55eV1z2+tqCVuWItmGch73JF2HRJQd4JT3C6UKADymCygB
         gJaVaYuwLxcuYBSaJ04dV/J8wjJWt3KpAJat8Yppcu+ClGFuVROXVo0ZJfBZ62r32K
         xDlqPqWlq/zWg==
Date:   Tue, 17 Jan 2023 13:05:18 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Maksim Davydov <davydov-max@yandex-team.ru>
Cc:     rajur@chelsio.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, anish@chelsio.com,
        hariprasad@chelsio.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net/ethernet/chelsio: t4_handle_fw_rpl fix NULL
Message-ID: <Y8aA7vOZByuN9ZGC@unreal>
References: <20230116152100.30094-1-davydov-max@yandex-team.ru>
 <20230116152100.30094-3-davydov-max@yandex-team.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230116152100.30094-3-davydov-max@yandex-team.ru>
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 16, 2023 at 06:21:00PM +0300, Maksim Davydov wrote:
> After t4_hw.c:t4_prep_adapter() that is called in cxgb4_main.c:init_one()
> adapter has it least 1 port for debug. 

IMHO it is wrong to keep this interface and the logic for this debug
code should be deleted.

Thanks