Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221226031417.1056745-1-victor.liu@nxp.com>
In-Reply-To: <20221226031417.1056745-1-victor.liu@nxp.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 17 Jan 2023 13:54:42 +0100
Message-ID: <CAMuHMdWiebe0c59-sWjaBmU9T-OxWX7HbPF9eM528UeaHDfT=w@mail.gmail.com>
Subject: Re: [PATCH v5 RESEND] drivers: bus: simple-pm-bus: Use clocks
To:     Liu Ying <victor.liu@nxp.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        saravanak@google.com, linux-imx@nxp.com, greg@kroah.com,
        arnd@arndb.de
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 26, 2022 at 4:13 AM Liu Ying <victor.liu@nxp.com> wrote:
> Simple Power-Managed bus controller may need functional clock(s)
> to be enabled before child devices connected to the bus can be
> accessed.  Get the clock(s) as a bulk and enable/disable the
> clock(s) when the bus is being power managed.
>
> One example is that Freescale i.MX8qxp pixel link MSI bus controller
> needs MSI clock and AHB clock to be enabled before accessing child
> devices.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v4->v5:
> * Fix build warnings when CONFIG_PM=n by using RUNTIME_PM_OPS,
>   NOIRQ_SYSTEM_SLEEP_PM_OPS and pm_ptr macros.
> * Drop Geert's R-b tag due to the fix.
> * Resend based on v6.2-rc1.

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds