Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4774496rwb; Tue, 17 Jan 2023 05:28:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXtgO9fT4Sdj++h3Q+XTFvkiZOY/VzJ6V08Y9WlpQOLaj4lMS6O255UVt5P5KUuzCxrCJ2iW X-Received: by 2002:a17:906:3f94:b0:861:4671:a834 with SMTP id b20-20020a1709063f9400b008614671a834mr2435062ejj.71.1673962101491; Tue, 17 Jan 2023 05:28:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673962101; cv=none; d=google.com; s=arc-20160816; b=jKaDbiVdV6EQTWM1U6NSmSnFTMnaysAQAOdULHjcTRE6AGI0AUgJvJ0Pisyk4iFgaV Q2wbQo7GJ+bfHy6f3/j4YeHbtvD+PU8uk9bXTsKfwHewO/hO568lZ0MboYexa0H/0zXp MlWVuZYCMx03i101sEmb1QKuhnQdUMXusz6z1Pi29nblzvcWjNTzPdG2+w6l+C/ecpFp xvsKdrE4UO0u5NHGRlyQbEJwPpYATB2mxvwx2vPfbzxDdvApVq/RTsvsT9xP0kz9pbii krJPehXT7rsReqLvoMF3J6CtaXB4YFsg4xPMvSJS65wzqbKzn1WnjoYJOYecnyF1VemS Cb2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=TlgP8iiqbABAh0wB4hfhbNaQJPj2jTpy7HZYW9d47Pg=; b=P+tTK4KeKlV4lNWObpeN6QoJVQVvBljr4ntPKA7ZPxHcyuRC+OoCuSfsPHKTWcBoZc BCJZ7PQDRmp6sFL2GeqU9KPZky8fb6oPuZemUu/VcitlQGWtt+rZqbGZhA83dIxpyzSm A8nJ1+lIGNr3/2ypxXZ18S0uD8VCZcN84LSzlUBbr/63BHWgx7Nk55jeuRJAG32nBrfX G8xwg2sUWGj0jfvpOpdjupcx98wID6ZxXlBofv8o9RMLTIMXymr48utJZKSN4vaARV/n woiJ9TdPbZIqwj5K6AE3/nPh4Z5/DuropsLRqKQdIay736xfuDJN5Ctg0HRmpGdGQ9Ch i3NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W55p0ojB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz4-20020a1709072ce400b008735377d5d9si840340ejc.236.2023.01.17.05.28.09; Tue, 17 Jan 2023 05:28:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W55p0ojB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237003AbjAQM5J (ORCPT + 48 others); Tue, 17 Jan 2023 07:57:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236817AbjAQM4m (ORCPT ); Tue, 17 Jan 2023 07:56:42 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A450491 for ; Tue, 17 Jan 2023 04:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673960151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TlgP8iiqbABAh0wB4hfhbNaQJPj2jTpy7HZYW9d47Pg=; b=W55p0ojBDHVIl81GfY0YsckFDD8dGQxhB+VGYN/50hi0bg0OE/UgDXhBoWxpz16dW0N2px /ZMEpYHxnyb6Ql7j6aL5PXerCeJ4RF6eNanwqDw4qYJAEXAeEnPteYNqKx5Wis0COj17/L dp5/WxALkrDd2f5ESAZt0+TwU//qI3k= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-570-NfPYpb7DOY2LbVjksg4paQ-1; Tue, 17 Jan 2023 07:55:50 -0500 X-MC-Unique: NfPYpb7DOY2LbVjksg4paQ-1 Received: by mail-qt1-f199.google.com with SMTP id g26-20020ac84b7a000000b003b639bca907so1194831qts.15 for ; Tue, 17 Jan 2023 04:55:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TlgP8iiqbABAh0wB4hfhbNaQJPj2jTpy7HZYW9d47Pg=; b=7+ODCc0IcO7UHldK60mMKYvkgTeT4re6EwASd9CWxFHdwevANVJZX8Ky8VI/wMhvPN c/GLqpYERKtMgIesuAETqhgK809zk7yCYN//oY3UP/bE1QFYJTBx8DS/r4s/b/28seQm oxPUNZ/rVyWzilJbCEBuPWQKoNphv4JIGI9jal+EQ0GPQC6q9vR5oH4mDD8oWvJiGgAQ pQHhTU+qg2pdiuNDpafqjWGaYkHVPP1xRoVLHTpg5KevblXe2tXBR4ZWjrViPNg52Puc JTfIl4mKewZGelqO5yfVeLkmyBExwHiY+woeYs2gNo70+tG5KS9h8pRdSEuPMQrfl/gP FLKA== X-Gm-Message-State: AFqh2kpfSO9tr693XMxkaUKQGRz2rAWdVh0z/Cc7TBS54idaPF5cZqBL puZs5O4tbj0WAd+cOaFxOCcQVpg7yW+YdG2Jn5aiH5enLPE8febueDAda+uM3g9R8ica6ag3ww1 r9GKGJEb5QcubRLMCkwgTOAyJ X-Received: by 2002:ac8:5157:0:b0:3b6:302b:7dcb with SMTP id h23-20020ac85157000000b003b6302b7dcbmr3258873qtn.61.1673960150199; Tue, 17 Jan 2023 04:55:50 -0800 (PST) X-Received: by 2002:ac8:5157:0:b0:3b6:302b:7dcb with SMTP id h23-20020ac85157000000b003b6302b7dcbmr3258848qtn.61.1673960149970; Tue, 17 Jan 2023 04:55:49 -0800 (PST) Received: from gerbillo.redhat.com (146-241-115-179.dyn.eolo.it. [146.241.115.179]) by smtp.gmail.com with ESMTPSA id v14-20020a05620a0f0e00b006fbb4b98a25sm20349988qkl.109.2023.01.17.04.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 04:55:49 -0800 (PST) Message-ID: <4bd311213cb41649215d0cdf9966fc9ed90d7aae.camel@redhat.com> Subject: Re: [PATCH v2] net: fec: manage corner deferred probe condition From: Paolo Abeni To: Pierluigi Passaro , andrew@lunn.ch, wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com, linux-imx@nxp.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: eran.m@variscite.com, nate.d@variscite.com, francesco.f@variscite.com, pierluigi.passaro@gmail.com Date: Tue, 17 Jan 2023 13:55:45 +0100 In-Reply-To: <20230115213804.26650-1-pierluigi.p@variscite.com> References: <20230115213804.26650-1-pierluigi.p@variscite.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sun, 2023-01-15 at 22:38 +0100, Pierluigi Passaro wrote: > For dual fec interfaces, external phys can only be configured by fec0. > When the function of_mdiobus_register return -EPROBE_DEFER, the driver > is lately called to manage fec1, which wrongly register its mii_bus as > fec0_mii_bus. > When fec0 retry the probe, the previous assignement prevent the MDIO bus > registration. > Use a static boolean to trace the orginal MDIO bus deferred probe and > prevent further registrations until the fec0 registration completed > succesfully. >=20 > Signed-off-by: Pierluigi Passaro Here there are a few formal/process-related mistakes: - wait at least 24h before posting a new version - please include the target tree name into the subj prefix this looks like a fix, so it should possibly target net and include a 'Fixes' tag into the SoB area. Please be sure to read and follow the process documentation and the netdev specifics bit from the current kernel source. Thanks, Paolo