Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH v2] f2fs: fix to check warm_data_age_threshold
Date:   Tue, 17 Jan 2023 21:24:42 +0800
Message-Id: <20230117132442.77645-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5DoyguF8g4xBQBm0tH6479bOIagYVR9hU4tODeEKlkhdf9my6d/G5FDYg5dR?=
 =?us-ascii?Q?5zpJLbwCOHSac3ttmNATYTmHgN9GWklC8rpE3/+Q4zm2EfcXWxTgAVqsEQPI?=
 =?us-ascii?Q?64yFFYgxyzHbZuX17ucCPqqy6t/d4W28yvhwno66Unq5tG6bzmok20YZAorM?=
 =?us-ascii?Q?ulEZKVeKNsLrDSRrziF+DS6ALEZ5Jc9PDhMu9uDduI0+gy57x2tIAYnxxbFs?=
 =?us-ascii?Q?2HGwEP6OcTj8TH3LJf9ACqQiG8xhMmJPVXyQYdlC5eRne4eEGayxngz5RKEZ?=
 =?us-ascii?Q?lKpzCnNgQ6lbYZNtZVn+L33L4nQ7K2yOgpWWb2IV/voWYiTkN5nYNpk1ZXHl?=
 =?us-ascii?Q?saBpzydc/FIcHSW6kS9kavGqOnWz2Rd3iMg66/0lqxBvRILzjjmNGGmJlELK?=
 =?us-ascii?Q?NOZL0VnVu286N8lllzHJDvyYAQrxJ2rYCGGEeIrsjg0LUy5BXELclTxCPc7J?=
 =?us-ascii?Q?yXLgWPWl8k0MZTukB1pJhoe3iFKsw5EkZVxy8DUM/QNhI32jiBikvT4x1tB2?=
 =?us-ascii?Q?wANa31w6QbhZQnXyuFJj/8pTOMU29mvibpp3v2uFm/Bkkc6PZ1wbLvXVxUEr?=
 =?us-ascii?Q?wa88vP+9e6nLXqXH+DO/+giLa+3+IA+JlVVRrp4jcIdvIRw/7jjgTlZaOkRw?=
 =?us-ascii?Q?bXrXiz4/MqxPeQdF8Cwoj+RsuVI1pK02y1V3DptnyuYv5tdNje134xGX2/gb?=
 =?us-ascii?Q?5tUtoRob05z7j2cMwYedmyo/TDV9pZ3yER4BLPY/Bn7kQ86W9e4h5qfsw8Ae?=
 =?us-ascii?Q?Wuhf8Xhw/T51qaeRHOX+DEQxSpfRnW00hbHFxwzwVvuiNw/Caxta0h8kLU+5?=
 =?us-ascii?Q?KbkKV4JDCj+yt9eGdy9hBJjUytewqwBhMfSfPjfNHY0gxLcqmaa5jHWGb3dC?=
 =?us-ascii?Q?D7zhQen7Aq7jTLLbta4BrRF9E5R6bjqVkyuAjlbPS7l8hjoPf6mF5cArTo49?=
 =?us-ascii?Q?w8b5erCGveoR9LuzFnYcwyryS9nx1+/waNOoQMh2CqOwXVYsrnxBh4Ujrs1Q?=
 =?us-ascii?Q?NzYwIyf7fxeOLjyJcm8UO/AXCoFNVF3TpBgIqYdhL0GRw9mYji6JyxQttL/e?=
 =?us-ascii?Q?0ZDGF5M6I26YV8u2g1LF1HEeMzdPcGbq7ZpNER7xJ05S/cV1d55+uiYJqsCE?=
 =?us-ascii?Q?qhF6Y3OTqQZAx+J1BdYqMePIGBh6EbkkgTGgH3DC94UIXl2NMQ1nt06Dc5FI?=
 =?us-ascii?Q?nO7pDKcjGRVE7q2MmvaVkrGcDsXDPMC/hJjavY9o3dQeR8T8HmyP6OuJKYQe?=
 =?us-ascii?Q?+GrHsTNmupyrYwOgr8sIb7fvRN4CxfVqu3RFv8taq6lLXiDJrUp/uqLGViPo?=
 =?us-ascii?Q?yCGAm0XCnmQaIWn2YEPPslPtFbnTZu7lMbCIte9QnM+nxI/Vx5OzAk7iETM4?=
 =?us-ascii?Q?7PXOIb2EvFeO3Ql6wxYUFYcKBLL6/9cGWVphpll8obpTV0qzAFCHhQ94BuC9?=
 =?us-ascii?Q?7loSP1/qOXOS4yVZujNAQeKkQqFo+hTf+nn39lKKa5m26/8XMblBsUlVgDaF?=
 =?us-ascii?Q?Vn/10O3vme47o1yLC/OYwitOEZyDwNNUtLDkIrFrwBPlnAB+ig/PJpLEtMFk?=
 =?us-ascii?Q?T/8r1MmpX8j8iRFNqimOTgdgi19iBtFzcR+flcEX?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a26637f-201b-4a9c-a9a6-08daf88e37cc
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 13:24:53.3582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cHSONvp9wzm/V10VRLqm+scOLwGaJPckCeb29Q1rjuyyjFTNX5fMXpykwUyarkI9Zo0SeecWxEAjv+MXA1S9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4268
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

hot_data_age_threshold is a non-zero positive number, and
condition 2 includes condition 1, so there is no need to
additionally judge whether t is 0. And let's remove it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index e396851a6dd1..3c6425f9ed0a 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -689,7 +689,7 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
 	}
 
 	if (!strcmp(a->attr.name, "warm_data_age_threshold")) {
-		if (t == 0 || t <= sbi->hot_data_age_threshold)
+		if (t <= sbi->hot_data_age_threshold)
 			return -EINVAL;
 		if (t == *ui)
 			return count;
-- 
2.25.1