Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 13:57:48 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Nylon Chen <nylon.chen@sifive.com>
CC:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
        <nylon7717@gmail.com>, <zong.li@sifive.com>,
        <greentime.hu@sifive.com>, <vincent.chen@sifive.com>
Subject: Re: [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled
 LED's active-low properties
Message-ID: <Y8apXMzlDYhuLOqV@wendy>
References: <20230113083115.2590-1-nylon.chen@sifive.com>
 <20230113083115.2590-2-nylon.chen@sifive.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="sCY470tgzGEL1xs2"
Content-Disposition: inline
In-Reply-To: <20230113083115.2590-2-nylon.chen@sifive.com>
Precedence: bulk

--sCY470tgzGEL1xs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Nylon,

On Fri, Jan 13, 2023 at 04:31:14PM +0800, Nylon Chen wrote:
> This removes the active-low properties of the PWM-controlled LEDs in
> the HiFive Unmatched device tree.

Does unleashed also have the same issue?
It has the same compatible at the very least.

Thanks,
Conor.

>=20
> Signed-off-by: Nylon Chen <nylon.chen@sifive.com>
> Reviewed-by: Vincent Chen <vincent.chen@sifive.com>
> ---
>  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/r=
iscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 07387f9c135c..11f08a545ee6 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -52,7 +52,6 @@ led-controller-1 {
> =20
>  		led-d12 {
>  			pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>;
> -			active-low;
>  			color =3D <LED_COLOR_ID_GREEN>;
>  			max-brightness =3D <255>;
>  			label =3D "d12";
> @@ -69,19 +68,16 @@ multi-led {
> =20
>  			led-red {
>  				pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>;
> -				active-low;
>  				color =3D <LED_COLOR_ID_RED>;
>  			};
> =20
>  			led-green {
>  				pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>;
> -				active-low;
>  				color =3D <LED_COLOR_ID_GREEN>;
>  			};
> =20
>  			led-blue {
>  				pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>;
> -				active-low;
>  				color =3D <LED_COLOR_ID_BLUE>;
>  			};
>  		};
> --=20
> 2.36.1
>=20

--sCY470tgzGEL1xs2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY8apWwAKCRB4tDGHoIJi
0oUZAP0e0gBBGBiwm+MQJEOj24ncWAh9IauZg6zX7i9eBH9TjQD/Tt9PH6/uULNn
WSahkdpB8z8jOujvbc02ciHmsSMLqQU=
=b3Gd
-----END PGP SIGNATURE-----

--sCY470tgzGEL1xs2--