Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4903453rwb; Tue, 17 Jan 2023 06:59:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXuB3KKhXdonUjk94a91xAWsgaTT4p1dm/Naq5FbYPsUHHoalNksJy3JsGM8KpcduJvaNyQm X-Received: by 2002:a17:906:6152:b0:870:3e83:e45b with SMTP id p18-20020a170906615200b008703e83e45bmr3225072ejl.35.1673967582899; Tue, 17 Jan 2023 06:59:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673967582; cv=none; d=google.com; s=arc-20160816; b=RfICEUyLJVLcjZ0bMsTD3cHCzcOlmTC/OuYzGzMBOQv4wWmYOzYJcnqjvHo/O/00X6 zzqrLLHSPpxSNx8LG4WtdQ05veY5V8MQt88epJh/K3+qV9ldeGh0BN1LGk5iXjikzdap l8bmUZ58Gf/wHNTtmHfKJOLVVYP73x/Nzz41Lg0WQSg8ustSM01oj9/Y7fjgo4EtZclH eVUt9pHpF1oEyB7lP5c3eD+0XJEgjSsaXyYAEqsAH5GwaS7aFNpeK3QyAMzVTZvrkkHt Z4+XmWw8ELgqQf+b+C3XKwU9Jo1R6im8armB+x3jTj6ky7CqATEdL6IGgfwVD14IFOlJ oQ4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=jdffIU45+BkGd0ZKMMKRqmBZ5fBTh2z0Mubg/t90l/g=; b=PwRJJsYdg2Ej7r7pOVm1jaQWwTMdtP0k144A2QKcR4lOewbGdYmzghwvAbarotVt7N z2lsfFfq5wkQk5lN5JxD5pYdKQeg1+dAt7Rnlg1cjdXQ8y7Kxk9issgSlIWTZNX05P2V cc6vBoB8wHeeiSPOdsr4DVgogz+GBx4krWbsOrv6bJamT/TAjjeokwIdX7cxtZyMyCEr TxQq9TQaXxh9vpQQ3PWJrW/IvVZTsMhvEjoQbp0IeCrZKqR+v3kxfw1pJSRqYDZpui63 /djMlywuiI1vAS27T7JA3iFz24oej508Gt0Zek+yz2pglAODH+HEVZHJ5IK/T9JTT5Cv /pzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg28-20020a170907971c00b0086fb8469f4csi4685842ejc.191.2023.01.17.06.59.31; Tue, 17 Jan 2023 06:59:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbjAQORS (ORCPT + 48 others); Tue, 17 Jan 2023 09:17:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjAQORQ (ORCPT ); Tue, 17 Jan 2023 09:17:16 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2F67B32525; Tue, 17 Jan 2023 06:17:15 -0800 (PST) Date: Tue, 17 Jan 2023 15:17:08 +0100 From: Pablo Neira Ayuso To: Alok Tiwari Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH 6.1] netfilter: Null pointer dereference in nf_tables_updobj Message-ID: References: <20230117134537.3400252-1-alok.a.tiwari@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230117134537.3400252-1-alok.a.tiwari@oracle.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2023 at 05:45:38AM -0800, Alok Tiwari wrote: > static analyzer detect null pointer dereference case for 'type' > function __nft_obj_type_get() can return NULL value which require to handle > if type is NULL pointer return -ENOENT This should not ever happen, but it is good to have a failsafe in this path. I'll take this into nf.git, thanks.