Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cfd56381-e9b1-b316-319c-c1f504daf1d9@ti.com>
Date:   Tue, 17 Jan 2023 20:19:15 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v6 2/3] dt-bindings: remoteproc: ti: Add new compatible
 for AM62 SoC family
Content-Language: en-US
To:     Devarsh Thakkar <devarsht@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <devicetree@vger.kernel.org>,
        <mathieu.poirier@linaro.org>, <p.zabel@pengutronix.de>,
        <linux-remoteproc@vger.kernel.org>, <robh+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <s-anna@ti.com>
CC:     <hnagalla@ti.com>, <praneeth@ti.com>, <nm@ti.com>,
        <a-bhatia1@ti.com>, <j-luthra@ti.com>
References: <20230116151906.549384-1-devarsht@ti.com>
 <20230116151906.549384-3-devarsht@ti.com>
 <1a70a28b-b406-4d84-ced9-4d66bad94652@linaro.org>
 <bd0460de-eff2-9162-4edb-d3527041d7a6@ti.com>
From:   "Raghavendra, Vignesh" <vigneshr@ti.com>
In-Reply-To: <bd0460de-eff2-9162-4edb-d3527041d7a6@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Devarsh,

On 1/17/2023 10:54 AM, Devarsh Thakkar wrote:
> Hi Krzysztof,
> 
> On 17/01/23 00:36, Krzysztof Kozlowski wrote:
>> On 16/01/2023 16:19, Devarsh Thakkar wrote:
>>> AM62 family of devices don't have a R5F cluster, instead
>>> they have single core DM R5F.
>>> Add new compatible string ti,am62-r5fss to support this scenario.
>>>
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions. However, there's no need to repost patches *only* to add the
>> tags. The upstream maintainer will do that for acks received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>
>> If a tag was not added on purpose, please state why and what changed.
> I apologize if it was not clear but yes I didn't put the tag as
> patch was updated to use cluster-mode=3 for am62x as per review comments on
> https://lore.kernel.org/all/20230110183505.GA2741090@p14s/

It would be helpful in future if you document why tag was dropped as
part of change log (below tearline) to indicate its intentional.

> 
> I'll append a note below commit message on Reviewed-By
> removal when I post the next series.

> Regards
> Devarsh
>>
>>
>> Best regards,
>> Krzysztof
>>