Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <TYCP286MB23239EE29037F6051CFE5691CAC09@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
References: <TYCP286MB23239EE29037F6051CFE5691CAC09@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Wed, 18 Jan 2023 00:07:25 +0900
Message-ID: <CAKYAXd8AjjzXWEmMDydgRm1p6F7Fo-s836iWryRGeQPYbjcQTQ@mail.gmail.com>
Subject: Re: [PATCH 0/6] ksmbd: Minor performance improvement & code cleanup
To:     Dawei Li <set_pte_at@outlook.com>
Cc:     sfrench@samba.org, senozhatsky@chromium.org, tom@talpey.com,
        hyc.lee@gmail.com, linux-cifs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

2023-01-15 19:32 GMT+09:00, Dawei Li <set_pte_at@outlook.com>:
> It's a small series mostly aimed at performance improvement and code
> cleanup.
>
> Among which, First three ones are performance related commits, and
> other ones are minor code cleanup.
except 0005 patch, Acked-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks for your patch!
>
> 1 & 2: list => xarray, acclerating index based lookup.
> 3: rwlock => rcu primitive, enabling write & read concurrency.
> 4: Simple duplicated code removal.
> 5: Minor code rework and exception handling.
> 6: Simple typo fix.
>
> Dawei Li (6):
>   ksmbd: Implements sess->ksmbd_chann_list as xarray
>   ksmbd: Implements sess->rpc_handle_list as xarray
>   ksmbd: replace rwlock with rcu for concurrenct access on conn list
>   ksmbd: Remove duplicated codes
>   ksmbd: improve exception handling and avoid redundant sanity check in
>     loop
>   ksmbd: fix typo, syncronous->synchronous
>
>  fs/ksmbd/asn1.c              | 19 ++++---
>  fs/ksmbd/connection.c        | 54 +++++++++++---------
>  fs/ksmbd/connection.h        |  1 -
>  fs/ksmbd/ksmbd_work.h        |  2 +-
>  fs/ksmbd/mgmt/user_session.c | 98 ++++++++++++++----------------------
>  fs/ksmbd/mgmt/user_session.h |  6 +--
>  fs/ksmbd/smb2pdu.c           | 52 ++++++-------------
>  7 files changed, 93 insertions(+), 139 deletions(-)
>
> --
> 2.25.1
>
>