Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4966518rwb; Tue, 17 Jan 2023 07:36:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXtFD7PvUUcK7dRnc8GArRcdM7xElJFf66dcd//fQgZANNOq8Qkp2qOAhdki//CqXKWcN8ES X-Received: by 2002:a17:90b:19c8:b0:229:6bff:d336 with SMTP id nm8-20020a17090b19c800b002296bffd336mr3688788pjb.10.1673969800733; Tue, 17 Jan 2023 07:36:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673969800; cv=none; d=google.com; s=arc-20160816; b=weBlsQTOHWfhLW1f9sj0lXpYRwm1zoA+cNWf6cynEOGXd7luQBn7c8mkvtcKgWBSds joknI/+ATCDyR2NVK0wz2P8tqlv5Lz1a9ah3omrK89XZKX56RVpEkKb7vOxBKMN2ICDJ HrNHxdjI3gWtqg7xe9j/9nlQy4AUGarXUOJLqKgl4zZbK+aDKIGAVTPmRLO9z2oOo9Oz D3ippal/JJCPTtg5NKGxROs5C4NwbX/CW5b1IGByYQvlIik7Fu2ekTaXe4R2JOfaJ9WV v+f+Ry34k6qQfx0/1OLjXi6m83XSbGOoswJ9wvNQLcdWDRvtxrs4jyK/mobRoS1q7pM0 z2Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sbKnvqVmnloOJo8HuU71AavisB7MfzGt7Jm/2K4Gntk=; b=WNW2W+1A/NwrSAGHXqdRU1UbRaPcIgqhxTjgiFlQOfUUwg0jO2fpjd5Yl5RzOHAi96 TjAzuqWeOpd/8IbGF1UxWQpyiDSHHiDVBdm2Zr407aPDtfXbhkIIqlgw8j0DngM+66fw o0CF23JOPV3qTe+r/WSYKG/2i54WgCwpUmdBevtlFHzUrWSVqKHR0OGkaY2yDPXpC8UU pXUPwcX/GV7tQJy3O9x8vMGbqiMkrEei8wphXivjKpi+MVdL2Oe48JwzXQ5xuStxC+08 lAvg6HO6frpeTJrvXtjplXlynMkY6jJMcKWyYe2paqa+BA8djr/h1VUR2hs9qKthd1lT 0U4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=L8FayK7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a63f110000000b004c7ca3c6e60si10331893pgi.42.2023.01.17.07.36.34; Tue, 17 Jan 2023 07:36:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=L8FayK7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbjAQPQw (ORCPT + 48 others); Tue, 17 Jan 2023 10:16:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjAQPQu (ORCPT ); Tue, 17 Jan 2023 10:16:50 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A20360BC for ; Tue, 17 Jan 2023 07:16:49 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4AE766892D; Tue, 17 Jan 2023 15:16:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673968608; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sbKnvqVmnloOJo8HuU71AavisB7MfzGt7Jm/2K4Gntk=; b=L8FayK7SEImi09Gn0nDikdyr4xu02WwvC2ahHV7p0kuKZX7Q+cRdDKjni+/ewcuaHQ5T0b Xn8wfQg5p+XnZ1SOy4Ud0+LCTzpv42KKhKu+cv3JVr8p4V1KSdWsVyDbuUjRaX8oSaiPKn BNiG8VEKSrvA6jY77OladKujxKFstkc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D33C1390C; Tue, 17 Jan 2023 15:16:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q9KbBuC7xmMcRgAAMHmgww (envelope-from ); Tue, 17 Jan 2023 15:16:48 +0000 Date: Tue, 17 Jan 2023 16:16:47 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, paulmck@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 17/41] mm/mmap: move VMA locking before anon_vma_lock_write call Message-ID: References: <20230109205336.3665937-1-surenb@google.com> <20230109205336.3665937-18-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230109205336.3665937-18-surenb@google.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 09-01-23 12:53:12, Suren Baghdasaryan wrote: > Move VMA flag modification (which now implies VMA locking) before > anon_vma_lock_write to match the locking order of page fault handler. Does this changelog assumes per vma locking in the #PF? -- Michal Hocko SUSE Labs