Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 08:05:38 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
        "LKML Mailing List" <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Ingo Molnar <mingo@kernel.org>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "Ashok Raj" <ashok.raj@intel.com>
Subject: Re: [PATCH v4 4/6] x86/microcode/intel: Use a plain revision
 argument for print_ucode_rev()
Message-ID: <Y8bHUpkHknqcq6ti@a4bf019067fa.jf.intel.com>
References: <20230109153555.4986-1-ashok.raj@intel.com>
 <20230109153555.4986-5-ashok.raj@intel.com>
 <Y8RWZu/SGYV7Eqst@zn.tnic>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y8RWZu/SGYV7Eqst@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWIyK0pZUFc0VXAyemozOEtlamg5ZWNWWDhKbXlOdVAvbmRBSkgwcGd1TURn?=
 =?utf-8?B?d0FNQWVqUGE5bVZjOVhtWXBZUFUxRnhBaUExeFJFTXpBQmMxbFZPZjc4eTZT?=
 =?utf-8?B?Uk5tQjJRRzJZRUEzelUreGVZWHp6YVR6MFlLWjJaVlUwQUpqaTBtK3NxNEln?=
 =?utf-8?B?NUlhTEhQaDFKTXdkdjVGcXIrSU5GSksxZ1F3WmN5d0E0UCs2STdZUUxYT0ts?=
 =?utf-8?B?bEs5d0drSWJEaks3dHMvZDFETjFmeWdUV2JodUxXSmRMejdpSEpQRjNCRURz?=
 =?utf-8?B?NHIrY0dqVnNMdDNIU2Nyb292ZHp0WHg2dlgzNHFEWVo4TnoxanJzRVNiMGQw?=
 =?utf-8?B?dkMvRXRreXREWXphNkZEdEVKWE1ydUQyMzRBQXFlRWZVdWFYVXhRMnRSYWR6?=
 =?utf-8?B?emYxUkllS0orRnNHbWk1YWxJaVBXdnFLMk5lc1Vldk9iRWQ1dlV6dCs0cTFv?=
 =?utf-8?B?eVhnT0JtT3dzL0VXMEpydENaMmZITzRUQkN5UXo4cU05UFZtblh6OHIzdXRT?=
 =?utf-8?B?UXl2Mkt1Yk9OR0xPbnBSR0dOOGdmL2xXSTFneDFDcEdQdHFvM2VZUVJUVWNZ?=
 =?utf-8?B?NmkyUWdRenQ5MkN2ek9HZlZ1QWQ0NWxDa00zelpUTktUa3p4aTNvaEZWQVJu?=
 =?utf-8?B?cHMzVnh6NHJDUjFmZjRxcWJKUWE1dE00QTA0THd2czdVU3ZHcmgzUlRxd0tH?=
 =?utf-8?B?a1J0ZENGa2VuWUg2WC9yeERJeDVtdldwKy9ydVE1RXBoZnBZelRkMGFiNC9N?=
 =?utf-8?B?YWtyTTR2ckVPWG1saEFrVlVkOW1oUlNXTFhMcUNGdURQWkljWFpzRCt1Y1JJ?=
 =?utf-8?B?ZzJacGI4d2NuVlNrR0k3NnNwOXU5UkhPNEQyd3RoR2s5QzR3Rm5JeURSVE11?=
 =?utf-8?B?V1J5Y2tEWHArVXNsaE0rVHdKOHdLTitIcFYrdm9CS1U2Z0RYdkRYZmJaY2Vr?=
 =?utf-8?B?OWRoNEdkY2N0cTVsV2d0dUFITW5PZWlkUUZUeklOblB5QUNmYXlENzk3TzBR?=
 =?utf-8?B?VytCVjFRWjJaMHB2OXlmdE95eGFsbHRXMTgvQU8zUmxZNzU0aGVLNnJKclR5?=
 =?utf-8?B?TGF1SXBVQThDMUYvZ1NJdytBQ1FqdmkvYm5pWTArWkJKTGdyUktLbk40aUlD?=
 =?utf-8?B?OGtaV21rdi91WWVnOUwrNnVuS21WTU50Sm5mWHRnRi94ZXc1THd3WUNsOCtI?=
 =?utf-8?B?QUtITGRzUm5rZ2JGOG1zYitQT3R6NEdoQ1ZQMDNxU2NpSytPQkxDT2tvNCt5?=
 =?utf-8?B?U1ZaOXAra3lZUWVYRjFmazFyT3N1dW8wUG5ZUFAzclIrTER4RUxsOHpkeWFG?=
 =?utf-8?B?ZFNUK2ZSRktXUGZZVlRjM1paTy9LcDJtU2ZDbjQyMmFsYS90UWJETUdoemQ3?=
 =?utf-8?B?UlBHUDNORS9XVnhrSWM5Yi9jdFRzaHB4elU3Zm9rcm9mcTRxSFFqdEhXY0ZK?=
 =?utf-8?B?RGR6MXdXSFBka3NwMC90cTZuaFhnRCtERjgrZHo5aHcwcE11bWUwTmhWL3NS?=
 =?utf-8?B?YXhGb1NEOFh4ejB2U0FzcjhIOU5aUzAzd2xJK09SSUtmcXUwVXdJYWdENDc1?=
 =?utf-8?B?enlPaUtPMUdsbjhzYzJFQ3NSdmxLb0F0SGk4RzhiZVdtUTlIUjNKTGc4UUFa?=
 =?utf-8?B?YThhYmpBTGdmRXJRRm1QWFZPR0ZlbWpkemdHTThDOEppa1g2YUtvR0ROMjJV?=
 =?utf-8?B?Y1VlYzNjM0FhVWd4bm45TEpCZVdJRUo3dnJ1aS90ckxFbjRBQVJiU0JvazRz?=
 =?utf-8?B?S3dQeCtSeGFOSU5TMlpFQ3lqbkk2TzV6TlQyUkNRS0o4WURtc2VTaElWcWh5?=
 =?utf-8?B?VDZJRnhyeDBQOS82WE9CY1ZPMHNDa3IzSGo5QnluY0s0NXhFenFUTDBtMTVR?=
 =?utf-8?B?TS9JL1g4TXdNak82YW13QzJqandscVJoTk1MR2VrR1phZkwySHdtcWd2Zys4?=
 =?utf-8?B?b04va2c1VmpER0E1RGd3Rm85ZndsRWxjL2orbTlvZXVOVHp0MU1nL09aMi9T?=
 =?utf-8?B?RzQzUU1HWk9tY1pQWFdTMUhVZm5UY2MzOFd4ZTJqSXNMam5kV1BjMmlEbVJh?=
 =?utf-8?B?eDlFK3FmSGJzenhJbzBCenZINjk1ejU5ZFBkL1VJUUNNTXFJRFZwY0xSaHQ5?=
 =?utf-8?B?SFVNbUlPWlVvdjMzWDNPVEFaUTg2bldOVkhJeTFIOFRDOGpxVkg0amFuenZh?=
 =?utf-8?B?Tnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f95a8b6-e89b-4eba-73fc-08daf8a4af96
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 16:05:43.2887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xuSZjmHA78v+1Wh6HHwj9+QuNkaHrWZEXyIcKcguxXP0NsdEXhe7RK8HFI/43Pm0W8gYUYOrkcYEvUf9pN3hCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6479
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 15, 2023 at 08:39:18PM +0100, Borislav Petkov wrote:
> On Mon, Jan 09, 2023 at 07:35:53AM -0800, Ashok Raj wrote:
> > @@ -334,7 +331,7 @@ void show_ucode_info_early(void)
> >  
> >  	if (delay_ucode_info) {
> >  		intel_cpu_collect_info(&uci);
> > -		print_ucode_info(&uci, current_mc_date);
> > +		print_ucode_info(uci.cpu_sig.rev. current_mc_date);
> 
> You must be kidding:

Oversight completely.. Apologize. I remember seeing them but unfortunately
I ended up fixing the issue in patch5 instead of patch4. 


> 
> arch/x86/kernel/cpu/microcode/intel.c: In function ‘show_ucode_info_early’:
> arch/x86/kernel/cpu/microcode/intel.c:332:49: error: request for member ‘current_mc_date’ in something not a structure or union
>   332 |                 print_ucode_info(uci.cpu_sig.rev. current_mc_date);
>       |                                                 ^
> arch/x86/kernel/cpu/microcode/intel.c:332:17: error: too few arguments to function ‘print_ucode_info’
>   332 |                 print_ucode_info(uci.cpu_sig.rev. current_mc_date);
>       |                 ^~~~~~~~~~~~~~~~
> arch/x86/kernel/cpu/microcode/intel.c:311:13: note: declared here
>   311 | static void print_ucode_info(unsigned int new_rev, unsigned int date)
>       |             ^~~~~~~~~~~~~~~~
> arch/x86/kernel/cpu/microcode/intel.c: In function ‘print_ucode’:
> arch/x86/kernel/cpu/microcode/intel.c:343:33: error: unused variable ‘mc’ [-Werror=unused-variable]
>   343 |         struct microcode_intel *mc;
>       |                                 ^~

I fixed in patch6 instead of this patch, my bad.

I updated my build to have CONFIG_WERROR, i had that accidently turned off
in one of my configs.

I have fixed up the right version and can repost if there are no additional
comments.

Cheers,
Ashok