Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5086592rwb; Tue, 17 Jan 2023 09:02:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXtDc0fLH50cjPrvdf8E2Cw0gbuPe9Bz/0VDKVWt/N1j40DKZNRGgplOjb5cDk49eWdbdLcJ X-Received: by 2002:a05:6a21:e28d:b0:9d:efbe:52c3 with SMTP id bz13-20020a056a21e28d00b0009defbe52c3mr3202234pzc.51.1673974959860; Tue, 17 Jan 2023 09:02:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673974959; cv=none; d=google.com; s=arc-20160816; b=DjjdmXw9IwjaO/vTmWztE6Y+xS6vPnAHHQof8cGSH1Hq8LaP21nJ6Ajs0a548goHW7 4LVxQYB75zYyDAXmn9lxcLo1j0tcHN+5Un/gJUX3WkEBZh2v76/ZSCiBybeFbjn4oxfl 4a1JoURT1bXlsa7WUtRyUqWqFoY3adyUM6PiIQ5PWB2Ta6ayeYVWDNR78HOImioR3sId yLMOjEuvW81NB3/Us0HluKR8ZuEIUd1Ko4eNwZ3rIpSVtAcFsPN+Trqu/+6P25c5NZNH hLJSLpJuJsf0/54KlbMg1AbUA+Ko9u0rLQ1QCNOLGQW+Y4v85AdJlob/468kDq/YSPE3 iEkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=lDZLfS99aJsfiRKTBz1INDBRLz0bw8O/ZCp5l85XZFA=; b=1HHP08sigqzCsbxE9T5dFshlDNN7Pwy5G8YRJa+aACD/tv+4cWo88mYMBnTEvSwKiV 2J9lCN/ZcnlNAxinIC1Vyv0NGwp7CszRJY4MEDF5qOEHRsY+j6jRnFYSGFwhMpRoqOHP dOVDNT5POfj/VtUTZXi2izW2M/HX0oCrAKft+i7MHGW37hSxTnA1j3tQ5Fz77RhwQBV6 bZPgdSfPta/GGe+XhwqJeqbAzI5Jfjs743ld6Nr46WvVpiaLkO/B2ZMpXy5cze95a+T+ PgOCraGY+gtPjCWs6cLJrZ7siAvZteKu/+lyJSsDWjVO9Hzg6cUqO62hdCzVVx2LLtZj Qg1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w191-20020a6382c8000000b004b62e532537si22144250pgd.27.2023.01.17.09.02.33; Tue, 17 Jan 2023 09:02:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbjAQPxJ (ORCPT + 48 others); Tue, 17 Jan 2023 10:53:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbjAQPw2 (ORCPT ); Tue, 17 Jan 2023 10:52:28 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A4D2C22A08; Tue, 17 Jan 2023 07:52:13 -0800 (PST) Date: Tue, 17 Jan 2023 16:52:10 +0100 From: Pablo Neira Ayuso To: Alok Tiwari Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, darren.kenny@oracle.com Subject: Re: [PATCH v2 6.1] netfilter: Null pointer dereference in nf_tables_updobj Message-ID: References: <20230117154548.3403346-1-alok.a.tiwari@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230117154548.3403346-1-alok.a.tiwari@oracle.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2023 at 07:45:49AM -0800, Alok Tiwari wrote: > static analyzer detect null pointer dereference case for 'type' > function __nft_obj_type_get() can return NULL value which require to handle > if type is NULL pointer return -ENOENT Applied, thanks. I have appended: This should not ever happen, because if an object is found, then that implies there is an object type, but let's add this as a failsafe check.