Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1afecb9c-b17c-d2a5-d887-b7dced939586@intel.com>
Date:   Tue, 17 Jan 2023 08:43:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.2
Subject: Re: [PATCH v6 01/11] mfd: intel-m10-bmc: Add missing includes to
 header
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-fpga@vger.kernel.org>, Xu Yilun <yilun.xu@intel.com>,
        Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, Lee Jones <lee@kernel.org>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>,
        Tianfei zhang <tianfei.zhang@intel.com>,
        Mark Brown <broonie@kernel.org>,
        Marco Pagani <marpagan@redhat.com>,
        <linux-kernel@vger.kernel.org>
References: <20230116100845.6153-1-ilpo.jarvinen@linux.intel.com>
 <20230116100845.6153-2-ilpo.jarvinen@linux.intel.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20230116100845.6153-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVg1WStObmZRSlJGZWZXWFl6ODlWbkFUbmRwVWF1ZTY5aDV5VXVGSUlMSEtL?=
 =?utf-8?B?L1FxSzJsbzFYWWM0STFJM2lYZ1JMenFmMGFiaUh5Sm1ROTMwdE9lbVBTcW1Z?=
 =?utf-8?B?ODRCTTFFTUFTNTNITklxQW1obU1rQnJONjA1cmo3ZGpVSk16Rno3V0o3TWVD?=
 =?utf-8?B?bGh1aG5nZjFMem5yTTl6WWZkNjlRamlBQTlEc2ZxRFZqWTRESWVHdzJidCtX?=
 =?utf-8?B?dkE1UjZ3dkdRSU5NcU9aZXVmclh5Nm9GQ2tLRGFaSlJKVGc3YWNWT29DR0U2?=
 =?utf-8?B?Ri9QbUVSc1FwYVdrQzY4dkhsTU9NQlBZOW5IVm5uWHBNck5WU1JxQk9QbjQz?=
 =?utf-8?B?dmdRNExIQmI2RDFpcWJYSGtwMGFGYlo3a3d3RDdxUFNhMkVxY2FMaVZtbmR3?=
 =?utf-8?B?YnUwSnRpbFRRVnNHOGYxc0Z1UEhOeGpDUkN6Um9Cb2RBMzNWU3FXeUJ0M2c5?=
 =?utf-8?B?cFN1WTZqamEwRVVEeStxSlBCODRjL0J0a01WSHZhNGtQZ01PRVdwS1cyaU1E?=
 =?utf-8?B?alU1ZzN3cEJ1bzRWdklWMDZMaE9xWmRZcDZGYXkyaVZGczFzR2lrc0tHaDkx?=
 =?utf-8?B?ZmtDV0U3L1Q1WGNFMWdaQXVrdTAvRW9KUVk3NXFCTVhHWjY1dWtiT0JHeEhq?=
 =?utf-8?B?dUp2eTNOcjZsTHRoRDNoVkw4WXBYd0FGa0dZRFNianY4ZlE4SjhnQXZYayt6?=
 =?utf-8?B?ZEZuS3dneGF4U09xL1BPdVd5eUF1SC9hajJqUG1ZUXJPaFVqSW1pZXRSOHM5?=
 =?utf-8?B?MlhsOXJLTEZWTi9CdjFxNHVFTlNwNHFMMnd3c3doQlFWNnlST0p5Yi9NSE90?=
 =?utf-8?B?V3hGNGtGMmwyZUtqdXNudGc2TE1YTTV3bHpvdkhMMFRhM3V4UEc3N3ZlZVpL?=
 =?utf-8?B?WHc5QmVhRXVlc1pYTnEvelBKTE9oMTNVMkljZEI1U1ZIbGZXYTYzS3VoZkxG?=
 =?utf-8?B?cnBVOElWVER1c29rWDZrTVNtc2RwUmR5WnFTd0JKb2xGK2EzU0hJODZtbXFO?=
 =?utf-8?B?Y0xnZHlBRFRHS3FzR0FiRnlUM3M2ajBpc2ovRmFYVU5RczhRbi91Ni9raUdy?=
 =?utf-8?B?blM3Z1dINHo2NjBLcjRzbitVQWJDWFNGTDJTYUYxbnlpUkplaDVyMnRIQ05m?=
 =?utf-8?B?TjFyaGhNb0NzbWQ3SHV0WGl3WmlJK2RuYWErN2poYU9MR25zeDV4djZ2NjVT?=
 =?utf-8?B?YkpWeW9HREF3UlpmaTZJb1NhNTRKSXJuVFd1Wklzb2FoRmt1a1ZUcGZXa3FJ?=
 =?utf-8?B?Ykx4R0RmWGVyWThQV3RGTHVUbkR4dHhpNDdlby9zbXZndWh3WGZmU2FzNS8r?=
 =?utf-8?B?dys4eTNXMkcvSU5ZclZPVVVlVnBFUy84UXllSDJRQVZxcHcydmhBcGI4YzZs?=
 =?utf-8?B?UzZ3K25ianhRb2Vzc0tCUHJBM2JIS0xiTVNHdHJRK1pEc0V4K3R1Rm94QUVa?=
 =?utf-8?B?VXAyZXNMQlVseE5tSHBoME9Fd1BESkJpQS9rbCtZSGhtUi9KZHllYnBSNUZv?=
 =?utf-8?B?Z1VvcDBZUHphM0psMDdEaHZiNXBNdm9JRlRaQ2ZOTkRNK1IyYlFhV1JVQkVx?=
 =?utf-8?B?L1NPclBsdkFkOFJiZUVGc3ZXQkxvNTg4N2pwOVc2dEhFRDljYVA4ZWM4QzJl?=
 =?utf-8?B?Wi9lMGpuMDVSU2hpUStnL2JuOUw1bU1mYWxMbmdGWlBaL1lzRWoxLzBjWktH?=
 =?utf-8?B?dkd5RStzdG5LOG95MGdJeGVXNnpSVVVKYzhHbzE2MmROcVJOREFUd3JlU3hX?=
 =?utf-8?B?TEowUnd1MkRSVkc4eGZQS1NDRlFoa0pEUWdoNlVqSWxBSnorbS9mQldjemQ4?=
 =?utf-8?B?ZVpLU214ZE4wSkFYS2RMQmNiclYrTDc2Mnd2NGkrdUg3ZlJhTDd1NWQzM0dX?=
 =?utf-8?B?V0ttMXJPY2RlQVhsRHd1REJCek95KzF6cEVWY3ZLbDRiWnEwT2NRMjdyaVBR?=
 =?utf-8?B?K1hGWHdXek8yZ0JlNTByWlo2NHFaRjRyWTNKZldCQW9wQm56ejNMRVNpaXVQ?=
 =?utf-8?B?cm9OT2NIYnIvU1lVNDlNc0o3LzBabmxianlHUlFjYTZ5K1VOZ0RmeWh5ZVVR?=
 =?utf-8?B?QWQ2c09nSmJEaVlnVFVVbExITmxvVXRNSjdBSFo0bnpUUHFvQS9kY1VMT3Zq?=
 =?utf-8?B?c2ZmSStPV1c4b0J6Q2ZQdVhWQ3JqcTJnRTJNTmRDWXlWNnJvSllNUmlWUytt?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3524cf2f-105c-4a47-df6c-08daf8a9eaf3
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 16:43:10.4015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pXU4C3uWEv6UC+NtXQxUjkw1Z4EsH0UonlrkrPxaNv15SC6F0EG35WPLhaKQIyS3ki5eKPH2Ej81t9vrxzmacxRU1GEB/wDVnw1kW4AOtp8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5550
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/16/23 02:08, Ilpo Järvinen wrote:
> linux/mfd/intel-m10-bmc.h is using:
> 	- pr_err(), thus include also linux/dev_printk.h
> 	- FIELD_GET(), this include also linux/bitfield.h
> 	- GENMASK(), thus include also linux/bits.h

Reviewed-by: Russ Weight <russell.h.weight@intel.com>

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  include/linux/mfd/intel-m10-bmc.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index f0044b14136e..0d4db5d9d5af 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -7,6 +7,9 @@
>  #ifndef __MFD_INTEL_M10_BMC_H
>  #define __MFD_INTEL_M10_BMC_H
>  
> +#include <linux/bitfield.h>
> +#include <linux/bits.h>
> +#include <linux/dev_printk.h>
>  #include <linux/regmap.h>
>  
>  #define M10BMC_LEGACY_BUILD_VER		0x300468