Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5152142rwb; Tue, 17 Jan 2023 09:48:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXuWBNXpp/IjPTbFXTgGuwas+K/SKOVxbBv9sMWhgMWUqMQ3UIIITvdiobxypA2ZAGlxw6pm X-Received: by 2002:a17:902:aa48:b0:194:892b:8654 with SMTP id c8-20020a170902aa4800b00194892b8654mr4325440plr.17.1673977718818; Tue, 17 Jan 2023 09:48:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673977718; cv=none; d=google.com; s=arc-20160816; b=XzcCyoSAVF6lx+Semq9SK67merpGQnv5+QL2tdR1gwt3pMDGqL9IhWSRrLbo9yNpux 1NJsqsZRofwjUbPYXss2sDgbUkYq9M1ZWe7LaEcy86qwKjIfz1caWALda3njZ9IPYKmT K/o8d3so1b/vipnRdUrPL4KqmPHuJo91uSzW5o+W8G+qTmaGcW1CnH1Qy4Zk/QcTIG7y Gu0Jx614bbFCPKFd4yT2GeMlKnGgFjF3DjZtspYp/zkHOQfFkp+9RsK7GF931j/uWjoV dL7K9UTW1eaUt/loJHIj8+YKJWIWFJgRQ3gTdRY4BL0tHI1ub1nOGfTjCoDaN6lKUWrA U7+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yNUDy6KyAQAbRWnSnSUxNJKiFT2fKondnpix9cjKDOY=; b=TWrhxDcEbtzmtvVMil0QWBYSuMuL4VwATskPY7KlcT/DXCA7nTVrL1oSA1gxiIz6Zi 3MfTQTGapifWVbarDiltFyV51rMuaC/+qeoQOccH6M5FAulzf2ZxS7NyYB/M9D1zCn78 kefny7QvdkO0ucwW7ca3itZDuryMifMIga9l9PCUNpmXbooSkVWOv4yuU3Uk1Fn5XLjz IG181MivFCESNRVnk78XzS+Ob4tSRtSaYXlURbTglT2bGn9U8FzNmGPctiotHXlpk88s It2d65eb1cBbSkiSQtsfTcnbhoPSeK3HUsIs0G1gCSrVi/r6z+C592hfVS2k4eg2D/Zs X1FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cJZHosGP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a170902ecc700b001930ab4c4fesi15126075plh.165.2023.01.17.09.48.33; Tue, 17 Jan 2023 09:48:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cJZHosGP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235359AbjAQRdm (ORCPT + 48 others); Tue, 17 Jan 2023 12:33:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235319AbjAQR2S (ORCPT ); Tue, 17 Jan 2023 12:28:18 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D1D49037 for ; Tue, 17 Jan 2023 09:27:02 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id u8so15704345ilq.13 for ; Tue, 17 Jan 2023 09:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yNUDy6KyAQAbRWnSnSUxNJKiFT2fKondnpix9cjKDOY=; b=cJZHosGPywZrxxX0ZyqnueVZV3CFoZWMJXBY4yIkikJ5l8RAywicsO+rC7HzgCbYMS YiGVtYUp1NwsmlRbeWTwmH9Mg1FtPjxhuewZl6aehZEhaItlxYM97xvvv1L1XTEEGcf8 GBJQ6gO6tPulme1tBA4Ab8cHC1SILZqFqcPzg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yNUDy6KyAQAbRWnSnSUxNJKiFT2fKondnpix9cjKDOY=; b=f/OG3i5AbsqTY9oouW3c7SxJaEFm+p+n/E72/10RGNXBrwnU/qPPOGe+ocS7LBPcGA 1QZeEBV2u6fY8xdZbI/dOw6iAjpifL4UT+hqztdPWDnzFGnjdUzG/aeRpXG/pFubzVZz zPlmP8qBjTcQfeda/d7c+WFqvk2IUBM5XzaHrJyAXjG5n88VyXxYpWrrzgBtx2J5p2Hl K0LbpEy8Q9k1znbkglhZaADQo6CQkSPSc5OxgecX1EIMEgrhQAz8PmcBe94d+aUOjlFD 61RU9K3EnJJ0J1lZNmnpPhG05B0Uc8ryGoWt4FNXeEeoM3qRIGeZiG/0/321GL7JpCcV htuw== X-Gm-Message-State: AFqh2krQ6IgLjIN57zY5kF+gSLlz+s41jLgMNxCPbQnGICH33ngF0ti4 mtMSfKo7UxNoxObitkyu+bSDeg== X-Received: by 2002:a05:6e02:1a45:b0:302:392c:5878 with SMTP id u5-20020a056e021a4500b00302392c5878mr4409722ilv.13.1673976422085; Tue, 17 Jan 2023 09:27:02 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id y9-20020a027309000000b0039e5cad0bebsm5703351jab.89.2023.01.17.09.27.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 09:27:01 -0800 (PST) Date: Tue, 17 Jan 2023 17:27:01 +0000 From: Matthias Kaehlcke To: Krzysztof Kozlowski Cc: Rajendra Nayak , Georgi Djakov , agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Douglas Anderson , Stephen Boyd Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280: Add cpu and llcc BWMON (=> interconnect issue) Message-ID: References: <20220902043511.17130-1-quic_rjendra@quicinc.com> <20220902043511.17130-5-quic_rjendra@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2023 at 04:13:40PM +0100, Krzysztof Kozlowski wrote: > On 13/01/2023 19:18, Matthias Kaehlcke wrote: > > Hi, > > > > On Fri, Sep 02, 2022 at 10:05:11AM +0530, Rajendra Nayak wrote: > >> Add cpu and llcc BWMON nodes and their corresponding > >> OPP tables for sc7280 SoC. > >> > >> Signed-off-by: Rajendra Nayak > >> Reviewed-by: Krzysztof Kozlowski > > > > I found that with a v6.1 kernel AOSS on sc7280 doesn't reach it's low > > power state during system. This can be observed on herobrine based > > boards on which the AP_SUSPEND signal should transition to 1 during > > system suspend. If it doesn't the Embedded Controller (EC) notices > > it and wakes the system up again. > > > > Bisection points to this patch, the issue only occurs when > > CONFIG_QCOM_ICC_BWMON is *not* set. One might think the patch shouldn't > > have any impact at all when the driver is not enabled, but it does. > > > > Debugging shows that the issue is interconnect related. A bare platform > > device is created for each bwmon devices, which results in the average > > and peak bandwidth of the interconnect link to be set 'initially' to > > INT_MAX. The driver is supposed to call icc_sync_state() during probe, > > This is for interconnect providers, not consumers. Ah, thanks for the clarification. Still, for the INT_MAX bandwidth setting remains in place unless the device is probed. > > which would set the initially bandwidths to 0 and determine the actually > > needed bandwidth. But since the driver isn't probed the initial > > bandwidths stay at INT_MAX. > > > > This isn't actually an issue with this patch, but how the interconnect > > framework deals with devices that are registered on the bus, but aren't > > probed (yet). Not sure how this would be best fixed. Georgi, do you have > > any ideas? > > Why the device is not probed (yet)? If it is registered, it will come > soon during boot up. Because CONFIG_QCOM_ICC_BWMON is not enabled for the board in question (see above). It could be enabled as a short term mitigtion, however we shouldn't require drivers to be enabled just because the DT has a corresponding node.