Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bce8c402-edbe-4ba2-9cde-1a9485255c02@amd.com>
Date:   Tue, 17 Jan 2023 11:26:07 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>, Borislav Petkov <bp@suse.de>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Brijesh Singh <brijesh.singh@amd.com>,
        linux-kernel@vger.kernel.org
References: <20230117171416.2715125-1-arnd@kernel.org>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230117171416.2715125-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDI4YmNld2ZSNjE2RlVzU0s2QnNXNndvc2VvZjNucDY0ZDZ5K0t1SEROVmRD?=
 =?utf-8?B?U3FzQm5kVjZaU2k5ZFFTWVdETnhsNzU4VGJRajdoRTE5bG9LOWlZcGxuaEVu?=
 =?utf-8?B?MTQ3RkQzU1RKN3dqd3Y5Z1cvOXlob0V2eSt6NEMveFdjUml1R3pNZU5yT251?=
 =?utf-8?B?ditYS2MzNG5MV3BPaUJqREpYOVNVWVJscnBrNmVvS3FlMmtHWWVaam4yNWNh?=
 =?utf-8?B?aU5CK0h1VXhxOWU2aWFrai8rL2srcGVDclUvRnFiL0Nyb01CRGZIaUlQK2lN?=
 =?utf-8?B?ZUREMXhpZ3hQV21CVThzOUNVUUo5N2kyWjJYaTk0RTFuME5zT1ZIWW0xUFp2?=
 =?utf-8?B?Sjd3U0FwZ1RWSDBqSlJwTEdKWWNzNmdTYUtyeHpvWGhnUlZEQ1diMmNycDZS?=
 =?utf-8?B?NHAxQldMUDN2cTRqWGl1MGxYSXhiNHovSzVHQi9tRnJ0aDJZSm1tenI5enhR?=
 =?utf-8?B?OTB3dHdJLzNkV0tmZnIvNTRibW4xejZvQkZxSmpma0FmS3NZYk9JSThRSzlD?=
 =?utf-8?B?MlBzcFQxclVNVm9KblZUQUQvRWdua2IvYURBYXBoYjJ1ei9GaytqVmxmUGRI?=
 =?utf-8?B?QmtRZ0Z5b2RNbjJ3MVBxMW5nV2FwOENmTEZSeVc5d3M5NE83QmJ5MGx1Q1VR?=
 =?utf-8?B?dHR3bXZWb2lIMFdERm1UQmtodFJCN1Yvay9YcTFvNDlXUmM2c0FycC9ua25x?=
 =?utf-8?B?b2VsL1NyMGZBQ1V4emVrQlFCYjUxR1ppVTJIYm5RTnpJVDlwYU10S2Jyd1BK?=
 =?utf-8?B?S1ZRWDlNMXhUd3hnSWpiUEFZbFJYanpSZnhFRW5QdDVxdGNpampYeXB3NGJm?=
 =?utf-8?B?MUtUNitCTFh2MUplU1lFSDc3N2NpWGhBTjEya3RwYUlhbmlpeVNKaEUydU5k?=
 =?utf-8?B?ZkRyWHlnSzNSNVNiYzE3a0k5eS9tK01EeXlseTRRcEJXVGZDaDZpSDgwY3U0?=
 =?utf-8?B?dFhYYWppU1hHRTNRLzdla05lUnVFeGdsR2plR1dnU01XYWxWZnZuMUsxK25U?=
 =?utf-8?B?SmVLMjZaUWpzb2QzYWJhZ0pZMk5hL1FYV0oyNm5abjRZNDVUZ0dHSk5YdlF3?=
 =?utf-8?B?eDlHa3hIV2xka2ZUU2J4NzlZZEZuS0FhR1RhTEJEbmp2b3dVeHczVm5EUVJ4?=
 =?utf-8?B?Q3dPd0N6Tzc5c2ZtSkIraXNFWGs2OVh0ZmZCanREWndRL1ZacnROOU5wdXoz?=
 =?utf-8?B?RWZVQWc2ZXVZRHozcFZ6T2E0ZE02RHJPWkNtUklTUW16S1pzUWRmb0p1dWR4?=
 =?utf-8?B?U2x4Q1FrQitjQlFYaXMwUHpPYnRiS2FZSlVnQ3VDTVpuWVllUnp3TUVFamVw?=
 =?utf-8?B?N0VVdS8vQnJodVpxU0tMZkREQjRXeE9QMWZGZEtzNE4wODliVGhzZStEZEpo?=
 =?utf-8?B?V29KaG0wb0JueE9GNDd5L3hBOEdvL3p4VEF6MG9ObFV4OGVUelBzQzFaZC8z?=
 =?utf-8?B?MFgrcW9tcDBhdzFBMVRINGVIRC8zQVc1MlRnN2JaSmZuWXdFTElYMVV3NHRZ?=
 =?utf-8?B?c2N4UCszMTRJKzExcENWK1VUZDR3blIzdDJEZzRiNlFQZi84aUhPOWZVdEFX?=
 =?utf-8?B?d3M2bkM4VDd3am5Ialh1NUhDRUpJMTRKVXlTNnVva2podjJISXBMNGZ2LzJ3?=
 =?utf-8?B?NHZ6RGNPbGg0N1ZJVTU3cmw2dnRQMlBWMW1McmpSMWt4WE9oK3IvL0JnWlBj?=
 =?utf-8?B?cUtpQ3hkTTRrSlBjMHlrTUhjUkl0OXluNkZUdE42bHFFRUVxVFROOTBsbWRW?=
 =?utf-8?B?YTh4MEw0NTdDNVNlMmYwUE9rLzBrNmdHNEEvWFRpZDBuL3VQNy9FOUFWaUxk?=
 =?utf-8?B?M25HajR4aW1lNG9aNzNqOGh5Z3UzdHJNQ3ZYM3dGRzdXYUhwNkFHOGV3WnRG?=
 =?utf-8?B?RlhnQjc0blZKbExQUFoyWk01RGRGcjdrUThMYWExTEx4Z1U3azNleHBhbVA1?=
 =?utf-8?B?WldDWnplVWozdWpiVXNwQ0VCT3BwMDlQTSt4OTE2K3pnSktEb3JpRkIyTk5y?=
 =?utf-8?B?VURaOVlrUDlhWlZnck5ndlhGSzdsNUNiQ3MwY3Q2aU96MjFiNW42enh6bFpW?=
 =?utf-8?B?VTdoSHoxZWF0ZVJ0bU1iZms3S0VJWFdlR0hJVytnNjQ1RVFtWS91dG1MOG1v?=
 =?utf-8?Q?AbicyHS87M3/zOvX9PEkonASH?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3a02f87-4cc2-498b-bd3c-08daf8afec02
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 17:26:09.1257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DsWPKKoTXeWQT02mVVhpn4NIL2L/3UCDfMMvG+hHX+BB+Oh8RS168K8dgRnJORI0JfexjyQs2nImBBFtunQIig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5079
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/17/23 11:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver fails to link when CRYPTO is disabled, or in a loadable module:
> 
> WARNING: unmet direct dependencies detected for CRYPTO_GCM
> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>    Depends on [m]: CRYPTO [=m]
>    Selected by [y]:
>    - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
> 
> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
> 
> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files to sev-guest")

This has been present from when the driver was first added, so I think the 
correct Fixes: tag should be:

Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")

Correct?

Thanks,
Tom

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/virt/coco/sev-guest/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/virt/coco/sev-guest/Kconfig b/drivers/virt/coco/sev-guest/Kconfig
> index f9db0799ae67..da2d7ca531f0 100644
> --- a/drivers/virt/coco/sev-guest/Kconfig
> +++ b/drivers/virt/coco/sev-guest/Kconfig
> @@ -2,6 +2,7 @@ config SEV_GUEST
>   	tristate "AMD SEV Guest driver"
>   	default m
>   	depends on AMD_MEM_ENCRYPT
> +	select CRYPTO
>   	select CRYPTO_AEAD2
>   	select CRYPTO_GCM
>   	help