Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mattijs Korpershoek <mkorpershoek@baylibre.com>
To:     Walt Holman <walt@holmansrus.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-input@vger.kernel.org
Subject: Re: PATCH: Add devce IDs for Logitech G923 Xbox Steering Wheel
In-Reply-To: <743753078.40.1672170394290.JavaMail.zimbra@holmansrus.com>
References: <743753078.40.1672170394290.JavaMail.zimbra@holmansrus.com>
Date:   Tue, 17 Jan 2023 17:29:29 +0100
Message-ID: <87v8l5ktue.fsf@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hello Walt,

Thank you for your patch.

On Tue, Dec 27, 2022 at 13:46, Walt Holman <walt@holmansrus.com> wrote:

> Hello,
>
> This patch adds support for the Logitech G923 Xbox edition steering wheel. This uses the hid-logitech-hidpp kernel module and from my testing, force feedback and all buttons work. This requires the usb_modeswitch application to setup the device in PC mode with a magic string that is the same as the Logitech 920 wheel. Originally I had massaged a patch I found for this wheel, however, much of it was unnecessary and I culled it back to just adding the ID's. Let me know if you need anything else or have any questions. Thanks,

It looks like this patch has been sent as an attachment, not inline. The
subject also looks invalid.

It should be in the lines of:
[PATCH] HID: quirks: Add quirk for Logitech G923 Xbox steering wheel

To make sure your patch gets picked up by a maintainer, can you please
resend it as a plain-text email, following the standard kernel
procedure?

Here are some links to help you preparing your submission:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text

If you are new to kernel development, the b4 tool could also help you
preparing your change and finding the right receivers:
https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1

Hope that helps,
Mattijs

>
> Signed-off-by: Walt Holman walt@holmansrus.com
> diff -u2 -r linux-source/drivers/hid/hid-ids.h linux-target/drivers/hid/hid-ids.h
> --- linux-source/drivers/hid/hid-ids.h	2022-12-21 10:48:12.000000000 -0600
> +++ linux-target/drivers/hid/hid-ids.h	2022-12-22 12:50:16.403880137 -0600
> @@ -820,4 +820,5 @@
>  #define USB_DEVICE_ID_LOGITECH_G29_WHEEL	0xc24f
>  #define USB_DEVICE_ID_LOGITECH_G920_WHEEL	0xc262
> +#define USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL	0xc26e
>  #define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D	0xc283
>  #define USB_DEVICE_ID_LOGITECH_FORCE3D_PRO	0xc286
> diff -u2 -r linux-source/drivers/hid/hid-logitech-hidpp.c linux-target/drivers/hid/hid-logitech-hidpp.c
> --- linux-source/drivers/hid/hid-logitech-hidpp.c	2022-12-21 10:48:12.000000000 -0600
> +++ linux-target/drivers/hid/hid-logitech-hidpp.c	2022-12-22 12:53:36.335755199 -0600
> @@ -4341,4 +4341,7 @@
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL),
>  		.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS},
> +	{ /* Logitech G923 Wheel (Xbox version) over USB */
> +	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G923_XBOX_WHEEL),
> +		.driver_data = HIDPP_QUIRK_CLASS_G920 | HIDPP_QUIRK_FORCE_OUTPUT_REPORTS },
>  	{ /* Logitech G Pro Gaming Mouse over USB */
>  	  HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },