Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5190611rwb; Tue, 17 Jan 2023 10:15:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXt0yAAlrN60QR/G2pkeyZj9FgjRnjKCGdDty0PA8GJ/RnZ4sDMYItnbTqbL7J0dI+qkQag9 X-Received: by 2002:a17:902:9b97:b0:193:12fd:a2e3 with SMTP id y23-20020a1709029b9700b0019312fda2e3mr4162253plp.55.1673979352009; Tue, 17 Jan 2023 10:15:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673979351; cv=none; d=google.com; s=arc-20160816; b=RtIRDtXFMCXfLf+t+G0pHPPTjSBovMr0aLj5UHTpjv5WAYk/bo6SEenwG587nx7At4 wimo6xGT5KiVv23SD9zSUzrCbHPgouE1oAFuRcmN40RQ6FKGrhRvsBUVqxHD2Eq9YVnn fwa+TiBTgc0Eoc+8VujeD+06A8P+w6hoWPu5fWureefYgyHFUFaF81YVWz/1VR+6KVD3 jXA54ltr3cgsxE6nl1tCyXVhUarMw0t4YVfntokL40MmfTwTkSlXjcaIoB/xAzfcItWm 0O1DNXIW891tiOiZaWOAK2v+/mDpLOq1TzAm96ocb1faF2+F9DVVuhU9POIrGjFqmjKE WZEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=9hvp+iR4BlWOarWYBjNCLj7ICflmxWG7PewjY8QZuX0=; b=atONubMRXrl28CyOgYa7COJrJzUW6OtU024q4ShJSu/ABYgpEi7boGkHjh1I6GUZuk 0x1NS3erRZx+KzqY1bPfJpkxkBHBqwYRpMSbvp/sM9urzT8slnGKMNmoJsTHNchwrti8 UcdOocuck5Gj0h7RfY/0YPzmzuEOipeItArogl5MCb/JibfGMdymt+6pHiG5gnYnwURN raakNYB9xgMdED2WBHeVnwVJady4ik7EXBqQLqBbKkpberhWL08uB2AzRhzY0Pj0Z0ze nz8zDvK0StAzIcVctAi3q1kLDKUE5znoTYLTXsfkxJYlyz9Jnpl2PyaIZOg7fxbGgfyg kxMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a170902c94a00b00194a1f665b5si4668204pla.570.2023.01.17.10.15.43; Tue, 17 Jan 2023 10:15:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbjAQRzt (ORCPT + 47 others); Tue, 17 Jan 2023 12:55:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231491AbjAQRxp (ORCPT ); Tue, 17 Jan 2023 12:53:45 -0500 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F332E4F84A; Tue, 17 Jan 2023 09:43:05 -0800 (PST) Received: by mail-pl1-f170.google.com with SMTP id jl4so34289954plb.8; Tue, 17 Jan 2023 09:43:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9hvp+iR4BlWOarWYBjNCLj7ICflmxWG7PewjY8QZuX0=; b=C8+HScL57hPXOMd1x72j7q1ilokNgE4rCF+GhCAzjd+DT07BD9tytiR55JieU4fg1J GRR8MGV9QD1yMq28M+/xN/LTfcDPdpj7YJYbnbCoypgcLQPWiKxYSb53hx+pngk510hZ 6MK1zin++VwabgPAS60F/U8ysXAFJLglx5TRCSrRWjeR6MXalXALv3CS6nYQ5fZBDKiE TO7row9EgVSA8L0Ia/eYd+neR7nGoYG9cgIruQnFwcr4TRUBNPryLcEt9WyNMZNKKtap 2LFyRBxpDNFox0vi3d0Y+uwDatyvUxkp+uqI7FHf02khuCRbSwl6tKOo2sTlWRRrerQt y8mg== X-Gm-Message-State: AFqh2koMjjUJ7aLWv/6PXqq28HkhZt/WWlMcKfPtX7Vfa6aWYztdQ5TA Ja8b7TH5xeMoovtc7ZkrfrA= X-Received: by 2002:a17:902:c948:b0:186:def0:66f2 with SMTP id i8-20020a170902c94800b00186def066f2mr6198001pla.11.1673977385329; Tue, 17 Jan 2023 09:43:05 -0800 (PST) Received: from ?IPV6:2620:15c:211:201:f632:d9f5:6cbb:17d0? ([2620:15c:211:201:f632:d9f5:6cbb:17d0]) by smtp.gmail.com with ESMTPSA id s9-20020a170902ea0900b0017f57787a4asm21469407plg.229.2023.01.17.09.43.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 09:43:04 -0800 (PST) Message-ID: <15f1424c-d979-6330-843c-d5ea84a8bfac@acm.org> Date: Tue, 17 Jan 2023 09:43:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] scsi: stex: fix MU_MAX_DELAY typecheck Content-Language: en-US To: Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230117163834.1053763-1-arnd@kernel.org> From: Bart Van Assche In-Reply-To: <20230117163834.1053763-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/23 08:38, Arnd Bergmann wrote: > @@ -173,7 +173,7 @@ enum { > ST_ADDITIONAL_MEM_MIN = 0x80000, > PMIC_SHUTDOWN = 0x0D, > PMIC_REUMSE = 0x10, > - ST_IGNORED = -1, > + ST_IGNORED = -1u, > ST_NOTHANDLED = 7, > ST_S3 = 3, > ST_S4 = 4, From drivers/scsi/stex.c: int st_sleep_mic; ... st_sleep_mic == ST_IGNORED ... Can changing ST_IGNORED from signed to unsigned break the stex driver? Thanks, Bart.