Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f32a336d-57bb-7b0a-6adf-be731cdfb684@amd.com>
Date:   Tue, 17 Jan 2023 11:27:43 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] virt: sevguest: add CONFIG_CRYPTO dependency
Content-Language: en-US
From:   Tom Lendacky <thomas.lendacky@amd.com>
To:     Arnd Bergmann <arnd@kernel.org>, Borislav Petkov <bp@alien8.de>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Brijesh Singh <brijesh.singh@amd.com>,
        linux-kernel@vger.kernel.org
References: <20230117171416.2715125-1-arnd@kernel.org>
 <bce8c402-edbe-4ba2-9cde-1a9485255c02@amd.com>
In-Reply-To: <bce8c402-edbe-4ba2-9cde-1a9485255c02@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGh5WDdYamNESE1GTWJhMUtCNzE2OEswQ29ySSs1UXhjNW9uYjkyRDA1Q1lK?=
 =?utf-8?B?Mzl5TGNKeXJNNXdCTi9aUys4QVovV2kyZGk3Nm5acFZkTkNQUnRtb244YkVu?=
 =?utf-8?B?SFJacFJQSzEyS0xyLytHQXBzc0JPcHpiL1VvSmtSQi9ad0lJNkZNZHhYTk4v?=
 =?utf-8?B?Zys2bVpwWUVqd0xIT2xuVnJReTFBNlQ3MDlPUk1kTHdzdldqODhwOTVLaTUx?=
 =?utf-8?B?elY2VTh6T2g5R3VxUkYySzhqUEUvRmtjYi9ZNzAwM1hEcGg0bW42M2lqWk5s?=
 =?utf-8?B?eDFZMHM5RXQzQzJ5QXdrc28rQitpZ2tqTWRFS3hQTmt0c2VHWU1IcWxDYTFy?=
 =?utf-8?B?d3RTNUtyaVJ4MGNBYmxmQXlKM0xiMmNpUElTWU92YTRsTU1SR3ZPTjZEU1Zw?=
 =?utf-8?B?SEE4L0VvbXp1NHdPM0RPRTVxckZWR3F5Z3A0RGJHL3liOWtQZk1qSFZrL1hN?=
 =?utf-8?B?YXZOdXZWOVVqM1dialJzcTVpU2J2ZGE5cHR2eU1xS2pZcWtUQlQ0Q1FrRDJs?=
 =?utf-8?B?UFhPbVFzQmF1ZWNuTEFQQTdjRTF5bXptWkREd3hjTGJtMGkzWC9ENjY3MnZW?=
 =?utf-8?B?VXNKUEtoVnlHQ3FraGp6ZXkwK1FkeHFMbzBkZU9MOHFaajNCbzZFWFI2YXNu?=
 =?utf-8?B?MDR3blBNTTZTbVlkVjVOUVVjNklsVURUVWhQOTNmR1owcElPVFM4THZzcjlV?=
 =?utf-8?B?THg0TlRqb0tMTzN4ampGTEZzaVUwWk55TU9paE00M1NDL3ZyemVrTzRmSUdF?=
 =?utf-8?B?Z1NsOUpOUFByb0U0ek82RlVLVE1KQzFvN2NMb2c0bDFCOWhPbXlFN2xXSDJ1?=
 =?utf-8?B?VTFyNTlsbW5wbWVtUG1CUDlHdW4zQWx3VHVNN1hsSi9teXpSVDlvaFZIaUNk?=
 =?utf-8?B?QUVZK0V0MGVpMTFLc2FsV282SnoxYmorZ3ZTS3RLOUZ0enhJcDdCZUZEaWdI?=
 =?utf-8?B?NUpTSUNxODRtU0ZoNTI3MlM5dHhoMXRja3BTa2RCZDkvNHdKa09RbUY2Q2xL?=
 =?utf-8?B?eTBnMFdZSGd0NFN1eXVndkg4Wm1sN3gwcDR6SnkrQ2Uwc3VDZVhTUGMyMnAz?=
 =?utf-8?B?WE1ZMFZhdHV4a1ovRkt1K2d4OEZnNW42U0U4YWhBcHdtOUtyNGl0UTV5RVA0?=
 =?utf-8?B?a1RyblIxNEsvazI5ZW55VDhKa0J5QldtV2RJRkd1ZnBrN0dEN3UzbENQSmVj?=
 =?utf-8?B?dnRRU0ozZWgwMjRsRlVBN3Y5cTZDTHBJRFJ6eFQ1aHlmUUFwMnlrZVIyZWFJ?=
 =?utf-8?B?OXF1dndGQlNhL2ppVEttU1BZYWNaUy9aVERQd3p0YUtlMUU4czZKQTZjNGdU?=
 =?utf-8?B?RC96bTZZTzJOcGViK2pKb2JKd2IwSEFTSVdWSk95OC9rN1ZhNFRwdzlvR2VY?=
 =?utf-8?B?UGJVNnZHcHBuZEdKdW40N1Y3aWZGR082M2dSSkVrRkxlcVd2NkpHekF0SFA2?=
 =?utf-8?B?a2puNTF5RElTUFVnNTZSYjdUcTFqVEc3MHh4dW5XcURIem95ckdQTFk5V1Zl?=
 =?utf-8?B?QUo5M2ZJQitHN2NLSHJyL3RDemRZbUhHajlZZzJTSU1WMExuZUIzdWI5MWNx?=
 =?utf-8?B?VDFKajQ4RmR2d0VtQi9vcGlYdGxBYVhDUnNOUDk5ekkyY0RnVEo5cjRVcjQv?=
 =?utf-8?B?WS9yMURDeVMzV2hGTkh6ZkhGVStuNjhRNkFxV0hlMDJCeVJLME5sOGI1R0J0?=
 =?utf-8?B?NG9va0dQbWErNDdlZ2RjNDBESXpINzNSQ1ZUbXdVTnkvUEN2NHB4WTRoKzIy?=
 =?utf-8?B?bWt0cVRGSE9IcEdnaE5PcklCeWF3N0FZZUtaTS9pZkp2TDJuUEJ6QTVOQzRI?=
 =?utf-8?B?NWtCaGNRakZqaGhIUFhUZW9IM0NRM01TcGpteGhYM0k1SlpmN3hGcnh0M28r?=
 =?utf-8?B?bTJYN3JJOXI4TmZnNG8ydDV6OTR4cXM2cVJmUmNLVm9TRVVMR05BWjcrMW04?=
 =?utf-8?B?bkFtVm1xZEtVeDUxUjVqQVJYczZMM3NYVTNHSnk5aTlUQTlkQUsxTy9IZTBV?=
 =?utf-8?B?NVdCREhaSFdXZWFSN25oZ0UzWjRCNjA4dVFFaHNmOGZJVURDZDBIeUJ0Zk92?=
 =?utf-8?B?bFlCYm9KMkw0cXc0Y2s2V0w4Vnh1ZGtaZWxQc1hkTllCUzR4WEFJZ09ZeG5S?=
 =?utf-8?Q?mpJb7sqpQDFhKem97CyF7Wu/E?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d6e4130-b1af-482e-4c84-08daf8b0253b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 17:27:45.3140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rooWO02pJC4tMSo68INSR1TCV6vSxP/AbbiYFUwbJd+YizcslpIjvIMopr/UhOE5amSXV18aKTdb3Ykn4o7tsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5165
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Updating email for Boris.

On 1/17/23 11:26, Tom Lendacky wrote:
> On 1/17/23 11:13, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This driver fails to link when CRYPTO is disabled, or in a loadable module:
>>
>> WARNING: unmet direct dependencies detected for CRYPTO_GCM
>> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>>    Depends on [m]: CRYPTO [=m]
>>    Selected by [y]:
>>    - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
>>
>> x86_64-linux-ld: crypto/aead.o: in function `crypto_register_aeads':
>>
>> Fixes: d63670d23e60 ("virt: sevguest: Rename the sevguest dir and files 
>> to sev-guest")
> 
> This has been present from when the driver was first added, so I think the 
> correct Fixes: tag should be:
> 
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> 
> Correct?
> 
> Thanks,
> Tom
> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>   drivers/virt/coco/sev-guest/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/virt/coco/sev-guest/Kconfig 
>> b/drivers/virt/coco/sev-guest/Kconfig
>> index f9db0799ae67..da2d7ca531f0 100644
>> --- a/drivers/virt/coco/sev-guest/Kconfig
>> +++ b/drivers/virt/coco/sev-guest/Kconfig
>> @@ -2,6 +2,7 @@ config SEV_GUEST
>>       tristate "AMD SEV Guest driver"
>>       default m
>>       depends on AMD_MEM_ENCRYPT
>> +    select CRYPTO
>>       select CRYPTO_AEAD2
>>       select CRYPTO_GCM
>>       help