Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Arnd Bergmann <arnd@kernel.org>
CC:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Martin Petersen <martin.petersen@oracle.com>,
        Quinn Tran <qutran@marvell.com>, Arnd Bergmann <arnd@arndb.de>,
        Saurav Kashyap <skashyap@marvell.com>,
        Tom Rix <trix@redhat.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] qla2xxx: fix printk format string
Thread-Topic: [PATCH] qla2xxx: fix printk format string
Thread-Index: AQHZKpU7MWku308BHUeEgF0sCyDipK6i56IA
Date:   Tue, 17 Jan 2023 18:06:31 +0000
Message-ID: <EC5BB501-0EEC-4F33-AEB9-69765E50A171@oracle.com>
References: <20230117170029.2387516-1-arnd@kernel.org>
In-Reply-To: <20230117170029.2387516-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hk27rTOOZtYsLVJdrgBjDE60z+lFiK0WqJ6I9pH5ZxY8k4Oz2ij1ReQ1dCc6?=
 =?us-ascii?Q?ohwlXNTLKvZArRSi6nZET2mRP22JMkdrAkMclBPqpmMzH15+cT2bXReOGsxe?=
 =?us-ascii?Q?izvts+/VaINdaKM/A8jIUovvbNcT56TPjCwY34VAsR0eGtYetrCGgpjaMgNT?=
 =?us-ascii?Q?00lSv5Tu2DrAmv4+dSNG1Y8jNLofxRF4v9tCITGaiujSjQ2x8x8w1bP1Jy+d?=
 =?us-ascii?Q?cOrjVwzh2HM9WG0cib/MQM6ya9WCVZvQYE5hPIu3hNNFlnIDy/jpI/23AdUe?=
 =?us-ascii?Q?GNzNmj4PW7m+a//svHFhpK4XEHqwAqGatb1xqitFAY7YTFaw9jCZa4fdFgSr?=
 =?us-ascii?Q?OwkDWpVpPyhvPDc7bStl5Mg2kTy74Zo5hGCt1MzjvCDnAG2hKXR+2BExfbea?=
 =?us-ascii?Q?kFhD2LjFCT2OxaFK5VN5aKuQRpdr+HTC2ovkyD9QzQkZlex5nZCjEe4trCQ3?=
 =?us-ascii?Q?iKLRsCaweHKDG7DjzeLQaxvpCtnmg9ZDiWFe8vMcdXctUDopxQ/sLcea08yz?=
 =?us-ascii?Q?a17Kp0DMNmutArsan2Ck6F6tvDr5B++QGOEbeh6b06Er3CPJ2S9UeAksi0kU?=
 =?us-ascii?Q?9cxFes3lDaDQtxeinDa3iviwmcYGZy17L6zGbSKRGS8vPZji/RwIEz8kRTKj?=
 =?us-ascii?Q?I1x893sborrMp3bgZ2DMTSx8k5tthHkFQG0Z5XpwwQ6SM7OTibtVnzZFmtL1?=
 =?us-ascii?Q?AA+Ex6Gh3aZaTCLCFLVvsBXgrRal4JelnnTkVIxiwh6vBkeiqDVTN97lO36c?=
 =?us-ascii?Q?c0bXDF+cqDk2Q0pY/EpJyMu1ARphaRMILd06boGFzsdXfagiEWN0sll7U/R3?=
 =?us-ascii?Q?Usbg4HCoieBTXtc7mblpOqP5ihbgN/Yu3X1rOMAkYSlBxU8DTz0LDUq3qn0l?=
 =?us-ascii?Q?L20x9tIPg8NxpXjkALcsine66Qdhh9SCDXa+sc57uhtsEGvJYj6Q0JKWSxs0?=
 =?us-ascii?Q?Xpq8cVvnt7fuUO0HMqy3XUUg4Zv1jKlRp4W8HvSX7iRBxo7J5JpQJF0wjXf4?=
 =?us-ascii?Q?KsMA8hDrQUIbFvAXJXggBsHE5QWiRjaVA+ezT7+JR4md6nKFOrafoOFOwayg?=
 =?us-ascii?Q?bGewt0D02JHv/bVknW1fAkJDDfTZN8aJ2O0BPBtjHSIqyQT0jbnOtrN+Zc22?=
 =?us-ascii?Q?x+dmzS+doVR3cfXjDRUMnds5ouSoGXpuNx2IMVxTwEEMA+43Ul/ET0kVUMGn?=
 =?us-ascii?Q?vKXVl3XEPtI7nO+opRg28uq6OAbdH2IYZktJrqbFHs8RQnnYNC77McegCO5O?=
 =?us-ascii?Q?MKLyrEwCdrYs0GWh4gUNj+/ilkEztL7RSvaoOkvIr16AhQbNtFRGGeUpi0SR?=
 =?us-ascii?Q?tMrDwBoHNZVtjskuveMIxcvLLIfUbOK3kcoVdtXUZOmGv4N06y4NWXdrpKto?=
 =?us-ascii?Q?lVA9Dl4ZqAOyhM9AADs9qkfQXUpy/HsGrKOmry7j8XhQKLUfftPWRniEWkZ6?=
 =?us-ascii?Q?Hkh5BXyQxQO+Xf543E08tiwENSXNUT2Gc+xR38Nsf+wN4D/Wv9u+bfyJSakV?=
 =?us-ascii?Q?VfRp0yTSG7EnAZOBsm0Ek659hpPAty6itSqO7JTDVVjHv7//Pw5eMMy/hbaL?=
 =?us-ascii?Q?atO1YcpfWUoZ9ZfqgrG7/Eotbka730tB0Em7RRGQoUF5e30EzO9y0m7ZOuKH?=
 =?us-ascii?Q?PxGi/IOWq81hZcR1zBUEklmSgkY+jFf7xStCN/T/0Yvi?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4ADCAC91268E21498D0329911A6EC3C3@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ew0zHqLN+U9JicUuXmQ6/cH8VOdLPyRhH7r1HI66zdnjnRUqbqNB+Cj6ntnMOEyvaj5LHw03LK2jts/XZsTsw+yY6LPL8WArPi7uq3wr+bvajWVbIvebqDTx2O6x3kNsmTKqzslua0kD4hmQxUug+t0DRRepSCuUa5FUwXAX80NrFpQevm0iUisbq2MrysBKnk8HT472wOJ6fu/C960zWf872jNl6R2Pi8xWGI7V143MPCUyCdFNvg6AhDba6U6iyJnFPCAR8DvDtqsY95O9hSAwcoXxGdLNC+COHjdWyKtnaaB08cMPDlaQALc8SjIShcgLlRtl2nfdYSoZvHkbRHMdnujdGaG/HaUP9dyK02hQCOAPBBPtmksPQhRCrVOCIF6E3JWk61IaqhbXS5mm0KJ3wT64mucvf9wypOnk8X1Eyl143lPTc/EPXj8rwRf1ciNkMqjO4D10yaxCR7Wiz2b84/faaGA9SMm4RAbjD13Nvh/D73GI1a0IJKHEi98bg8sIvhPoYdZj6+o6HcVBhCqLweuTIwv0cvqZxSgdU2B5jD2sqPz0KId3H/geAv8JBQLDr0nl7/4YhAIPHBKiFFqU8TGF3Me/+2zT4TXB7/FLNkFKXcobDSeaZd5zZ2t3byL52H2xhfeniE2P1d8fE6PVPEiOXlZRuwqjeU1cJ9mFQzt+mMnV6I+GqrIfgWlJz7Fh858UbqyxlUZT+NIE5+8tp8Yp27ODgIfCOM3t/cMRjXZ1p8UuXoDFunB3iwAPlZwv68Fl2e5++8ZPItLCwmT1ZCxPPfSP4a3S7W2PcYzIXgS5MY11BW1xTmeazHi8L1XmxZVJSW52lyF+X1VkAPYOBLQNmzsx+39y6s3BzfMU0C2dUwm2D65MTBWi8rlhVlb7aTiO+8IvcDYKtW8upB3IWhISGtjqGrFVyWYHDg0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2943.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcfcf76-d213-469c-a95c-08daf8b58fe2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 18:06:31.2799
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LMWpdwnNT+Y+2Cf/EEDn4dfho9QpPHia/jWZhu69wBAk2JG+N3sw5A7HRBGwDdowtJASmwGj9EaWfFcC03eViv4pilhTPXfQCXD2ol+3d6Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4863
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-17_09,2023-01-17_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 malwarescore=0 suspectscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301170144
X-Proofpoint-GUID: bMJqtGs7ougC4hfBqqW5oDy8A8Jte3S1
X-Proofpoint-ORIG-GUID: bMJqtGs7ougC4hfBqqW5oDy8A8Jte3S1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 17, 2023, at 9:00 AM, Arnd Bergmann <arnd@kernel.org> wrote:
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> Printing a size_t value that is the result of the sizeof() operator requi=
res
> using the %z format string modifier to avoid a warning on 32-bit architec=
tures:
>=20
> drivers/scsi/qla2xxx/qla_mid.c: In function 'qla_create_buf_pool':
> drivers/scsi/qla2xxx/qla_mid.c:1094:51: error: format '%ld' expects argum=
ent of type 'long int', but argument 5 has type 'unsigned int' [-Werror=3Df=
ormat=3D]
> 1094 |                     "Failed to allocate buf_map(%ld).\n", sz * siz=
eof(unsigned long));
>      |                                                 ~~^       ~~~~~~~~=
~~~~~~~~~~~~~~~~~~
>      |                                                   |          |
>      |                                                   long int   unsig=
ned int
>      |                                                 %d
>=20
> Fixes: 82d8dfd2a238 ("scsi: qla2xxx: edif: Fix performance dip due to loc=
k contention")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/scsi/qla2xxx/qla_mid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mi=
d.c
> index c6ca39b8e23d..1483f6258f92 100644
> --- a/drivers/scsi/qla2xxx/qla_mid.c
> +++ b/drivers/scsi/qla2xxx/qla_mid.c
> @@ -1091,7 +1091,7 @@ int qla_create_buf_pool(struct scsi_qla_host *vha, =
struct qla_qpair *qp)
> qp->buf_pool.buf_map   =3D kcalloc(sz, sizeof(long), GFP_KERNEL);
> if (!qp->buf_pool.buf_map) {
> ql_log(ql_log_warn, vha, 0x0186,
> -    "Failed to allocate buf_map(%ld).\n", sz * sizeof(unsigned long));
> +    "Failed to allocate buf_map(%zd).\n", sz * sizeof(unsigned long));
> return -ENOMEM;
> }
> sz =3D qp->req->length * sizeof(void *);
> --=20
> 2.39.0
>=20

Reviewed-by: Himanshu Madhani <himansnhu.madhani@oracle.com <mailto:himansn=
hu.madhani@oracle.com>>

--=20
Himanshu Madhani Oracle Linux Engineering