Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5301978rwb; Tue, 17 Jan 2023 11:47:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXsti/aIF+sopM4s9erbfUi/KwQXn9byF/QhcAUmLGA5F6bsDN0pJA8+1fGqfBwrVS51LD+h X-Received: by 2002:a17:902:7c15:b0:191:3ec0:9166 with SMTP id x21-20020a1709027c1500b001913ec09166mr4349129pll.6.1673984861683; Tue, 17 Jan 2023 11:47:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673984861; cv=none; d=google.com; s=arc-20160816; b=uyA/ozET1jlmz+1E3BaNiUt4a8iTVarBnShyJXvptY08y+eO57TFuy7JRhTOmjCnKL ueAoUE7mCmNFAbGPN7UwUz2DL2342Hq+nUo++oG+R101WjWMl0VfQUBE4wZmH4OgyzVw fD6/8VWrxRnAGT/1xn8t+Urmefjueq8wNtszp9FMK5wa8BYtq0GsDIUgHeetT/5K98Jn iwdr58wbrDC1zYDDJYj84bZ7I/85YfKAn6NwYsNdaBEkKZtuRDBCLNpkJInlWbVGdxP3 BpnQWPtbRFzm8sKymZ9GPBgi+K2Iomebr1+TEo2WaE5NMtKrRpa3Aj56xCLhukgxtj0o jo4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xgbmfvxMGlgSxrI8d/91HTw07fjF4X15th+juEvgQN4=; b=YVNPL981tMYXqtsFQ9Ag14RZXOYlj8cUYx0GVI95rqQYqslgVSUHu2bQ7RCozrl2V6 ++aTlkILHNfE/kSPh4NANquUtlY+VoVbS0na+tRUrw7xn2K58Gbjbfk6nmQwTaZuqjBj tCC3xqrKSsdxDa43eoJ3ZKca+uIO2gaGrPFxbiMAjSHlDHk63Y1EiGl1nfkiTS97pKs0 awKM2pQXZPfdSW+O8+3dNWo772Mr8IWSinaKSgxggnd4300CwUaq+xoRr8i5DT1SxbAn EIedbZ1PZuz+iDM7ieDxJZHLqEXPny+BJBuGdbiXDZ10YSlIOsi3Qm8qz7u04Zy+tDbI 0gbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EXPgEMC7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a17090302cc00b0018965944b98si34141133plk.24.2023.01.17.11.47.23; Tue, 17 Jan 2023 11:47:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EXPgEMC7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjAQTcg (ORCPT + 47 others); Tue, 17 Jan 2023 14:32:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbjAQTW6 (ORCPT ); Tue, 17 Jan 2023 14:22:58 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD4F40BD6 for ; Tue, 17 Jan 2023 10:33:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0C62CCE1908 for ; Tue, 17 Jan 2023 18:33:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDFA0C433EF; Tue, 17 Jan 2023 18:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673980391; bh=e6+ixn4nIUcp6w67VrVoVNFZYoA95xaJpxTzA72soMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EXPgEMC7ZBnGliZkB1kiy2d5x5I/eaWQC41xWgGKT8tPcgAhcMCrky9lpjtbkHIvO K5fGHIf+nHYs0EfSJ2VlMWafeuM6pXCKeu6mND31oV5VnjEWUpcQ9UO3XMkxmHklu1 uM1ed+HUGlPm+buGsiwJSK3dKCcfVBQIb01nWOX8= Date: Tue, 17 Jan 2023 19:33:08 +0100 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/20] staging: r8188eu: we use a constant number of hw_xmit entries Message-ID: References: <20221230180646.91008-1-martin@kaiser.cx> <20221230180646.91008-21-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221230180646.91008-21-martin@kaiser.cx> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 30, 2022 at 07:06:46PM +0100, Martin Kaiser wrote: > struct xmit_priv contains a pointer to an array of struct hw_xmit entries. > xmit_priv's (ill-named) hwxmit_entry component stores the size of this > array, i.e. the number of hw_xmit entries that are used. > > The array size is constant, it's initialised to HWXMIT_ENTRY and never > updated. Simplify the code accordingly. Remove hwxmit_entry, do not pass > the array size as a function parameter and use HWXMIT_ENTRY in the code > that handles the array. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/core/rtw_xmit.c | 8 +++----- > drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 2 +- > drivers/staging/r8188eu/include/rtw_xmit.h | 3 +-- > 3 files changed, 5 insertions(+), 8 deletions(-) This commit did not apply to my tree :( thanks, greg k-h