Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 15:10:12 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Kevin Tian <kevin.tian@intel.com>, Kalle Valo <kvalo@kernel.org>,
        Leon Romanovsky <leonro@nvidia.com>,
        Marc Zyngier <maz@kernel.org>,
        Omri Barazi <obarazi@nvidia.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rc] genirq/msi: Free the fwnode created by
 msi_create_device_irq_domain()
Message-ID: <Y8bylBgnnmzaokaI@nvidia.com>
References: <0-v1-9195b42af947+89-msi_leak_jgg@nvidia.com>
 <87fsc9knog.ffs@tglx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fsc9knog.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ioo9cOCKAor+JmN905lQTv972NOafycMT3Bpb8BY3kgNQHnQK6RKcT835q66?=
 =?us-ascii?Q?atQ+69VptcR1BgQigA58743J54KvdwNyWVndoT/B9UmDh9ehEx1a22ZbtenP?=
 =?us-ascii?Q?eCcB3uvEZABVFkFncSup8ZZy+9KsEWKexK1d+SsIHqfWNnr3r32A+i/SqP0G?=
 =?us-ascii?Q?QgB+sL5CbBdbIm0xcIikPOlCSOYIfgilEiBxW1mNyHPU/7wNYzk6HqVh4lw9?=
 =?us-ascii?Q?x4fE+43syN3UeMi3E+4AwBj64HeOCO48MV/R9d2fj63F3psi535YnD1Aka0Z?=
 =?us-ascii?Q?lfdjBHgA7yG2lUXtcCQFOSA+sCJcmAJYrR48unYBzsvgQod1hvjdGwy8i3U2?=
 =?us-ascii?Q?W/rBvrGsGfBi7CqLLJVCRc8kHJuYyF6wyb6H3CkjAwuRc+BA2nHMvqbSod2K?=
 =?us-ascii?Q?g1SD0+bMiELcbgptc8NyKnnyE4tJXB4vTMGqUCzdgVFeI+Z7jxoZbPgyuGD0?=
 =?us-ascii?Q?OC91l5XTQo9kp+VdM4Rji3a9tldDERtqb3e8OBXGctYrcoOiWVBPSIJ6LXFZ?=
 =?us-ascii?Q?EqQMLJHjQqTzdBM5zxbrb/owWkNXBqMho9L02fUnwJWb3EecP2S87kKtnnEv?=
 =?us-ascii?Q?HMt5Pa846XaHO7cWxqJypVKsLlFSzGfspgSB4+giZhcT0SFyFKHxzKN6GN4x?=
 =?us-ascii?Q?/tTe+NfgWx5jhRP7uxHoecKJDK9+d8zKDSi+WoG8bax5gpRMZAdlBNe0bNuH?=
 =?us-ascii?Q?2CYjpH8ndSY2ie9tkAQAotJfeDF6UXy+Zqi31w3Kg1a37RhJXwJSjxJPTKLe?=
 =?us-ascii?Q?KDo0nV12yjCyblfcr2KG4XIwoSSvaRVAXLPK+T5L9iTfJG1xkxCg5BpQPDCm?=
 =?us-ascii?Q?WfZfLBygGWrweiOCvyFxag/weWv1TVRt9S5FRgXfS2n/J7G1tRg+jypEX6Yj?=
 =?us-ascii?Q?74jYcbN/C2H4UUXaIcRil3zXgZIzwtfhezvi+I8bfNm/unXMB8gAuG+Zon07?=
 =?us-ascii?Q?r6YAlXQwifz5X3JNYnnArpmaDNPEoM/5b8yuXjx2+llXt2uiG+GGV+LQoPyG?=
 =?us-ascii?Q?t51NmwkcVVLrzBFC3dbeoPXvrx6hIUi397jEI0Bre/UhWkAsYu0+MYFqWMPe?=
 =?us-ascii?Q?UZzr+94+6mNSYZBOHPDXeOCxVMAPBeUM1XPy8pNJAfLTH5AJwJN7lkqPmRJ6?=
 =?us-ascii?Q?vOEA+60Piuzinjp6uJ0jDyaL/rFawbz4k3TaLit2o/dp1pycdw/hWpjrpCGB?=
 =?us-ascii?Q?AmItn7cFt6JIm4L8bLL6RdaZfPSqPQN1DUYg18qwOvhkxEwvVga8LlyKuLQV?=
 =?us-ascii?Q?rSoKwWPeaml/bhspPx3DDW3tIVb/CLq5DQPZdhSnPTAxr5zCUGQmZxNXDJUm?=
 =?us-ascii?Q?HsZugEjenuCJrAEC9XCAmlYzQd+qzDuMyIL+MJMEZ4LdNcgLmfsaLDWeJOG4?=
 =?us-ascii?Q?PcQL4FvElhncnfZGuPQYxByItx33fWazM012CGS7Xuvtp5mdXEF+8F/208Pm?=
 =?us-ascii?Q?oZ0debHWN1L3gcFsc5WiyG4uwXTA5Aq7DxkgimuewYDPYJJ5BStq0yDJcrfF?=
 =?us-ascii?Q?HyyQjTDHEHSNso8K/55Z+Ern/i8F8O0uXJedokiTOSNjeZx7mvOB8+z1lXrf?=
 =?us-ascii?Q?TEBmUDmu3L28HugwKswauOf1sftzugkuijkz46Sb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a379f51f-df4c-4afe-73c0-08daf8be75c4
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 19:10:13.1348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T2dsQcE3wwlNry2POwXhS8BmkeKCf93ddZeiRhhxi8rHsrD1OZKMMU6kqFV8cpKz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4899
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 17, 2023 at 07:42:39PM +0100, Thomas Gleixner wrote:
> Jason!
> 
> On Tue, Jan 17 2023 at 11:27, Jason Gunthorpe wrote:
> >  void msi_remove_device_irq_domain(struct device *dev, unsigned int domid)
> >  {
> > +	struct fwnode_handle *fwnode = NULL;
> >  	struct msi_domain_info *info;
> >  	struct irq_domain *domain;
> >  
> > @@ -1025,7 +1026,10 @@ void msi_remove_device_irq_domain(struct device *dev, unsigned int domid)
> >  
> >  	dev->msi.data->__domains[domid].domain = NULL;
> >  	info = domain->host_data;
> > +	if (irq_domain_is_msi_device(domain))
> > +		fwnode = domain->fwnode;
> >  	irq_domain_remove(domain);
> > +	irq_domain_free_fwnode(fwnode);
> 
> This can't work with !device domains because then fwnode is NULL and
> irq_domain_free_fwnode() will trip over its feet.

Uhh for some reason I thought I checked that. I'll send a v2

Thanks,
Jason