Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <345bf5a4-dd58-e906-0236-781ef04bd7e8@wanadoo.fr>
Date:   Tue, 17 Jan 2023 19:42:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: RE: [PATCH linux-next] atm: lanai: Use dma_zalloc_coherent()
Content-Language: fr, en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        "'ye.xingchen@zte.com.cn'" <ye.xingchen@zte.com.cn>,
        "3chas3@gmail.com" <3chas3@gmail.com>
Cc:     "linux-atm-general@lists.sourceforge.net" 
        <linux-atm-general@lists.sourceforge.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <202301171721076625091@zte.com.cn>
 <913000213dd14e3b9da69270134aafa3@AcuMS.aculab.com>
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <913000213dd14e3b9da69270134aafa3@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 17/01/2023 à 16:37, David Laight a écrit :
> From: ye.xingchen@zte.com.cn
>> Sent: 17 January 2023 09:21
>>
>> Instead of using dma_alloc_coherent() and memset() directly use
>> dma_zalloc_coherent().
> 
> I'm sure I've a brain cell that remembers that dma_alloc_coherent()
> always zeros the buffer.
> So the 'zalloc' variant isn't needed and the memset() can just
> be deleted.
> OTOH is it really worth the churn.

More-over, dma_zalloc_coherent() has been removed at the very beginning 
of 2019 in commit dfd32cad146e.

It is not existing since v5.0-rc2.

\o/


CJ

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)