Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 14:21:59 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Praveen Kumar" <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to
 void
Message-ID: <Y8b1V7TwesqmB4Hv@intel.com>
References: <Y8K2SS/zNiPAmLsS@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y8K2SS/zNiPAmLsS@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3iAK0yRdkPiWP4Mi7QLLDnR0OKgUHmWes4Cv9XtgnmcU2Xt0oA2Naee5mIli?=
 =?us-ascii?Q?K9RAPQCJKdiSy8ONMTWBB+aQuL+QvHneYJviPDOAJuQCyAZJMoK9X+sDQHQ/?=
 =?us-ascii?Q?q262W8wXsLVneFmsUAgiEEiQTSC9SFHdj48Ked82DqEXl4+WvxGtJIZVOuKs?=
 =?us-ascii?Q?9Y/QJ4l2I932iQ6mDe3i22boYi6m6aiW0OFWVH/cpLnELuRNvv3UbZiSjmBi?=
 =?us-ascii?Q?mvawNYC7p9mp1UBCj//ZoW+ttxwC8FizVcRA7FodPelEs4NqD5+Vmb2q1I0u?=
 =?us-ascii?Q?KBpoGRFVDMcnRGDY9lq5LvUYP8Lw1Tec9p1+pLUW+MTlVguT3M3vYKRDtJ6W?=
 =?us-ascii?Q?OcwqiLj6ud8rdrYIKfHGRePayCbzNC+jeslQRztJ9a27CkgeXH6NR1QbbyYg?=
 =?us-ascii?Q?MVdJgdbinVJmAuQ/6zGMlL9qPsLCcUC57jAMHhcIdczgtu2iTVzYVF8K59Qz?=
 =?us-ascii?Q?Yw547M79lHYXDDQlAfW4dCgKM8+g8FZJJcr/cqlBB2zDNVLxx8lPA5ykoRfu?=
 =?us-ascii?Q?sl3xqo5MXU7O9KA9riR3VdW/OZhcGN64P3DdtQlRMZBAhBuDyoufQgZ/O6es?=
 =?us-ascii?Q?feoJw/BbZxY+WRxu8VeYABouDS9XKMr0lakpQbErqfWq+hTrEQLKh0md5wUW?=
 =?us-ascii?Q?M5i7l4AQqz+n/QnkSaAFJ5SFUfu4OPbcrOtwfOqdOgLlM7EFa6c9q4hqbvOs?=
 =?us-ascii?Q?0Q8cZKbtui9CeK8BkIPSDPTYEo4L95A8sOXDO9/jUivof3vGp71p2EtxcvP7?=
 =?us-ascii?Q?AAkbK21avZyID2RELhJeyFyLU7zXD15TY72Y1fyf3iL1tKTYF2zAhn4vKvIA?=
 =?us-ascii?Q?hXTbIVdlFkV6AoPyv9aRNvVkhfpsLfhxSZEbam0TRksiKZ8Ar5DDHOICGte9?=
 =?us-ascii?Q?gwT/oadbgtj255iNCgm9tVJM3x/VHaiLZXD3i9e6O+s2NzFVuB8FM54b+uMQ?=
 =?us-ascii?Q?+Nk0D+jxscJyOcla36orWIkiGo+QYiq4ARCdUjCCzkSU7ME633WQrEBLXR2o?=
 =?us-ascii?Q?qPP/YcPue3W8dJoZcVnZzprAQCyfDlUurSH2esiNpmRmWm81P1Nt3fbnQJDq?=
 =?us-ascii?Q?PxwT/N7UdZmSQ2jes2D+WDkMm0vHlYAoaARRj8kVa4UOfqP9zvTQopGcRisU?=
 =?us-ascii?Q?mmckQxQSAmyPrAOturQQsBxnCWGKCAJWysrd1bgwM3erhlgCfQ5Je5VYcUnj?=
 =?us-ascii?Q?VpWKuIiUDFI1Q+/epJ2sw8vFlAKcdHOW8Fd+Kg3IfNsdEpFpBO+rA2/8m5LN?=
 =?us-ascii?Q?6BiiOF77Dx6VlA1qrQSYJV3L8Pu6ZoHhqhSj7oOu1J5YU9NtH+7+gVg28khg?=
 =?us-ascii?Q?qY7He8KXT5HLakrMcLvegSK1bZ9vCrLqpsLoz6djLegLDt6nIeB3KtOjxN7R?=
 =?us-ascii?Q?KveiDm1D5ECDOXTYWeIoMYZDTLmNISZtM6sMb+7UFhO35kVTEnkgkMCSefUB?=
 =?us-ascii?Q?S2EJsmkZhmc4+iJ6U3861OO3O8DG8P+zhoENAuw4TV4vJXE3SVaECyelIRty?=
 =?us-ascii?Q?GuDILeNSGIAg2Ke/UpE/o1oM0WkEGbuN2jbI+qPPzBawan1nOpszPMBZ91MX?=
 =?us-ascii?Q?axdjD1mOBcSkHc9gfic8l67SAtaWNtTuC+mOOPElv2P5RP0fsT6ZIQyILu1W?=
 =?us-ascii?Q?Rw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 486979fc-c7ae-4d8c-e693-08daf8c01d21
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6053.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 19:22:03.6109
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B+mWxV8yGniI3Q7Tf9tBVIcbfWcOHF5oqVnUA2PlcfPQh7c/vNOMI9Z9PBQ88ZqA9wNBGqeMhMFsPH3HIr59sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6171
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 14, 2023 at 07:33:53PM +0530, Deepak R Varma wrote:
> Convert function i9xx_pipe_crc_auto_source() to return void instead
> of int since the current implementation always returns 0 to the caller.
> Issue identified using returnvar Coccinelle semantic patch.

could you please share the coccinelle commands and files you used here?

> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> Please note: The change is compile tested only.

np, our CI liked it.

I liked the clean up as well:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> 
>  drivers/gpu/drm/i915/display/intel_pipe_crc.c | 23 ++++++-------------
>  1 file changed, 7 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> index e9774670e3f6..8d3ea8d7b737 100644
> --- a/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> +++ b/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> @@ -72,14 +72,13 @@ static int i8xx_pipe_crc_ctl_reg(enum intel_pipe_crc_source *source,
>  	return 0;
>  }
>  
> -static int i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,
> -				     enum pipe pipe,
> -				     enum intel_pipe_crc_source *source)
> +static void i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,
> +				      enum pipe pipe,
> +				      enum intel_pipe_crc_source *source)
>  {
>  	struct intel_encoder *encoder;
>  	struct intel_crtc *crtc;
>  	struct intel_digital_port *dig_port;
> -	int ret = 0;
>  
>  	*source = INTEL_PIPE_CRC_SOURCE_PIPE;
>  
> @@ -121,8 +120,6 @@ static int i9xx_pipe_crc_auto_source(struct drm_i915_private *dev_priv,
>  		}
>  	}
>  	drm_modeset_unlock_all(&dev_priv->drm);
> -
> -	return ret;
>  }
>  
>  static int vlv_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
> @@ -132,11 +129,8 @@ static int vlv_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
>  {
>  	bool need_stable_symbols = false;
>  
> -	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO) {
> -		int ret = i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
> -		if (ret)
> -			return ret;
> -	}
> +	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO)
> +		i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
>  
>  	switch (*source) {
>  	case INTEL_PIPE_CRC_SOURCE_PIPE:
> @@ -200,11 +194,8 @@ static int i9xx_pipe_crc_ctl_reg(struct drm_i915_private *dev_priv,
>  				 enum intel_pipe_crc_source *source,
>  				 u32 *val)
>  {
> -	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO) {
> -		int ret = i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
> -		if (ret)
> -			return ret;
> -	}
> +	if (*source == INTEL_PIPE_CRC_SOURCE_AUTO)
> +		i9xx_pipe_crc_auto_source(dev_priv, pipe, source);
>  
>  	switch (*source) {
>  	case INTEL_PIPE_CRC_SOURCE_PIPE:
> -- 
> 2.34.1
> 
> 
>