Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230113154253.92480-1-pasha.tatashin@soleen.com> <Y8USQBPlMNTTIyIO@kernel.org>
In-Reply-To: <Y8USQBPlMNTTIyIO@kernel.org>
From:   Pasha Tatashin <pasha.tatashin@soleen.com>
Date:   Tue, 17 Jan 2023 15:04:46 -0500
Message-ID: <CA+CK2bDKLfgBdO-b6jZ+_LJf2j8poUsZUfx67LDMMm7670miQQ@mail.gmail.com>
Subject: Re: [PATCH v3] mm/page_ext: Do not allocate space for page_ext->flags
 if not needed
To:     Mike Rapoport <rppt@kernel.org>
Cc:     akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz,
        david@redhat.com, quic_charante@quicinc.com,
        lizhe.67@bytedance.com, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Mike,

> > Also, add a comment before page_ext_operations that describes the
> > field, and remove check if need() is set, as that is now a required
>
> Nit: fields

OK

> >  struct pglist_data;
> > +
> > +/*
>
> Please make it kerneldoc.

OK

> >       void (*init)(void);
> > +     bool using_shared_ext_flags;
>
> I'd s/using_shared_ext_flags/need_shared_flags.

Sure

> > + * Note: that if none of the users of page_ext is setting
>
> I'd drop that ^that

OK

Thanks for the review, I will send a new version soon.

Pasha