Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <976dc694-5828-9975-8e87-ac0a850f75d0@amd.com>
Date:   Tue, 17 Jan 2023 12:14:56 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0)
 Gecko/20100101 Thunderbird/109.0
Subject: Re: [PATCH] firmware: zynqmp: fix declarations for gcc-13
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>
Cc:     soc@kernel.org, Tanmay Shah <tanmay.shah@xilinx.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Ben Levinsky <ben.levinsky@amd.com>,
        Ronak Jain <ronak.jain@xilinx.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230117164133.1245749-1-arnd@kernel.org>
 <d6166b85-01df-405b-3112-d9bde16b6bd9@amd.com>
 <eec4d2fd-f305-452a-a47f-83203da494df@app.fastmail.com>
From:   Tanmay Shah <tanmays@amd.com>
In-Reply-To: <eec4d2fd-f305-452a-a47f-83203da494df@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkdtS1VaZHVMVFU0bVBWTklqOVZ0RHJRTFg4KzlGYTh1Q3R1RUMyOGkvby9G?=
 =?utf-8?B?am1ZRjk1VUl6ZUx0N1RUdDhKRHduNlhFUWNEN0ZCT0ZZcGs3SDl2cC9remd1?=
 =?utf-8?B?N0hLOWxlZy83Y20rODdLVld2VUFzaTJMNEpENzNxMzZxQ3MzdjhIU1FhMTJO?=
 =?utf-8?B?K3gvTXllaU0wdzJsd0xUaEVoRWF6bE1nNlZ3ek85cS9CMDZPR3R2Z2tRczNK?=
 =?utf-8?B?Q1lJVkNCa3V0QVFKOEtxdXFWc1BMbUpGV2NsZER1MGpOaEtOemdaV2tPbDd3?=
 =?utf-8?B?Z2hDUTZCb3VPNGdEa2NPR0pZaXZYYS9tNkdTMEdKMlBUNDZQSVhuUkMrV29J?=
 =?utf-8?B?Ulh1R1ZVMGM2MG45YlFNWlpQQko5L2hmY2JWdXlqbHpQVnJBZWErMXh2YWdT?=
 =?utf-8?B?MzJFWTI3VlJmRXZSNDE3K0JwaVYwYlUraENFanMxWThKeEw4dFlWZmpvY1hy?=
 =?utf-8?B?Ry8vYnBqSnNyUk5vcHQrcFpzRmxjaFVLZlZoMWg4aU5rVHl0bUs5a3Z5K1E0?=
 =?utf-8?B?dVphYzFGaWxwb3lFSXNJdnpnc1p6cWJtdmtxMFErSUhKcWNHNTVEOGZLaUpt?=
 =?utf-8?B?REtFZ1lSVnpBV05GZFZaK0k1R3pxNUFZdWpObEo2OEljcEp6cEh4TERTNy8v?=
 =?utf-8?B?bVVsZDljOThJanNxcEQrcUszaWcrRFRGallHUlZiU2xoRlY0eHhmOUxnSmJh?=
 =?utf-8?B?d21JNGxqNmJHczV6Q1lSaWZnODdBb3hvZ3RrR1U1YjljR1ZoYXVEYUlCN2p3?=
 =?utf-8?B?RnBLVHBjOUxRcmpnYUVTRm5VampPbS9xNEFLZFhJNmYxbnNsODdwRjlEdmpq?=
 =?utf-8?B?MUdEbzhpVzhWemcrODVnZGVIUUFXSXppWnlDSTBDZU45aFFyVDBQQ1EvTVox?=
 =?utf-8?B?ZHN3VnZ3VkNUSnBBQTBFaHNIM1JBTU04SnMyaDViV29DUmFPc0xISyt4alBR?=
 =?utf-8?B?Wmp1WEd4ak1YbzZoSW1qSERmVGRPWmgzbHBMdzNMQVFzcVUxa1lIUXEwb2Za?=
 =?utf-8?B?S1ZpbTZXb1JZSVVNZ2N3RG9NTDFUdXZpWHJEa3lXMStBaFRtWWpSZzJIMFdj?=
 =?utf-8?B?RkFkMVdPK2R6cWxrUkdVc1p5NkZzc05GRStFRG12Rm9YMnN6VTBpcUNld2xF?=
 =?utf-8?B?aW4xZmtmTFI1WVRhRVp3TlB4UXZPeHllUjJDMkNweFpXTXRjSDVLMGxyTEtK?=
 =?utf-8?B?SUVwZE1VYXQ5TkkwSHhWeUFxRm84cVcxSzRBMzQzVkpjT2d0NVh0UEpUL05u?=
 =?utf-8?B?dTJISUJ0NVlOWEtkYXZWRHhmMFRPbitCVDdQdE5UZkYxbk45elc5KzhCSUNl?=
 =?utf-8?B?dW1YWVZ4V2JpdFBBeFVzN1lBY3lSR2xCM3o4OW5lK1c2WlZqL1NhT1dXcG1F?=
 =?utf-8?B?ZmUxRDVnbFZETTNzYW90eFRJZk9xcU1EdEFqWTNSQk04U2tOdis2MVJVNzdL?=
 =?utf-8?B?cjQ3UnVtc3RCcHhHMHVIUGlEcDNEcmJoY0RNQkFIM2xtSllqbytUYTRNWVVX?=
 =?utf-8?B?N0p2OTU3SUJPbk5vSk9TUUZpNE4xZ29ybldOU3owbGZYc3pQU0JOd3VVQ3BD?=
 =?utf-8?B?TmxPUVI5ME8xcTJNYzc2MGUxTlVpUnpIMWpWY3QwMXRZbWxDTDZVNXdwT1Bn?=
 =?utf-8?B?WWNib1BDcVlYb2wrMWxSdFdWL21CcUVJRzEwcVRHTndsYkVTcWNnMGJsOWVp?=
 =?utf-8?B?bklmeWdzbVZiZ21UNHBURzRyNit5TkVEU2ZxK2FOYkMvdCtrSWNhbGxpREQr?=
 =?utf-8?B?K0hDNDBUOFVaNWxVUkY4dy95N2VoWWxqUVhkWjdvNVJBQ2lLWHBaVTZjUUYx?=
 =?utf-8?B?RXc3NHdDcVVTajFhbHVWSVN5TE5RTWUrS3lmUWgvK21LR3ZFb0FndlJyMWU4?=
 =?utf-8?B?bi9yRnZ5dlFJMzNldVRUaitvOHpNT2F4SWhVYWdWK3ZpOUFMV1MyQXRDRUh5?=
 =?utf-8?B?ejFON29sYWJZcUlsZjBaTXZxb3ZNWkdCS0EvRitvbFpDV0l3dVhHMnR1cjU1?=
 =?utf-8?B?ZHdYdjkwWVgxYWFQd2VsVXJRNzJnZEdnUVQyQ2EvWkx1TVV4SDNNaVJjdXRo?=
 =?utf-8?B?UkM1OHlvYUNHbkNJbVFSZWFtRVNzcXZ4cEU0RU9mYXpYZWRybGtrTFA4N2h1?=
 =?utf-8?B?TGxtbitBNHNqMGFiSldpQ1lIVTltay9sWlROYXNvOW1GOXFpZVNrbDFoMHRi?=
 =?utf-8?Q?3DopqVkT3pX8gvTbRoawOyavT8zEvZ/FbWn4pGW9bIEv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37da5199-ffed-45ef-f586-08daf8c781ef
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3683.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 20:14:59.0076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rkcCavnBCTRHV4y47eV1UAkTK4myxqFUdzKrXPYK+VjAROG9jFwO4IpYIqCkfOJg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4496
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/17/23 12:03 PM, Arnd Bergmann wrote:
> On Tue, Jan 17, 2023, at 20:53, Tanmay Shah wrote:
>> This looks good to me. Thanks for fixing this.
>>
>> Something must have gone wrong when I ran sparse check on this patch.
> I don't think any of our previous tooling caught this, only gcc-13
> changed some of the behavior around enums.
>
>> Just one question, does this patch need "fixes:" tag?
> Probably a good idea:
>
> Fixes: a5e56980cfb7 ("firmware: xilinx: Add RPU configuration APIs")
>
> I can apply this directly to the soc fixes branch if you like
> and add that line.
>
>       Arnd

I am ok with that.

Thanks,

Tanmay