Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6166b85-01df-405b-3112-d9bde16b6bd9@amd.com>
Date:   Tue, 17 Jan 2023 11:53:32 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0)
 Gecko/20100101 Thunderbird/109.0
Subject: Re: [PATCH] firmware: zynqmp: fix declarations for gcc-13
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>
Cc:     soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Tanmay Shah <tanmay.shah@xilinx.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Ben Levinsky <ben.levinsky@amd.com>,
        Ronak Jain <ronak.jain@xilinx.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230117164133.1245749-1-arnd@kernel.org>
From:   Tanmay Shah <tanmays@amd.com>
In-Reply-To: <20230117164133.1245749-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjYwQTNaTVJsZGViclc2aVRJS2FoblZaZWdkczJNcW0wTS9Td3ZSa3lKcnZT?=
 =?utf-8?B?TkZmVW92dXM3VmY3NzFSb1JCeVNobzZBRSsxVHorWHc2azAveXVXUkZiUC9z?=
 =?utf-8?B?enI1ckVtYWFKVkFuaUxGcTVUeTY3LzlaZHZKbXdmc1ZyZXdaUzdEK1BrM0h0?=
 =?utf-8?B?dzV2bXZyaDBsTHJ3VWQyODdZR09SenJrWldONktXVEd1MFJSQWdWT0NldDVE?=
 =?utf-8?B?RE1XOXQ1QUd4eGZFOHFtRzRYSXpNMURPMjQrSG1PbVRWY3pkWC8zVk9YMjUx?=
 =?utf-8?B?Q3dyY0p0T0xEMzlwTDh0YVBKRDJlcEhxV09iSTZkR053anppTU40RXFuaHFX?=
 =?utf-8?B?akU3SlJUaEVaaFJaeW1NQ1pwVzNNNkp1eVdEMnJHQnhDRUIyaWdiK2tzY1p5?=
 =?utf-8?B?bFRGYWkrU1RCRFZoMlhFcVNNaU1hU0o4Sjh4bkVEZFdJSjdTbEJSdksxNEUx?=
 =?utf-8?B?T0xmL2FGcThxaXg2Zll2Vm43WXpHY2tTRHJ5dTFOV09ZZVRveWJmei9na2FI?=
 =?utf-8?B?eWNsalEzTkJIUExqNVR4UlJydWVtcDdGZkxDM01IVkNnM2thT3lVdmhXa2hF?=
 =?utf-8?B?VXJqRS9tbyt2Q0xzV3dOb2VwYzFqcHh4MjlBYmpOWFpVaGRBZ2UzYmxXaUww?=
 =?utf-8?B?UVJTNzJ2bUVwTHJVT1dzQStkZHJwOElTYjlNY2g2YXF1Rk1lQkJGQk1aQkNH?=
 =?utf-8?B?S0l1Z05lVWRtWjFhaTc5eDdNYkFEODFESmVMc05HZkxoMkJWdTc1UVlaMU14?=
 =?utf-8?B?L2kwQVZmZ0ZFMmM4dEM3RFdqMnUyVnVKWm55ZUdkUkR5bzN4aTU0Zk9TREJY?=
 =?utf-8?B?L3pucHFOZUtSLytZeEF1SXl4blg3L1Q5d1IvRUZ0UkltSURGZzBUYzhmZ3U5?=
 =?utf-8?B?a3M4MU8rMGI1MU55c1RNQ1F5T1F6T1dITVZqOVRESEovVHdPbnVnQ3k1eWlw?=
 =?utf-8?B?bEpvT2I1aFYzYllGaWFFd0lYRXZNNkYvVEVLd2hiRkdyZkRwZTdRYloxYU1p?=
 =?utf-8?B?aTBlOXV4Y3A0Z3VzMXVEUVlaRGFoOG1jTnJwdUtOYlJTdTJPNEtSZSsrMTFV?=
 =?utf-8?B?YVo0SVdTOElXSVg1Kzg3THh0cGFlNTlNenhQSFA5YXllTk44aHdWRmdkU0ta?=
 =?utf-8?B?T3ZlVkhYT1hOVERxTWRORzZrdXRuMmNzd1lyK1BCVUVVMmRHQlRTeTMxOVh6?=
 =?utf-8?B?dU1vVGIweWxqeTd1anZHU2YvSjJFSkJVb3QvdkUyQ25Lcmh3bndZUU5aRUp4?=
 =?utf-8?B?YmxpRUhkOWxIWWlLWFEvUEtzVkllWkM0STVQd2lCbUg1TVNzV0RVWmorb0tL?=
 =?utf-8?B?RVRJdEk2UzMzY29VbnBRNS90MFZaMU5qT2xtRHNMbXdDZW0zMlRFVDVWaWpN?=
 =?utf-8?B?VHFMNlc4Tzl2S05pZ0JOTGY4Qk5lWkw1ZU1zS0lQeXZKcCtiV2JPME44dG56?=
 =?utf-8?B?R3FrWE5oSUNwaEFPMVJiT1pQNlp1cm02dk5heVFMREswblFMMUpwM3F6Ym5X?=
 =?utf-8?B?NDFXYXRDTDB3QzdEeVBscHZXNFAzNEZOMmlHVlBaWTdaSkZ2c1lSZ240aXFO?=
 =?utf-8?B?SVp6WXRqNXgzSE5GOVIyNEs1d056STFEejBqdmw5YTE4N1pIWWIwUU1UUVJY?=
 =?utf-8?B?ZUhTV3FkSHUra2pscmJ6Q0plNjdmK2h1SEpOSUhONnhtRlUrUGxTMmsrT1lD?=
 =?utf-8?B?NWZwZGJmWGdxYUFIM2xtaXM4TlAxWHBsaXdpS0FRQmh1cVFjTWhnSzR3dlJo?=
 =?utf-8?B?cEFTLzkwQ3g3RXk5SFNiV3daQUJVMXdtcjliWWkxTWlCZVIzTStoUzJWdFhh?=
 =?utf-8?B?YUVTM3R5a1R3bzhKMjA1bHNNL3BLc0NiNnIwMEdNbkw0Y0ttZ1hodE1ReXVL?=
 =?utf-8?B?S3NDU3duMVV4UHdUYVkxekR2Ry9qdndGeUt4SEdBaVU0WWI5a0Z2TmRJaEpW?=
 =?utf-8?B?eWhBd2NySlNHRmNhWkZhdzgyZUtFS0tOeUtObllLWkZ1UmZrZUJmT2NKcGYr?=
 =?utf-8?B?VHN2S09PdWZURWRLTXBUODlaa3MrN1pzc25uaXJsNzZqaVBnUjFDc0JIQmFY?=
 =?utf-8?B?dkQrRTRlRWJGdmc1WG0rektVRE5rckNqZzRIbjhLRGlNc2lYcXJTQzUrVEND?=
 =?utf-8?B?cGxXTjdZbHZxVnhUY2ZPZExONWpkVkpkeGFidldlZ3RpU2FieXpmdWlrcDJH?=
 =?utf-8?Q?VjPxU9XiIyymLkD5JkUtrNxqDa4eGAr3I+hJPfSaEaaZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 839498e7-8002-4f8f-5f4a-08daf8c48445
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3683.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 19:53:34.7763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eqv4tUVVmxaZUogdDRw/RzxbuZGBewPOqNojFcs/L+Rq5Ih8/eFHcrjV5K8kN1bi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5288
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Thanks for your patch.


This looks good to me. Thanks for fixing this.

Something must have gone wrong when I ran sparse check on this patch.

Just one question, does this patch need "fixes:" tag?


On 1/17/23 8:41 AM, Arnd Bergmann wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
>
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc-13.0.1 reports a type mismatch for two functions:
>
> drivers/firmware/xilinx/zynqmp.c:1228:5: error: conflicting types for 'zynqmp_pm_set_rpu_mode' due to enum/integer mismatch; have 'int(u32,  enum rpu_oper_mode)' {aka 'int(unsigned int,  enum rpu_oper_mode)'} [-Werror=enum-int-mismatch]
>   1228 | int zynqmp_pm_set_rpu_mode(u32 node_id, enum rpu_oper_mode rpu_mode)
>        |     ^~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/firmware/xilinx/zynqmp.c:25:
> include/linux/firmware/xlnx-zynqmp.h:552:5: note: previous declaration of 'zynqmp_pm_set_rpu_mode' with type 'int(u32,  u32)' {aka 'int(unsigned int,  unsigned int)'}
>    552 | int zynqmp_pm_set_rpu_mode(u32 node_id, u32 arg1);
>        |     ^~~~~~~~~~~~~~~~~~~~~~
> drivers/firmware/xilinx/zynqmp.c:1246:5: error: conflicting types for 'zynqmp_pm_set_tcm_config' due to enum/integer mismatch; have 'int(u32,  enum rpu_tcm_comb)' {aka 'int(unsigned int,  enum rpu_tcm_comb)'} [-Werror=enum-int-mismatch]
>   1246 | int zynqmp_pm_set_tcm_config(u32 node_id, enum rpu_tcm_comb tcm_mode)
>        |     ^~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/firmware/xlnx-zynqmp.h:553:5: note: previous declaration of 'zynqmp_pm_set_tcm_config' with type 'int(u32,  u32)' {aka 'int(unsigned int,  unsigned int)'}
>    553 | int zynqmp_pm_set_tcm_config(u32 node_id, u32 arg1);
>        |     ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Change the declaration in the header to match the function definition.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   include/linux/firmware/xlnx-zynqmp.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index eb88b4ba62f9..0e4c70987e6a 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -549,8 +549,8 @@ int zynqmp_pm_request_wake(const u32 node,
>                             const u64 address,
>                             const enum zynqmp_pm_request_ack ack);
>   int zynqmp_pm_get_rpu_mode(u32 node_id, enum rpu_oper_mode *rpu_mode);
> -int zynqmp_pm_set_rpu_mode(u32 node_id, u32 arg1);
> -int zynqmp_pm_set_tcm_config(u32 node_id, u32 arg1);
> +int zynqmp_pm_set_rpu_mode(u32 node_id, enum rpu_oper_mode rpu_mode);
> +int zynqmp_pm_set_tcm_config(u32 node_id, enum rpu_tcm_comb tcm_mode);
>   int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type config, u32 value);
>   int zynqmp_pm_set_gem_config(u32 node, enum pm_gem_config_type config,
>                               u32 value);
> @@ -849,12 +849,12 @@ static inline int zynqmp_pm_get_rpu_mode(u32 node_id, enum rpu_oper_mode *rpu_mo
>          return -ENODEV;
>   }
>
> -static inline int zynqmp_pm_set_rpu_mode(u32 node_id, u32 arg1)
> +static inline int zynqmp_pm_set_rpu_mode(u32 node_id, enum rpu_oper_mode rpu_mode)
>   {
>          return -ENODEV;
>   }
>
> -static inline int zynqmp_pm_set_tcm_config(u32 node_id, u32 arg1)
> +static inline int zynqmp_pm_set_tcm_config(u32 node_id, enum rpu_tcm_comb tcm_mode)
>   {
>          return -ENODEV;
>   }
> --
> 2.39.0
>