Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1187-g678636ba0d-fm-20230113.001-g678636ba
Mime-Version: 1.0
Message-Id: <eec4d2fd-f305-452a-a47f-83203da494df@app.fastmail.com>
In-Reply-To: <d6166b85-01df-405b-3112-d9bde16b6bd9@amd.com>
References: <20230117164133.1245749-1-arnd@kernel.org>
 <d6166b85-01df-405b-3112-d9bde16b6bd9@amd.com>
Date:   Tue, 17 Jan 2023 21:03:26 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Tanmay Shah" <tanmays@amd.com>, "Arnd Bergmann" <arnd@kernel.org>,
        "Michal Simek" <michal.simek@xilinx.com>
Cc:     soc@kernel.org, "Tanmay Shah" <tanmay.shah@xilinx.com>,
        "Mathieu Poirier" <mathieu.poirier@linaro.org>,
        "Ben Levinsky" <ben.levinsky@amd.com>,
        "Ronak Jain" <ronak.jain@xilinx.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: zynqmp: fix declarations for gcc-13
Content-Type: text/plain
Precedence: bulk

On Tue, Jan 17, 2023, at 20:53, Tanmay Shah wrote:
> This looks good to me. Thanks for fixing this.
>
> Something must have gone wrong when I ran sparse check on this patch.

I don't think any of our previous tooling caught this, only gcc-13
changed some of the behavior around enums.

> Just one question, does this patch need "fixes:" tag?

Probably a good idea:

Fixes: a5e56980cfb7 ("firmware: xilinx: Add RPU configuration APIs")

I can apply this directly to the soc fixes branch if you like
and add that line.

     Arnd