Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9e43dd11-38b3-fe0c-0929-8b454591813a@intel.com>
Date:   Tue, 17 Jan 2023 14:16:54 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v12 00/13] x86/resctrl: Support for AMD QoS new features
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230113152039.770054-1-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230113152039.770054-1-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amxHUDFqYTluT0IyTkxCVlpoSDV5Z3hMZ2ZSb092L05SSFJmQzZtZGV4Ti9C?=
 =?utf-8?B?OTlmaVdCblBKM0lsTWJDNWNpQkd0SU5WbVNqRmEyMUp5Nm5ESk9tWkk1Ynpj?=
 =?utf-8?B?SFJkRkFSaHZpSUZKK1NURS9uUzNvZ2djNzVjTDZnTlYrdzNOZzRjLzB3bzE5?=
 =?utf-8?B?UnIzRGx1ZVlLNDBlekFzR2h4K0xIWkV2U2Y3eFVNd0Q3M3ZTd0hyY1ZsSzM3?=
 =?utf-8?B?bERzbklpV2g2dVcvRi9qbUFQV2dsNlN4WXNuTCtuOVgrQlZ6VEc5aHZ6YzYx?=
 =?utf-8?B?dWY4VTl6Rm54WHFSZUg4c2tFRURhVW1pNTVabjRkVjdITVR0RlNLZ1ErWEFD?=
 =?utf-8?B?VklpRjd1K2xsdDl0aXQ3UW44RnA3dmJpU1lmYkFnS0RFeWg1bTd3YmhaQ3hR?=
 =?utf-8?B?R3B2OGlVZXlkcVJQNm8wc3hXdWVIV0ZtemlDdlJGcUtra0JWKy9GVVBtcGhy?=
 =?utf-8?B?U05aNzlwK1ZkblEwSFp6eENMdnZEZ1J3aFM5QWlIUHE4bG5CQmRhZHZ0KzYx?=
 =?utf-8?B?U0FNc1BzUUwySnRCSVdBdVkzM2JDSTNiNGNMN0cydlFoN2U5VkwxSW9sazRJ?=
 =?utf-8?B?SSs3d1A3bHU0VkhhdXhaODFJT3pOWkJJVjh3T1NxUE1ZYm0xemo5OXRFN1Vm?=
 =?utf-8?B?YXNlNmFJNmRIdkI2eWhJdWdKNnpzTGRURDQzWkJBNVNPUm5qTzdGK2tBZXJC?=
 =?utf-8?B?MXE5OU9EcmEydWUvRyt5YkUwcXZxSXZ1ZTZ1aVhHZ1FnTFI2UUVFSGovWHNz?=
 =?utf-8?B?Wk9PWkp1Z3BGTkVkL0dydGpQVHVwZFB6cUs4Tnc1VkQvOTc3TjJ6RitvalBq?=
 =?utf-8?B?dzlrWkwrZnNXT1NOdVhUY0FmQWVkei84WFV1SG1reks5ZzhxNG0vQVpHb0pC?=
 =?utf-8?B?c1NkWFJEdHhXU1pWOHREQXdSU1RUcE9na0JTSm9CSVd3NXViUnJHMlB5WkNL?=
 =?utf-8?B?K2JDRWJkcWprNmJIeHpxVnpCUXFBYmltNlBWNXg1azNuKzRMNDlCaXBlekg0?=
 =?utf-8?B?K29YbnU5YnRqci9MZTZhdEdDYkVUMWdkalh6cWdQcnF2elFqSU5TdFRjSzRG?=
 =?utf-8?B?SGdJa2NCTnVUYzRORGZCVnRCbGZzWEp1VnMxQXBBcjZuMEdMTXZCWFduUU4r?=
 =?utf-8?B?ZmYxZ2h5VjdnRU5rRUZRWGQwaEY2SVlWdXNWTVFJN1M2b3k3UW8zN1V5a2dr?=
 =?utf-8?B?SG5CZXR1SDlRREY2cVhpZGpOOEhOeUgvSkJVZzRTZkdSUldtMkxBWE1HUVlo?=
 =?utf-8?B?K0t0cnBzMjkxVU5nZ3ZpdTdKbDdoTjlTYzJoQW1EeS9hdzY5TG5kNXExZi9y?=
 =?utf-8?B?ZGN3clBHMS9zQkxhL0NGZHdpbHRVczZla01vK3VwKzRLS21KTm5ZU2RiNmlR?=
 =?utf-8?B?cmQ2cEwvdko2aTBEVHA4eXAxSGtsWFdhZ281enc2U2xObkcvNkwyRFFCMHNU?=
 =?utf-8?B?dzJobXVYUHhmNE80Um9zMGR0ajVyZW1QWHowcndZMTgwQXdYMnc1eFdVRmQ3?=
 =?utf-8?B?L0VyRVVlb09KQlVVZUoxd2JEVy8yVmxjL21aZFpxK1NIUkphZEdkT2NrQ1pG?=
 =?utf-8?B?bHJLVUJKWmEyNVZjSE9CbWttSmlQZzgvbzFNOGxwejhLbW1mVkRCZ2hDWFJm?=
 =?utf-8?B?THRXZ3VsM3poN2RUa0lWbForajFiK2Rxa1FCdFpDdXBLTmRNK1E4d0xyZFNO?=
 =?utf-8?B?SFFFNy9vTldEM3NmLzNDdXRUdTZiWEd1Qmw2clRxQnNvc1pjMnltVWFyUVlU?=
 =?utf-8?B?ZnVCZW9HUkZqV1NzSVdvN3AzdDdrZTZIeS8zekhzdCt5WDlWbXR1cURlYWlj?=
 =?utf-8?B?S2hsWE9VblRwc2NkOHNFcEFPMG4xQ1JnWG1hK2hxMXZpL2V3NmtJam9USXdC?=
 =?utf-8?B?b3VQVjhNU0pxWjVUL0tCelJLSEVDQ3dXYUR3M3B4bWZ5N09DUzdyZ29sYkti?=
 =?utf-8?B?bzhLYXVQVisvQlBmNHZZTGFrZDZRVisrNU9hZzlISXh6d2VUMjZRQlhld2ZP?=
 =?utf-8?B?VW1WWmw5L1A5ZkUzSW5kaC92bG9Db09lOFNoVHNBWG5rWnF5NTdEQ1h3Y2Jv?=
 =?utf-8?B?QnRvUlovYkhxWkw0NkwxN1AybElvZXI2OTRUMDNRb011Ny95TWFCYTZZQXo5?=
 =?utf-8?B?U3VXQjhGUGl5V25rbmlQZmRaaFhLV1F5bG1YMERqNmdXdkVHT0VFQXRpL2Zo?=
 =?utf-8?B?Q1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d1d94ce4-2029-4b8d-5fa6-08daf8d88caa
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2023 22:16:58.6540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WR+lW2D2+OQ2Nhgk+C1pZbUerrkb+bpzp8zCNqzlH+6m9QjQaO9XSffxVBSZAUZVQQ8npOvCenRdTM6HA5X7rhizkcy+rr5rWw1q2TQ4nnE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4889
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 1/13/2023 7:20 AM, Babu Moger wrote:
> New AMD processors can now support following QoS features.
> 
> 1. Slow Memory Bandwidth Allocation (SMBA)
>    With this feature, the QOS enforcement policies can be applied
>    to the external slow memory connected to the host. QOS enforcement
>    is accomplished by assigning a Class Of Service (COS) to a processor
>    and specifying allocations or limits for that COS for each resource
>    to be allocated.
> 
>    Currently, CXL.memory is the only supported "slow" memory device. With
>    the support of SMBA feature the hardware enables bandwidth allocation
>    on the slow memory devices.
> 
> 2. Bandwidth Monitoring Event Configuration (BMEC)
>    The bandwidth monitoring events mbm_total_event and mbm_local_event 
>    are set to count all the total and local reads/writes respectively.
>    With the introduction of slow memory, the two counters are not enough
>    to count all the different types are memory events. With the feature
>    BMEC, the users have the option to configure mbm_total_event and
>    mbm_local_event to count the specific type of events.
> 
>    Following are the bitmaps of events supported.
>    Bits    Description
>      6       Dirty Victims from the QOS domain to all types of memory
>      5       Reads to slow memory in the non-local NUMA domain
>      4       Reads to slow memory in the local NUMA domain
>      3       Non-temporal writes to non-local NUMA domain
>      2       Non-temporal writes to local NUMA domain
>      1       Reads to memory in the non-local NUMA domain
>      0       Reads to memory in the local NUMA domain
> 
> This series adds support for these features. Also added a minor cleanup(PATCH 1).
> 
> Feature description is available in the specification, "AMD64 Technology Platform Quality of Service Extensions, Revision: 1.03 Publication # 56375
> Revision: 1.03 Issue Date: February 2022".
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
> Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-quality-service-extensions

This series looks good to me. I added my "Reviewed-by" tag to patch 13/13. All
the other patches in this series already have my "Reviewed-by" tag.

Thank you very much. 

Reinette