Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5581792rwb; Tue, 17 Jan 2023 16:04:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXu14PrdjqX+43vu04fjUXz6xkeYalfbN0cugy4Wbkab7nxNQlySwJEDcsQ/74OQthsmTmO/ X-Received: by 2002:a05:6a20:c754:b0:af:7e01:706 with SMTP id hj20-20020a056a20c75400b000af7e010706mr3913615pzb.52.1674000284036; Tue, 17 Jan 2023 16:04:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674000284; cv=none; d=google.com; s=arc-20160816; b=WG9XCCeXweFtWJ78pClcUWkw3N1bpEsfjryXZCGHRaKHsASQ6/EdZbTqC6vXSIF03L inqxpPe6YiRS8XXa+T5nXv0xBolriRqanQsPX3Vr4AKXJryE+QrQ1PfkLEoagpbrVrMJ t52iiFp2ufUaMq9C7kiqTsIC59R/d5TuKGKHyNkom8H/vo88Ag1rUfOQgd1yR9/bxjvK cnbwO97Xk1awjb+opHpUA7NjywbDThHRvpeOWwp/JIyzVsQToOGJnCbfo64T3cE363XO jbnzddcFrCVQYzBXu/p/M6fFKkyBVcWhxn9I15X+WPDtOxZQSwJYXNNoIP39scm9tp3R Cv9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=CwRo+vqx7lsGAdCxZnp4PR6KcJNRCSVuz79Vo5hpT/c=; b=Zj/e/smQGsc7wTB6qcLH0TE0an1BUxzIcd4twAt3S3DsrG7ufhqo2W+vkda+ujPo32 ukBG7hQqZWga4EWekNKQZCx7qJn6wxnQgZCqhX1W2Lho5qW+t5eEH3OISKNqUKe838MR Nj5vZnfHQVdZNZqiZcTDWucNB3iH97igFrP6SFdQOEzFGJs6LrLAfjfH13VLhgf/pqyP P6TodgWiPhtKFQ6ud6WjU4pE4tqPIlonYWXk1NAPZmEU+ZU8W76wDwYxLWHiS/yYiGiq 7amyaz9Btse7EzLAPnVYRbnvrj8QxU9FRI0NonW8n8o36NqtAat9xshYSpj2yfKm5znU yx2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pUqlEQY7; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=Z7KPACyV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m132-20020a633f8a000000b00476e640ddfesi34827997pga.80.2023.01.17.16.04.38; Tue, 17 Jan 2023 16:04:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pUqlEQY7; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=Z7KPACyV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbjAQXYm (ORCPT + 46 others); Tue, 17 Jan 2023 18:24:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbjAQXX4 (ORCPT ); Tue, 17 Jan 2023 18:23:56 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE54A45D5; Tue, 17 Jan 2023 13:17:06 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673990224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwRo+vqx7lsGAdCxZnp4PR6KcJNRCSVuz79Vo5hpT/c=; b=pUqlEQY7RAB4LOYhsb75FhYjstnm+Q4UGqEGCdZpw74Lv+HWHnSaglSEiqxpXUfAQUP8qF 89v5BmsKARHNrxMaqabC+0Vv15+3PbKdxXnrt0xYxBm2DgOw8T2Wfr/jdsd5LYd3X89s27 3JIDHlixeabWECQOus0E1vntodEgMlQWIeeFXayd3y3WfHtuP8cPyJ5AdmL2y3zsDnVC/4 XqKpMAYPtmPC9uW+XtqZFe0iBDxt9W6iOqmvS3lIpcUmLlILP9xM+oKh/vz+wpDUGotLar INLlLv5uJvGIKlEuMzrSNX/H3f6+SWx7Z0dOrRU6qTEmUYbf/RBXzQTH41KC/A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673990224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwRo+vqx7lsGAdCxZnp4PR6KcJNRCSVuz79Vo5hpT/c=; b=Z7KPACyVZicf25k3gLbejR2b8zwPfiR+rcW3tJXcnNvAw5ukjRGi44v/e84CxYqZVm9FRL ff2zoua9a9U3VNCA== To: Johan Hovold , Marc Zyngier Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 01/19] irqdomain: Drop bogus fwspec-mapping error handling In-Reply-To: <20230116135044.14998-2-johan+linaro@kernel.org> References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-2-johan+linaro@kernel.org> Date: Tue, 17 Jan 2023 22:17:03 +0100 Message-ID: <87cz7clv3k.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > In case a newly allocated IRQ ever ends up not having any associated > struct irq_data it would not even be possible to dispose the mapping. > > Replace the bogus disposal with a WARN_ON(). > This lacks a Fixes tag especially because this ends up in the dependency chain of the race fixes. Fixes: 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ") is not completely precise but close enough. Thanks, tglx