Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9a5b63ce-aeaa-77cf-0e36-53ee472a1656@zytor.com>
Date:   Tue, 17 Jan 2023 15:50:41 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v4 3/3] x86 mm, x86 architecture (32-bit and 64-bit):
 arch/x86/mm/kaslr.c: Adds 64bits version of prandom_seed_state
Content-Language: en-US
To:     David Keisar Schm <david.keisarschm@mail.huji.ac.il>
Cc:     linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, Jason@zx2c4.com, keescook@chromium.org,
        aksecurity@gmail.com, ilay.bahat1@gmail.com
References: <cover.1673470326.git.david.keisarschm@mail.huji.ac.il>
 <295dceed7bef2391f86e751b9bfc9a34347062e4.1673470326.git.david.keisarschm@mail.huji.ac.il>
 <9fc36447-5534-b93a-98d2-0999820c0def@zytor.com>
 <CAD0z2U1Y1CR_erAj+akPbVF2jxicdQKQfqWPc69fwL-rvSu_fQ@mail.gmail.com>
From:   "H. Peter Anvin" <hpa@zytor.com>
In-Reply-To: <CAD0z2U1Y1CR_erAj+akPbVF2jxicdQKQfqWPc69fwL-rvSu_fQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/17/23 13:16, David Keisar Schm wrote:
> 
> Because (the way we understand this), Kees Cook prefers to keep the 
> original API, so that a fixed seed can be injected at will (for 
> debugging). Seehttps://lkml.org/lkml/2023/1/6/772 
> <https://lkml.org/lkml/2023/1/6/772>
> 

This bothers me, because with FG-KASLR is *exactly* when a bad PRNG will 
shine through.

	-hpa