Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 16:53:26 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     "Herton R. Krzesinski" <herton@redhat.com>
Cc:     linux-kernel@vger.kernel.org, vbabka@suse.cz, jforbes@redhat.com,
        dzickus@redhat.com, scweaver@redhat.com
Subject: Re: [PATCH] tools/vm: allow users to provide additional
 cflags/ldflags
Message-Id: <20230117165326.3e693a12a45a1962ca0c40af@linux-foundation.org>
In-Reply-To: <20230116224921.4106324-1-herton@redhat.com>
References: <20230116224921.4106324-1-herton@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 16 Jan 2023 19:49:21 -0300 "Herton R. Krzesinski" <herton@redhat.com> wrote:

> Right now there is no way to provide additional cflags/ldflags when
> building tools/vm binaries. And using eg. make CFLAGS=<options> will
> override the CFLAGS being set in the Makefile, making the build fail
> since it requires the include of the ../lib dir (for libapi).
> 
> This change then allows you to specify:
> CFLAGS=<options> LDFLAGS=<options> make V=1 -C tools/vm
> 
> And the options will be correctly appended as can be seen from the
> make output.
> 
> ...
>
> --- a/tools/vm/Makefile
> +++ b/tools/vm/Makefile
> @@ -8,8 +8,8 @@ TARGETS=page-types slabinfo page_owner_sort
>  LIB_DIR = ../lib/api
>  LIBS = $(LIB_DIR)/libapi.a
>  
> -CFLAGS = -Wall -Wextra -I../lib/
> -LDFLAGS = $(LIBS)
> +CFLAGS += -Wall -Wextra -I../lib/
> +LDFLAGS += $(LIBS)
>  

I think EXTRA_CFLAGS is more conventional?