Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 17:12:07 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Alison Schofield <alison.schofield@intel.com>,
        "Vishal Verma" <vishal.l.verma@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Dave Jiang" <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v6 5/8] cxl/mem: Trace Memory Module Event Record
Message-ID: <63c74767a8612_6f94429426@iweiny-mobl.notmuch>
References: <20221216-cxl-ev-log-v6-0-346583105b30@intel.com>
 <20221216-cxl-ev-log-v6-5-346583105b30@intel.com>
 <20230113124139.000034c0@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230113124139.000034c0@Huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yM2gTco4JsofnS90tcz58xJewoN2IW/IR5VIjYKLbVMviud5GftyxB2aBoUn?=
 =?us-ascii?Q?xv+hdXGN/s2xbOuc83pLeIYhCs5zSXnf1UIwSlr6wINXuB5SYXagHJbOEL7I?=
 =?us-ascii?Q?lE+AKq41aeCGsLEC1CbRKxxq4cQUH8U1NP0F0nWUsx6KgbEEr9xuXTOaeWwa?=
 =?us-ascii?Q?wbD1Bg/1C38s3Mx56+X+6XzamNcIqTlDJeQOk/1oBX7Z5SWb3fZIacVbMrdH?=
 =?us-ascii?Q?JdsI5rzNHDfuHWBiIHP8FIxjis3IrdY8DXJMjy4zDZ3WdEIuD8qkS+0UW8mR?=
 =?us-ascii?Q?mmIR+zHrQmWcS++LJ7LlAFtKNAoPAIwXONlqBnUBEIOOOJuNwj4Al8eQx+o0?=
 =?us-ascii?Q?9Zw/qglbm0mju0izGFU2yAe3TDf99H0hHd3UJ58amCw2EyUt4R+T/1W9GUB4?=
 =?us-ascii?Q?uB2yXNvUOWjteX/dP4vCYlnax+WLnjjg18I1qhFC1UD6PbajsQD/xNS6O54M?=
 =?us-ascii?Q?9VWWNeZeDE2ZX9twryGHZgnezH9xMM89Qo8cunV9vtsKok1nmHlhhlN26pPs?=
 =?us-ascii?Q?kYbXqGIOGojA4kfPvIMR8UEYKomkchUakiKEHgndFCBeDVCOrhoZz/XNQ6sy?=
 =?us-ascii?Q?CcL2+CPAMpib0c2rDskXWKMaO0G+LzfpMtiyd6Np0zHS9t5kyryhQsB9eKXj?=
 =?us-ascii?Q?ROmT3osRIbKd8gG4OCypHRmfbDXxooXUDBpQGLMZr5iQlpxC1dSvLKHRQWYw?=
 =?us-ascii?Q?Ye7pdzYo0zznX7UBVuo57SjRg9FDdLQpUrXNVCdNW2OzIcmMQvcR5/7PrH4l?=
 =?us-ascii?Q?OYd9m90QFHdE2ZoSdM4R7MXsCJOQKMECtknN+pHtIOITLzWPi5R4bIFYw6og?=
 =?us-ascii?Q?IOs1zdULjXs29C6RYWVDTJkQytTyntGn2STp3+ZgJ3XSXF1z+0yrkmQllwmc?=
 =?us-ascii?Q?JFWEOq17QQ2UD3CT1Q5bmg0ZtjSpV/Tva0+c5+Y5kcRlsQNYcLzbTrcNjwkv?=
 =?us-ascii?Q?S47YH3IfewP490kL4fMfuRcaSm8Msc1RiKNXb7l4e4cpYihTMsLhgIwG1DzF?=
 =?us-ascii?Q?mVXMNz/Sdr5ugeEDaew0EBizshmOfgRpEROpfpFJIbchHKZ9VZved/x0adxu?=
 =?us-ascii?Q?V+zMx8+RbZ0k3UFO8evF60mnvbicdJMh9t6IlGGFyNePGXZwli/0hFWixzGc?=
 =?us-ascii?Q?tRvcfPTkqM9v4UR3kxqb5aSmHhQSJyO3dML/lKV3Su1Lz05ix8dEMC+o2YG9?=
 =?us-ascii?Q?ybPwYuxyU4mNB6soDuwQD+8mUfz1aJnnKXsdf/v1nHsgfQhVjKTVtNjxEGYa?=
 =?us-ascii?Q?bcyVT6ETztAQqnzf8/pCXV/Z/HhDo70PKMZbzMJKdy/XDPEel9l4VQsCSRHw?=
 =?us-ascii?Q?p6hk4c6WtFB4THhe5k7l71TusdjrWQb5OxAfK0lHf8bFj3l9G1hqiKTtPT7O?=
 =?us-ascii?Q?DLT/PQQVDktt84yrOD314lPXAOR9SMvyjhT5ZvhLybo/dqENtfMTWbkwrNgj?=
 =?us-ascii?Q?S1M5OHEwv+ZB75NgMCTn2/RmuLWJYqIVd2ec84Z2gbhKbEEkQcqbiaXZNYM0?=
 =?us-ascii?Q?yAI02+7nEg1tlH8Pnk2MNS4shqsxnkuaEfnakLrpazSgnJ7LgxDio7xBSyFU?=
 =?us-ascii?Q?MyeMKO0G5dv91dz9KjIk1UB73LZv3AVCjtxs62Ul?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a076b76f-a612-465c-66dd-08daf8f10691
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 01:12:10.8751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJAaQpgz08tj9b6IvtsOeV3y92X0pRU/Xeo+KBz0rCzZET8c3YvsCHpfWH180h2TLlLysw67ghBXOeEusj7qyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5165
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jonathan Cameron wrote:
> On Mon, 09 Jan 2023 11:42:24 -0800
> Ira Weiny <ira.weiny@intel.com> wrote:
> 
> > CXL rev 3.0 section 8.2.9.2.1.3 defines the Memory Module Event Record.
> > 
> > Determine if the event read is memory module record and if so trace the
> > record.
> > 
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> Typo inline.  With that fixed
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> > index b6321cfb1d9f..ebb4c8ce8587 100644
> > --- a/drivers/cxl/core/trace.h
> > +++ b/drivers/cxl/core/trace.h
> > @@ -439,6 +439,149 @@ TRACE_EVENT(cxl_dram,
> >  	)
> >  );
> >  
> > +/*
> > + * Memory Module Event Record - MMER
> > + *
> > + * CXL res 3.0 section 8.2.9.2.1.3; Table 8-45
> > + */
> > +#define CXL_MMER_HEALTH_STATUS_CHANGE		0x00
> > +#define CXL_MMER_MEDIA_STATUS_CHANGE		0x01
> > +#define CXL_MMER_LIFE_USED_CHANGE		0x02
> > +#define CXL_MMER_TEMP_CHANGE			0x03
> > +#define CXL_MMER_DATA_PATH_ERROR		0x04
> > +#define CXL_MMER_LAS_ERROR			0x05
> 
> CXL_MMER_LSA_ERROR

Done.

Thanks,
Ira