Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4da45c6-7a04-c649-b841-ee1567c531ea@intel.com>
Date:   Tue, 17 Jan 2023 17:08:22 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH net-next 6/6] net: phy: Remove probe_capabilities
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Felix Fietkau <nbd@nbd.name>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        "Lorenzo Bianconi" <lorenzo@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Bryan Whitehead <bryan.whitehead@microchip.com>,
        <UNGLinuxDriver@microchip.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "Joel Stanley" <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-aspeed@lists.ozlabs.org>, Andrew Lunn <andrew@lunn.ch>
References: <20230116-net-next-remove-probe-capabilities-v1-0-5aa29738a023@walle.cc>
 <20230116-net-next-remove-probe-capabilities-v1-6-5aa29738a023@walle.cc>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230116-net-next-remove-probe-capabilities-v1-6-5aa29738a023@walle.cc>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1ZYMHVOdG1uWW1rdUVaSmU3MUlQQTFVdGQ1cmNpVVhFSkl0RWYvaWdWQmpL?=
 =?utf-8?B?ZXFiVDM5bUxCY015NUtHMUtpNVc3dDZkSnFySW5Vb3gxa0RNdG1BYlFjY0d2?=
 =?utf-8?B?K1ltcy92Ky9BbjdiSkdURUNuN0dNa2xMeENPOEZRaEFyV3cyRHpOT3RKc2ZW?=
 =?utf-8?B?bUpOeDRkUFV2MlNPZU4zK04zK1EwU1FSVHZsQ0YrRjR3TUszMjFrajhKYmVt?=
 =?utf-8?B?SDBuTGpsaXBiNXNManErdzl6aDUvVXI0bXBtRkZCWWxJZFBQYWo0ak02eDIr?=
 =?utf-8?B?bHJsTVpPTElxOFp1ZXZrRFVkeGw1N1JOOFE4cXFvTzhJc0V5N25wajBhTm5T?=
 =?utf-8?B?NWpPQnZNL09hd1htOW9SZkZmU2RRcW9FWkZ4Q2taR1orZjFXSGhSTUhETFlT?=
 =?utf-8?B?Z3lkYXhlS3NNMWFMSmEwMVVWbWNUUlJZUjRxdm9uOEZaNXlLZXhVQ0xDcS9j?=
 =?utf-8?B?VkM2b3JhYkZqNmRMVUVkc0VBaFRmRlRFTHRLcFZmSVZZalM2bUlQaS9tSVB0?=
 =?utf-8?B?aFhBV1o1VjRjTE0rbG5VazFZbEpJY0x4VUlwelcwSjVzbVYvbmQ2MVpjN0wv?=
 =?utf-8?B?M1p1dlVCMVFubi9RM21vckhxR3k5UHRUak1iNW1yOExZL1ltSlRkL0xSKzFE?=
 =?utf-8?B?dVo4TnFWc292Vld6ZS93bEczd0l6VTJhNVdtMHB3dlNMMU5XaVpJNENTMUNk?=
 =?utf-8?B?Y2I2VmRWMUk1VFhRLzZrQU9ETmdiOXNIMCtXTGJqY2tqbFNNdFc5Ulp3SElW?=
 =?utf-8?B?SnpFOE1EZWNTRVFNZ05aajcxUExqU01xMGh4OHFoa3FqV0pwYitnWWVsSld0?=
 =?utf-8?B?MTNNbGd0RnV6Mi9uYlRiSE1tOTJvNmJ5ZUpKM1MvNDNFcWI5eHpxUGtTUXZY?=
 =?utf-8?B?OU5MZHVTZVQ1WUJoWE5kU0tKVEpQUUdLWDJtVzB2L1dwbXQ5T1Q5TndWYmtI?=
 =?utf-8?B?UTlhc09iZHNqVkYxVTh0RjlUaTU0U2hSY01MWnJFSjRIWURlZ1NyajkrSjdx?=
 =?utf-8?B?TFpneTZXMitZK0oxa0FOMjA2cnRwOWsrWlEvZ3dya1pTTk5pY3I5N0NtbDhR?=
 =?utf-8?B?VkxobjB3VTMwaUlZVWhmRFZseDU4azRBYVpxbGpkYThjYjJLeUczYW5NSVFt?=
 =?utf-8?B?SnAvdXVFUCtrdTNJVkZmcVh0NlJCczlsaDFrOURoaGQyQjNleTNFbGVXeVhq?=
 =?utf-8?B?OEZtRjdoRkhMVmE0WWFtODRtMnFneStQY3BZMjVXNUw5TXVVaGM2Sjl3c2F6?=
 =?utf-8?B?TnhBQmd3YVROcE14NDlOYkcvTmtmUnhHd2hsTG9rZXJaaEtBZDFNMVkyekx2?=
 =?utf-8?B?dHlNMTFuQ3g2cUlPWENUM1NtbVFIbVJhN2FLU0E3THdhaUczaDBFbWhpVUYy?=
 =?utf-8?B?MnNDRVF3M01nOEtpN2NMWU14ZEZYbGE4VGFiQWpadlhEbTR2MWFLSmxOUDJM?=
 =?utf-8?B?alVGSDdoSUhVVC9GS1FwdXJoQTFVRTc1Q211SVBOR0M0SThZWG1wcGNXT01p?=
 =?utf-8?B?N3d5aGpWSkExMW9aK1YrVVE0U3h5K3lkSk45QTc4Tms0TTZYMHlxeW1rMlc1?=
 =?utf-8?B?NUlzOU9oLzF3QTBOcXpNL29URmtMQVJYNnB0dHdIdXl0M2ZTM0ZZYXNvSTZk?=
 =?utf-8?B?cXVreXpxemV0RDdGQ0dhWlRQbTZ3U0FDUVQ2eHd3WGM2anorMW1aUmFtbDBT?=
 =?utf-8?B?NUJ5TDF2aHZVQjVGelRBdFpOY0ZLZ050Y0x3UTRSWVNuTUFxT0F1LzhIaXEv?=
 =?utf-8?B?TzdhMzJ0OE16TDIrQUQ1Y2dheGFURUg4Nnp3dlViQzJvSGxOR2cvUEV4T0Jq?=
 =?utf-8?B?RldHZGRPS1Z1WkQyNDhTZ244S1hCZURpV3hlZEF4VVRYYUFwTVFaZDBlOFUw?=
 =?utf-8?B?Q1FCaGx4SFFtSDZFbXNnUExmaVVvSVBuV0lXQ3ZYRExYeGxhUnBiRXV0dUxR?=
 =?utf-8?B?R0p6QjhSbHhTOCtRSHhDVXZvZkREeHlaVUZWeTZLbXczdEE2djl4eVl1c0pu?=
 =?utf-8?B?NzFkclVoUDYvcUd6MkVpNGJEcjlmMEQ1Skg4bTB6cVA5a3QwSGJ4MHVYUXhT?=
 =?utf-8?B?L2tZSmUxVE5VcVRDMlNXbFdYWGpPRnZUVWtiZjlJR1FqZVNGWTFITE90Z3FZ?=
 =?utf-8?B?aWhLdzFiL3JHVGxyTk5RcVJsYjhUQU5XYWhYMnJyMjk5dW4zMzNVRHZDR2NT?=
 =?utf-8?B?VXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f41409b-07b1-4ac2-a490-08daf8f0806b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 01:08:25.8285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WqvOP9mwc0ZA32oOqMD6Rm5StMbcAPajqBOpNQArS/HPad6/4prmsQ89lHP0/lXeIiLM4fIB5fX3m9tg1ixtJrksr2Ucdvpjq8qJUoX71vM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8126
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/16/2023 4:55 AM, Michael Walle wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> 
> Deciding if to probe of PHYs using C45 is now determine by if the bus
> provides the C45 read method. This makes probe_capabilities redundant
> so remove it.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Michael Walle <michael@walle.cc>
...

> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index fceaac0fb319..fbeba4fee8d4 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -419,14 +419,6 @@ struct mii_bus {
>   	/** @reset_gpiod: Reset GPIO descriptor pointer */
>   	struct gpio_desc *reset_gpiod;
>   
> -	/** @probe_capabilities: bus capabilities, used for probing */
> -	enum {
> -		MDIOBUS_NO_CAP = 0,
> -		MDIOBUS_C22,
> -		MDIOBUS_C45,
> -		MDIOBUS_C22_C45,
> -	} probe_capabilities;
> -

I'm a little surprised there is no Documentation regarding this stuff, 
that needs to be removed or fixed up, but since there isn't...

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>