Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
CC:     Kalle Valo <kvalo@kernel.org>, Leon Romanovsky <leonro@nvidia.com>,
        "Marc Zyngier" <maz@kernel.org>, Omri Barazi <obarazi@nvidia.com>
Subject: RE: [PATCH rc v2] genirq/msi: Free the fwnode created by
 msi_create_device_irq_domain()
Thread-Topic: [PATCH rc v2] genirq/msi: Free the fwnode created by
 msi_create_device_irq_domain()
Thread-Index: AQHZKqg2sgLjLoNnj0W+ZNaDXErwGq6jYa+w
Date:   Wed, 18 Jan 2023 01:24:06 +0000
Message-ID: <BN9PR11MB527661A8F2B8CF80F03CD13C8CC79@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <0-v2-24af6665e2da+c9-msi_leak_jgg@nvidia.com>
In-Reply-To: <0-v2-24af6665e2da+c9-msi_leak_jgg@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L08rbqiOLRTWlqGV5a6VLMhqnEtac0QkddGQY1UPTz7Qidio+42yo1cstFVb?=
 =?us-ascii?Q?SgixA+3WuuICjeZQTI3+63ZXURZjgTwarVlUgXhqhyc6Brs4IGZi9El3tA2x?=
 =?us-ascii?Q?yDpBsgSXep68tCr6F0Nj7q0pptmhfVfhlQA2j1DOsBkUiPwizAraVcr5oL9s?=
 =?us-ascii?Q?swcDtoqEICsPD9dX3hl77TyRBBlvx0lvmsEwYOjZe7M8+ZlkXG6F8kDif/oP?=
 =?us-ascii?Q?VIBLH+nhInPlFSzv1YBjvDGelnXZ3NR2KmeO4b1Ek86UsN/Niou5S2tSmUO8?=
 =?us-ascii?Q?rNfcwNZHyQ1Abs2xS8jH0xf7/091otyVTqJX5PJqL+9OLbbuLiaSTUUtw+Lv?=
 =?us-ascii?Q?PaGbo6QPHN8OLmRXDyO2JlTVyA9mDf+zM49TEeSeIR0vX1GMb9gJ2IW5pRV1?=
 =?us-ascii?Q?luA+u/hX9Fx3K/pVvQnb/7+ogpk5tA7HLXNnES0eBZg26LFqgw9Rz53AzyJt?=
 =?us-ascii?Q?7z0nFEat0ny94yqrmtkEZgPcN9IR+eHeZWplIjDedqt4XkONNECC7erE3MVI?=
 =?us-ascii?Q?GznSyQK9ic6Q5Qsfkd3htZBy3+JXq0Kv/0FYWOno7lFPFnvuvFFWp+fE12ly?=
 =?us-ascii?Q?IC5ezwciSGUlzQbOM2hqUTeXBZaN0KLnViTa2pTNLB4ivT9H4kgAelVLtOTN?=
 =?us-ascii?Q?k/eP+UXSlAQn6raqlPZ0sQS7wMeEXFVM/jzJwITYElcGmAmQaRGHsvtOgGks?=
 =?us-ascii?Q?tjwxZb+gWJdizSwNACoou6qOK+ZUpy9KCPVb8NS/buhnOYTpJsFmJd6/m3JV?=
 =?us-ascii?Q?j1lG0lawTJr5nbxZpVTB7ndw9LJ3xXiNLvMQcIsEptJtllsRMdoX1JNFYcgr?=
 =?us-ascii?Q?h1RYwsDTZyuP95Wm4lae6vO57wT2/3q7pftvcMk0Yp5OCixwCn9gHGsDYIxH?=
 =?us-ascii?Q?DN1FRXRkW34Swa3/IW1VTqXJrUX9SS9MLUNiF80JUgTPlNbcRQ6cPtVAr5Fe?=
 =?us-ascii?Q?sJsgI9p8jtgj1ZzdiK3OxmwHX2GbR1S76V6potr3QRVA3yVfq7Y4pbpZTag3?=
 =?us-ascii?Q?QqBr3aaJMoYaRYJAYHxToAw4iOyJcadmxKdKw34BNF8SropU7f4tFuwLYcSB?=
 =?us-ascii?Q?qRlwtQwITiWaomhqBi9yG74aKpsPvLXxRHaNPgeS461Yg6YAXOj/ynbqdPLu?=
 =?us-ascii?Q?EVgfa7wnbiAIuJFDiGh1kPSBuowqFgdvARBv72cEgPuyXdmy0WZZ4/ck0FmX?=
 =?us-ascii?Q?UNwHFgIV8E/wOvs3RliLDYzPhcOjv4GMoYyF3y9ZU5G9nMZIjlF8P9k4dLhs?=
 =?us-ascii?Q?bKUXqKvW9SNtJExikpUT0TJtN56Lm0azvxV9UKnMrOlPl7y6nkAQl9QQB38c?=
 =?us-ascii?Q?zQ45LBBA2dGeDJ6r0puMjlXlEjKvrRVbGc9j/XRtsd3zA8j0EMTX3xNB0+sg?=
 =?us-ascii?Q?KGRxpMxczjPzl+/W5vkG2qBMImg4CakXYbVKfdpN6i8iSJopTSobUpi/kpx4?=
 =?us-ascii?Q?NfPXXqLGcI8WjJQaIi31/FEi34JBfPFh0RmPL3AZL+qv8JWjnaWj5gRDZnZF?=
 =?us-ascii?Q?/DncJeeuPBpVNngdYTKPa2bi8tulfQ0iGRpMHRj/IbpA7GmZVMxcz0U8q/Xq?=
 =?us-ascii?Q?mFBr+BTt/2nQ54S8tAd/Vb3apEDAiR5rSeETTNpw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 028c99fc-33d4-418e-9d1a-08daf8f2b0ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 01:24:06.0326
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1PjwictO9oPlmtSqZLzKT8x3egy9IbgGJGGbzUpOd6VfXwaHRTWoV8agQy9inIrg08qNnbcFuQyY0NbbKnnlTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7334
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, January 18, 2023 3:16 AM
>=20
> msi_create_device_irq_domain creates a fwnode for the new domain, but it
> is never freed. kmemleak reports:
>=20
> unreferenced object 0xffff888120ba9a00 (size 96):
>   comm "systemd-modules", pid 221, jiffies 4294893411 (age 635.732s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 e0 19 8b 83 ff ff ff ff  ................
>     00 00 00 00 00 00 00 00 18 9a ba 20 81 88 ff ff  ........... ....
>   backtrace:
>     [<00000000bcb7f3b1>] kmalloc_trace+0x27/0x110
>     [<000000008cdbc98d>] __irq_domain_alloc_fwnode+0x51/0x2b0
>     [<00000000c57acf9d>] msi_create_device_irq_domain+0x283/0x670
>     [<000000009b567982>] __pci_enable_msix_range+0x49e/0xdb0
>     [<0000000077cc1445>] pci_alloc_irq_vectors_affinity+0x11f/0x1c0
>     [<00000000532e9ef5>] mlx5_irq_table_create+0x24c/0x940 [mlx5_core]
>     [<00000000fabd2b80>] mlx5_load+0x1fa/0x680 [mlx5_core]
>     [<000000006bb22ae4>] mlx5_init_one+0x485/0x670 [mlx5_core]
>     [<00000000eaa5e1ad>] probe_one+0x4c2/0x720 [mlx5_core]
>     [<00000000df8efb43>] local_pci_probe+0xd6/0x170
>     [<0000000085cb9924>] pci_device_probe+0x231/0x6e0
>     [<000000002671d86e>] really_probe+0x1cf/0xaa0
>     [<000000002aeba218>] __driver_probe_device+0x18f/0x470
>     [<000000002aec9527>] driver_probe_device+0x49/0x120
>     [<000000005f45a989>] __driver_attach+0x1ff/0x4a0
>     [<0000000000dcaab2>] bus_for_each_dev+0x11e/0x1a0
>=20
> Use the proper free operation for the fwnode so the name is freed during
> error unwind of msi_create_device_irq_domain() and free the fwnode in
> msi_remove_device_irq_domain() if it was automatically allocated.
>=20
> Make irq_domain_free_fwnode() tolerant of NULL.
>=20
> Fixes: 27a6dea3ebaa ("genirq/msi: Provide
> msi_create/free_device_irq_domain()")
> Reported-by: Omri Barazi <obarazi@nvidia.com>
> Tested-by: Kalle Valo <kvalo@kernel.org>
> Tested-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>