Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5773052rwb; Tue, 17 Jan 2023 18:57:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXvPsS9/FF+q2aD681x4Wkx++UPiSjkvQbanN+Joj+s1BSraQCkjxZ8qiGoqJx2rOnBkvZus X-Received: by 2002:a17:906:1c55:b0:7c0:1db5:ea10 with SMTP id l21-20020a1709061c5500b007c01db5ea10mr5263522ejg.53.1674010627985; Tue, 17 Jan 2023 18:57:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674010627; cv=none; d=google.com; s=arc-20160816; b=eXm4ETUIWK8HEXOIzbKecy38CK5B7c+xMZDQnPyyStchL5CUHshCHzH8W8hP+jT9r4 p4PIRK8LOYoeFdw/AwLqSgoNY+rslB4fyVIMb94TI711kLNqfeCUiVtg3QgDmPwoqU81 ncnElQ5jJkyWW260AsmeudgElEoANAuG5MQ61m2Q2bMY3R4GmMG0k4X1SDDA9mH5Z4fg p2pBmwvFlkiOaxfUiuQvEVxVJHQPCFkr1lUleCg7OUNH/P7o4XhG1tmDeFyhBRQAMn4S DzgnNez2khuQhJTk4OSqM0QpTyvwV+MAzM7bb5oUmgaNVcOrkwFxoTCNcAkUhejOkJsS /lhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=qBPrKwbmxe962ucy42kYQQrevNx/Al3WSamK/raQgSw=; b=mwHU+yffR0kkbIQ5D39IdrgedHc1j/4NHN8Of3xOTMipOWE82k9x482EFdcO2YCIZp huEiFqwVLJRMYEaIPzK4EAkuHAVUSQibKoDCCWqsUxVQtKImgN/tGRvM5PbPRcuYQh4w nbGCHx5LA+Nb5soZLgqjvuEBZVLWRkG7pPkVq/iF4RjCnMRkGO6POcvFwMRvoo6qXftv WMsPc5y9XvHEzPe1cM6ctpN8RB92OzEtDeS58FMYLw3tXWcxUfdEj4il+jz5xPsdSOpl LblkLvXv4cQ8+fS4a0kLMBdUyDyYP6ROB3iK8whVLgxyPSzb+ZoVzLziZFjjRLy4P9eV wtCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QSr0XH3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a1709065d0e00b0086b5808d6b4si18822037ejt.717.2023.01.17.18.56.56; Tue, 17 Jan 2023 18:57:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QSr0XH3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbjARCh1 (ORCPT + 46 others); Tue, 17 Jan 2023 21:37:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjARChW (ORCPT ); Tue, 17 Jan 2023 21:37:22 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A7364FAE3 for ; Tue, 17 Jan 2023 18:37:21 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id c6so35514698pls.4 for ; Tue, 17 Jan 2023 18:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qBPrKwbmxe962ucy42kYQQrevNx/Al3WSamK/raQgSw=; b=QSr0XH3SuVkoN4QoDKyTXrefqLzKMmCUWT8ZRKCBWKsokMlQsXD8CYP5oOIr6EPJex eFz0Lk8HWYHukDF+zYH7ENPSdO8sC/3ZzUg/EakXzkI9VlSIM8MaQ1OPgBf34ubKCUvt vIXnUQAGM2sWMGN3XEZ1l9j5gBHzi0kOS+O82cUm0G6XtRjVawCZ68vS9ERHFr4YCowT zQOKTBrcD3Nhh39badSPeFeQe7ftyIUnom6nhV2cAlmPpKVRdQdK+lc55c8ythsj+lKg +MtawndcdeM+LDZp4zZyUuJnSdX6WlUJiXBy39G4q/z8YACblaXbazTja/f1/RWCzKyI kgAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qBPrKwbmxe962ucy42kYQQrevNx/Al3WSamK/raQgSw=; b=lj1YhfJuClETiMIh3whEgTs7CpqrkQu7uMZL0mmeP5/RnZah3Wbh+ejvwHTYLwK9e/ 1wbzeOIEJ558GoYhb4KLo1oima+bGTNfQMXWg6hKGPKFOfw58wcEgPrnI8MLDJxXtMMz BJVwdHsK2N3alVRX0DPjOqHOnZiaSZQG4sM6DF+dV0tPHMwKzLY8HE66dGvzPZT/BPLk Rx5gpCaxFdRCnA9Ck7owx43V8hzn0SV9Ppc47trDaW5Y2pQWMPyd9YM/ZGP7ibNe1y9u ZCFS2BTJVqEvrSZ75b9rD03nvOFlrYGGDK73WRC8u+dU3tXXdEh6EUnJQvOGZ2hSYQHN dxkg== X-Gm-Message-State: AFqh2kpmZnoiog1QYpvbg3ipLlvhFFdslt07/c3Q45i7ZUzWo64sj4T5 zUcMyQ/z+iMPxaNwKFKsdQCfBsD0kktdBB24mgU= X-Received: by 2002:a17:902:8492:b0:192:f45e:e749 with SMTP id c18-20020a170902849200b00192f45ee749mr510414plo.71.1674009440548; Tue, 17 Jan 2023 18:37:20 -0800 (PST) MIME-Version: 1.0 References: <20230112090603.1295340-1-guoren@kernel.org> <20230112090603.1295340-7-guoren@kernel.org> <1514c929-5a98-0e58-e038-9bb4537d5189@yadro.com> <7c85f9d8-458d-6881-ffbe-4f5c6384e35e@yadro.com> In-Reply-To: <7c85f9d8-458d-6881-ffbe-4f5c6384e35e@yadro.com> From: Song Shuai Date: Wed, 18 Jan 2023 02:37:09 +0000 Message-ID: Subject: Re: [PATCH -next V7 6/7] samples: ftrace: Add riscv support for SAMPLE_FTRACE_DIRECT[_MULTI] To: Evgenii Shatokhin , guoren@kernel.org Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, heiko@sntech.de, rostedt@goodmis.org, mhiramat@kernel.org, jolsa@redhat.com, bp@suse.de, jpoimboe@kernel.org, andy.chiu@sifive.com, linux@yadro.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Evgenii Shatokhin =E4=BA=8E2023=E5=B9=B41=E6=9C=881= 7=E6=97=A5=E5=91=A8=E4=BA=8C 16:22=E5=86=99=E9=81=93=EF=BC=9A > > On 17.01.2023 16:16, Evgenii Shatokhin wrote: > > Hi, Song, > > > > On 17.01.2023 12:32, Song Shuai wrote: > >> > >> Hi, Evgenii: > >> > >> Evgenii Shatokhin =E4=BA=8E2023=E5=B9=B41=E6= =9C=8816=E6=97=A5=E5=91=A8=E4=B8=80 14:30=E5=86=99=E9=81=93=EF=BC=9A > >> > >>> > >>> Hi, > >>> > >>> On 12.01.2023 12:06, guoren@kernel.org wrote: > >>>> From: Song Shuai > >>>> > >>>> select HAVE_SAMPLE_FTRACE_DIRECT and HAVE_SAMPLE_FTRACE_DIRECT_MULTI > >>>> for ARCH_RV64I in arch/riscv/Kconfig. And add riscv asm code for > >>>> the ftrace-direct*.c files in samples/ftrace/. > >>>> > >>>> Signed-off-by: Song Shuai > >>>> Tested-by: Guo Ren > >>>> Signed-off-by: Guo Ren > >>>> --- > >>>> arch/riscv/Kconfig | 2 ++ > >>>> samples/ftrace/ftrace-direct-modify.c | 33 ++++++++++++++++= ++ > >>>> samples/ftrace/ftrace-direct-multi-modify.c | 37 > >>>> +++++++++++++++++++++ > >>>> samples/ftrace/ftrace-direct-multi.c | 22 ++++++++++++ > >>>> samples/ftrace/ftrace-direct-too.c | 26 +++++++++++++++ > >>>> samples/ftrace/ftrace-direct.c | 22 ++++++++++++ > >>>> 6 files changed, 142 insertions(+) > >>> > >>> The samples were built OK now, but ftrace-direct-multi and > >>> ftrace-direct-multi-modify report incorrect values of ip/pc it seems. > >>> > >>> I ran 'insmod ftrace-direct-multi.ko', waited a little and then check= ed > >>> the messages in the trace: > >>> > >>> # TASK-PID CPU# ||||| TIMESTAMP FUNCTION > >>> # | | | ||||| | | > >>> migration/1-19 [001] ..... 3858.532131: my_direct_func1:= my > >>> direct func1 ip 0 > >>> migration/0-15 [000] d.s2. 3858.532136: my_direct_func1:= my > >>> direct func1 ip ff60000001ba9600 > >>> migration/0-15 [000] d..2. 3858.532204: my_direct_func1:= my > >>> direct func1 ip ff60000003334d00 > >>> migration/0-15 [000] ..... 3858.532232: my_direct_func1:= my > >>> direct func1 ip 0 > >>> rcu_sched-14 [001] ..... 3858.532257: my_direct_func1:= my > >>> direct func1 ip 0 > >>> insmod-415 [000] ..... 3858.532270: my_direct_func1:= my > >>> direct func1 ip 7fffffffffffffff > >>> -0 [001] ..s1. 3858.539051: my_direct_func1:= my > >>> direct func1 ip ff60000001ba9600 > >>> -0 [001] dns2. 3858.539124: my_direct_func1:= my > >>> direct func1 ip ff60000001ba9600 > >>> rcu_sched-14 [001] ..... 3858.539208: my_direct_func1:= my > >>> direct func1 ip 0 > >>> [...] > >>> > >>> If I understand it right, my_direct_func1() should print the address = of > >>> some location in the code, probably - at the beginning of the traced > >>> functions. > >>> > >>> The printed values (0x0, 0x7fffffffffffffff, ...) are not valid code > >>> addresses. > >>> > >> The invalid code address is only printed by accessing the schedule() > >> function's first argument whose address stores in a0 register. > >> While schedule() actually has no parameter declared, so my_direct_func > >> just prints the a0 in the context of the schedule()'s caller and > >> the address maybe varies depending on the caller. > >> > >> I can't really understand why tracing the first argument of the > >> schedule() function, but it seems nonsense at this point. > > > > The question is, what should be passed as the argument(s) of > > my_direct_func() in this particular sample module. The kernel docs and > > commit logs seem to contain no info on that. > > > > With direct functions, I suppose, the trampoline can pass anything it > > wants to my_direct_func(), not just the arguments of the traced functio= n. > > > > I'd check what these sample modules do on x86 and would try to match > > that behaviour on RISC-V. > > I have checked ftrace-direct-multi.ko and ftrace-direct-multi-modify.ko > on 6.2-rc4 built for x86-64 - yes, ip/pc in the traced function should > be passed to my_direct_func(). > > ftrace-direct-multi.ko: > # TASK-PID CPU# ||||| TIMESTAMP FUNCTION > # | | | ||||| | | > insmod-10829 [000] d.h1. 1719.518535: my_direct_func: ip > ffffffff87332f45 // wake_up_process+0x5 > rcu_tasks_kthre-11 [000] ..... 1719.518696: my_direct_func: ip > ffffffff8828d935 // schedule+0x5 > insmod-10829 [000] ..... 1719.518708: my_direct_func: ip > ffffffff8828d935 > systemd-journal-293 [001] ..... 1719.518823: my_direct_func: ip > ffffffff8828d935 > systemd-1 [000] ..... 1719.519141: my_direct_func: ip > ffffffff8828d935 > -0 [001] ..s1. 1719.521889: my_direct_func: ip > ffffffff87332f45 > -0 [000] d.s2. 1719.521901: my_direct_func: ip > ffffffff87332f45 > rcu_preempt-15 [001] ..... 1719.521917: my_direct_func: ip > ffffffff8828d935 > [...] > > The ip values are wake_up_process+0x5 and schedule+0x5, the locations > where the execution of the traced functions resumes after the Ftrace > trampoline has finished. > > The results with ftrace-direct-multi-modify.ko are similar to that. > > The samples look like a demonstration, that one can pass anything > necessary to the handler in case of "direct" functions. > > I suppose, the RISC-V-specific asm code in these two sample modules > could be updated to pass the saved pc value to my_direct_func() in a0. Yes, you're right. I added 'mv a0,t0' in front of `call my_direct_func` to pass the address of traced function with mcount offset. Here is the updated patch for your reference. https://github.com/sugarfillet/linux/commit/95b174fb104dd970b982ee6fa198793= 93e229318 > > > > >> > >> As for this patch, it just impls a simple mcount (direct_caller) to > >> trace kernel functions, and basically saves the necessary ABI, > >> call the tracing function, and restores the ABI, just like other > >> arches do. > >> so It shouldn't be blamed. > >> > >> I started an independent patch to replace schedule with kick_process > >> to make these samples more reasonable. And It has no conflict with the > >> current patch, so we can go on. > >> > >> Link: > >> https://lore.kernel.org/linux-kernel/20230117091101.3669996-1-suagrfil= let@gmail.com/T/#u > >> > >>> The same issue is with ftrace-direct-multi-modify.ko. > >>> > >>> Is anything missing here? > >>> > >>>> > >>>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > >>>> index 307a9f413edd..e944af44f681 100644 > >>>> --- a/arch/riscv/Kconfig > >>>> +++ b/arch/riscv/Kconfig > >>>> @@ -112,6 +112,8 @@ config RISCV > >>>> select HAVE_POSIX_CPU_TIMERS_TASK_WORK > >>>> select HAVE_REGS_AND_STACK_ACCESS_API > >>>> select HAVE_FUNCTION_ARG_ACCESS_API > >>>> + select HAVE_SAMPLE_FTRACE_DIRECT > >>>> + select HAVE_SAMPLE_FTRACE_DIRECT_MULTI > >>>> select HAVE_STACKPROTECTOR > >>>> select HAVE_SYSCALL_TRACEPOINTS > >>>> select HAVE_RSEQ > >>>> diff --git a/samples/ftrace/ftrace-direct-modify.c > >>>> b/samples/ftrace/ftrace-direct-modify.c > >>>> index de5a0f67f320..be7bf472c3c7 100644 > >>>> --- a/samples/ftrace/ftrace-direct-modify.c > >>>> +++ b/samples/ftrace/ftrace-direct-modify.c > >>>> @@ -23,6 +23,39 @@ extern void my_tramp2(void *); > >>>> > >>>> static unsigned long my_ip =3D (unsigned long)schedule; > >>>> > >>>> +#ifdef CONFIG_RISCV > >>>> + > >>>> +asm (" .pushsection .text, \"ax\", @progbits\n" > >>>> +" .type my_tramp1, @function\n" > >>>> +" .globl my_tramp1\n" > >>>> +" my_tramp1:\n" > >>>> +" addi sp,sp,-16\n" > >>>> +" sd t0,0(sp)\n" > >>>> +" sd ra,8(sp)\n" > >>>> +" call my_direct_func1\n" > >>>> +" ld t0,0(sp)\n" > >>>> +" ld ra,8(sp)\n" > >>>> +" addi sp,sp,16\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp1, .-my_tramp1\n" > >>>> + > >>>> +" .type my_tramp2, @function\n" > >>>> +" .globl my_tramp2\n" > >>>> +" my_tramp2:\n" > >>>> +" addi sp,sp,-16\n" > >>>> +" sd t0,0(sp)\n" > >>>> +" sd ra,8(sp)\n" > >>>> +" call my_direct_func2\n" > >>>> +" ld t0,0(sp)\n" > >>>> +" ld ra,8(sp)\n" > >>>> +" addi sp,sp,16\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp2, .-my_tramp2\n" > >>>> +" .popsection\n" > >>>> +); > >>>> + > >>>> +#endif /* CONFIG_RISCV */ > >>>> + > >>>> #ifdef CONFIG_X86_64 > >>>> > >>>> #include > >>>> diff --git a/samples/ftrace/ftrace-direct-multi-modify.c > >>>> b/samples/ftrace/ftrace-direct-multi-modify.c > >>>> index d52370cad0b6..10884bf418f7 100644 > >>>> --- a/samples/ftrace/ftrace-direct-multi-modify.c > >>>> +++ b/samples/ftrace/ftrace-direct-multi-modify.c > >>>> @@ -21,6 +21,43 @@ void my_direct_func2(unsigned long ip) > >>>> extern void my_tramp1(void *); > >>>> extern void my_tramp2(void *); > >>>> > >>>> +#ifdef CONFIG_RISCV > >>>> + > >>>> +asm (" .pushsection .text, \"ax\", @progbits\n" > >>>> +" .type my_tramp1, @function\n" > >>>> +" .globl my_tramp1\n" > >>>> +" my_tramp1:\n" > >>>> +" addi sp,sp,-24\n" > >>>> +" sd a0,0(sp)\n" > >>>> +" sd t0,8(sp)\n" > >>>> +" sd ra,16(sp)\n" > >>>> +" call my_direct_func1\n" > >>>> +" ld a0,0(sp)\n" > >>>> +" ld t0,8(sp)\n" > >>>> +" ld ra,16(sp)\n" > >>>> +" addi sp,sp,24\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp1, .-my_tramp1\n" > >>>> + > >>>> +" .type my_tramp2, @function\n" > >>>> +" .globl my_tramp2\n" > >>>> +" my_tramp2:\n" > >>>> +" addi sp,sp,-24\n" > >>>> +" sd a0,0(sp)\n" > >>>> +" sd t0,8(sp)\n" > >>>> +" sd ra,16(sp)\n" > >>>> +" call my_direct_func2\n" > >>>> +" ld a0,0(sp)\n" > >>>> +" ld t0,8(sp)\n" > >>>> +" ld ra,16(sp)\n" > >>>> +" addi sp,sp,24\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp2, .-my_tramp2\n" > >>>> +" .popsection\n" > >>>> +); > >>>> + > >>>> +#endif /* CONFIG_RISCV */ > >>>> + > >>>> #ifdef CONFIG_X86_64 > >>>> > >>>> #include > >>>> diff --git a/samples/ftrace/ftrace-direct-multi.c > >>>> b/samples/ftrace/ftrace-direct-multi.c > >>>> index ec1088922517..a35bf43bf6d7 100644 > >>>> --- a/samples/ftrace/ftrace-direct-multi.c > >>>> +++ b/samples/ftrace/ftrace-direct-multi.c > >>>> @@ -16,6 +16,28 @@ void my_direct_func(unsigned long ip) > >>>> > >>>> extern void my_tramp(void *); > >>>> > >>>> +#ifdef CONFIG_RISCV > >>>> + > >>>> +asm (" .pushsection .text, \"ax\", @progbits\n" > >>>> +" .type my_tramp, @function\n" > >>>> +" .globl my_tramp\n" > >>>> +" my_tramp:\n" > >>>> +" addi sp,sp,-24\n" > >>>> +" sd a0,0(sp)\n" > >>>> +" sd t0,8(sp)\n" > >>>> +" sd ra,16(sp)\n" > >>>> +" call my_direct_func\n" > >>>> +" ld a0,0(sp)\n" > >>>> +" ld t0,8(sp)\n" > >>>> +" ld ra,16(sp)\n" > >>>> +" addi sp,sp,24\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp, .-my_tramp\n" > >>>> +" .popsection\n" > >>>> +); > >>>> + > >>>> +#endif /* CONFIG_RISCV */ > >>>> + > >>>> #ifdef CONFIG_X86_64 > >>>> > >>>> #include > >>>> diff --git a/samples/ftrace/ftrace-direct-too.c > >>>> b/samples/ftrace/ftrace-direct-too.c > >>>> index e13fb59a2b47..3b62e33c2e6d 100644 > >>>> --- a/samples/ftrace/ftrace-direct-too.c > >>>> +++ b/samples/ftrace/ftrace-direct-too.c > >>>> @@ -18,6 +18,32 @@ void my_direct_func(struct vm_area_struct *vma, > >>>> > >>>> extern void my_tramp(void *); > >>>> > >>>> +#ifdef CONFIG_RISCV > >>>> + > >>>> +asm (" .pushsection .text, \"ax\", @progbits\n" > >>>> +" .type my_tramp, @function\n" > >>>> +" .globl my_tramp\n" > >>>> +" my_tramp:\n" > >>>> +" addi sp,sp,-40\n" > >>>> +" sd a0,0(sp)\n" > >>>> +" sd a1,8(sp)\n" > >>>> +" sd a2,16(sp)\n" > >>>> +" sd t0,24(sp)\n" > >>>> +" sd ra,32(sp)\n" > >>>> +" call my_direct_func\n" > >>>> +" ld a0,0(sp)\n" > >>>> +" ld a1,8(sp)\n" > >>>> +" ld a2,16(sp)\n" > >>>> +" ld t0,24(sp)\n" > >>>> +" ld ra,32(sp)\n" > >>>> +" addi sp,sp,40\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp, .-my_tramp\n" > >>>> +" .popsection\n" > >>>> +); > >>>> + > >>>> +#endif /* CONFIG_RISCV */ > >>>> + > >>>> #ifdef CONFIG_X86_64 > >>>> > >>>> #include > >>>> diff --git a/samples/ftrace/ftrace-direct.c > >>>> b/samples/ftrace/ftrace-direct.c > >>>> index 1f769d0db20f..2cfe5a7d2d70 100644 > >>>> --- a/samples/ftrace/ftrace-direct.c > >>>> +++ b/samples/ftrace/ftrace-direct.c > >>>> @@ -15,6 +15,28 @@ void my_direct_func(struct task_struct *p) > >>>> > >>>> extern void my_tramp(void *); > >>>> > >>>> +#ifdef CONFIG_RISCV > >>>> + > >>>> +asm (" .pushsection .text, \"ax\", @progbits\n" > >>>> +" .type my_tramp, @function\n" > >>>> +" .globl my_tramp\n" > >>>> +" my_tramp:\n" > >>>> +" addi sp,sp,-24\n" > >>>> +" sd a0,0(sp)\n" > >>>> +" sd t0,8(sp)\n" > >>>> +" sd ra,16(sp)\n" > >>>> +" call my_direct_func\n" > >>>> +" ld a0,0(sp)\n" > >>>> +" ld t0,8(sp)\n" > >>>> +" ld ra,16(sp)\n" > >>>> +" addi sp,sp,24\n" > >>>> +" jr t0\n" > >>>> +" .size my_tramp, .-my_tramp\n" > >>>> +" .popsection\n" > >>>> +); > >>>> + > >>>> +#endif /* CONFIG_RISCV */ > >>>> + > >>>> #ifdef CONFIG_X86_64 > >>>> > >>>> #include > >>>> -- > >>>> 2.36.1 > >> > >> -- > >> Thanks, > >> Song > >> > > > > Regards, > > Evgenii > > --=20 Thanks, Song