Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5818444rwb; Tue, 17 Jan 2023 19:44:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXsHu7lvRWpeiyyTqI5lS0cTbKIF6iq+KhY+CGROd7g7B7LnvRwW496tUDpsbyfMaZeh7ssV X-Received: by 2002:a17:903:41d2:b0:189:361f:89ac with SMTP id u18-20020a17090341d200b00189361f89acmr8133518ple.64.1674013445777; Tue, 17 Jan 2023 19:44:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674013445; cv=none; d=google.com; s=arc-20160816; b=gzQ3ocje8zyKK8+d4DVqaMtI4hlF6Yv6NsQRsEAMXpcvDnjnOmVQje5lkXSsOEbKsQ NmpnpDwQKAZt302SCRaExSOBEIThN3RMVKxNZQXNKN9ucKirvk4gMfXdhg2KiqYsk63D x+1rRQXHdoG5uFp5pvaBuojHW2zcYNvagx+zLhYVxL/UxQfqbg/sJjf+1Gjqrbc2jQ2v VBELPwk3BMog/5jxGkygk6jNsl5c9f7M2+3nWN3qA9bnKa1kl761xuTRlWXb0BLW5+8o MrgHAhSs0Lhn52KJzrtl5cxV34retpopYLG2md2eTKuia750RNpvgFKnYY5F90lhgrRk cHug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lEXuUIt0mClMwmoPZgnVCsaq7D1YfOqGnkYIDUFXU1U=; b=QVymJC5dnXdw4iLQgATjR69gTyAEaGrOGzHyoCngev67E7NENTorAfzzLZjpkg9keR bblggJ/Ou8dI1bVePFuuF1FVv360az8LUnnAGWLVv1Kc2K0eHzzIoh6asuNmuqppeJ3M COvoE2lgoo6uEZFek43GRgGYM4hVhfOCHULcd4C8L81gfniu+yOijC25Lzsk6dUV2NdQ kOk/Co41FKwcTiLmkQvitzTrfX+Y2BacPLUde/JQv7F9/VMEJW1+AZwAd6IZ03vCl3f1 qO795D/bXJinPv1H4vMbXy105ohrrKlt5M5HMKJqYw9hvF0EPHbZQpIZEfREPAW/yfoA WaFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y16-20020a170902b49000b0019295a19dc8si11147410plr.468.2023.01.17.19.44.00; Tue, 17 Jan 2023 19:44:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229509AbjARDYb (ORCPT + 46 others); Tue, 17 Jan 2023 22:24:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjARDY3 (ORCPT ); Tue, 17 Jan 2023 22:24:29 -0500 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F225A4FCD8 for ; Tue, 17 Jan 2023 19:24:27 -0800 (PST) Received: from localhost.localdomain (unknown [124.16.138.125]) by APP-05 (Coremail) with SMTP id zQCowACHjelgZsdjDF2pAA--.36255S2; Wed, 18 Jan 2023 11:24:17 +0800 (CST) From: Jiasheng Jiang To: daniel@ffwll.ch Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: Re: [PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue() Date: Wed, 18 Jan 2023 11:24:13 +0800 Message-Id: <20230118032413.6496-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowACHjelgZsdjDF2pAA--.36255S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtw1DCF47Xr15GF1xZw4fXwb_yoWkZrb_GF 9YgrnrWw4UGr1093Z7Jr1jqa4Ivr48Ar1jgayrX3s3try2qFWrXanrCrsav34fWws5CFsx uFyqgayavr9FgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbz8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw2 0EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x02 67AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-Originating-IP: [124.16.138.125] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, Jan 10, 2023 at 11:24:47PM +0800, Jiasheng Jiang wrote: >> Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers >> that provide managed workqueue cleanup. The workqueue will be destroyed >> with the final reference of the DRM device. >> >> Signed-off-by: Jiasheng Jiang > > Yeah I think this looks nice. > > Reviewed-by: Daniel Vetter > > I'm assuming driver maintainers will pick this up, if not please holler. > > Also the threading seems broken, it's not a patch series. The b4 tool or > git send-email (of all the patches of the entire series at once, not each > individually) should get this right. > > Unfortunately I did't find the right link in the kernel docs, or at least > they're not as detailed as I hoped. > > Also your previous submission had iirc a bunch more patches, do you plan > to include them all in the next patch set? I have found that some previous patches have already been applied. Need I just convert alloc*workqueue into drmm_alloc*workqueue and remove the destroy_workqueue? Or need I convert all the alloc*workqueue in the DRM? Thanks, Jiang