Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 17 Jan 2023 19:52:21 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Kubecek <mkubecek@suse.cz>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Colin Foster <colin.foster@in-advantage.com>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v3 net-next 12/12] net: mscc: ocelot: add MAC Merge
 layer support for VSC9959
Message-ID: <20230117195221.3e216f90@kernel.org>
In-Reply-To: <20230117085947.2176464-13-vladimir.oltean@nxp.com>
References: <20230117085947.2176464-1-vladimir.oltean@nxp.com>
        <20230117085947.2176464-13-vladimir.oltean@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 17 Jan 2023 10:59:47 +0200 Vladimir Oltean wrote:
> Felix (VSC9959) has a DEV_GMII:MM_CONFIG block composed of 2 registers
> (ENABLE_CONFIG and VERIF_CONFIG). Because the MAC Merge statistics and
> pMAC statistics are already in the Ocelot switch lib even if just Felix
> supports them, I'm adding support for the whole MAC Merge layer in the
> common Ocelot library too.
> 
> There is an interrupt (shared with the PTP interrupt) which signals
> changes to the MM verification state. This is done because the
> preemptible traffic classes should be committed to hardware only once
> the verification procedure has declared the link partner of being
> capable of receiving preemptible frames.
> 
> We implement ethtool getters and setters for the MAC Merge layer state.
> The "TX enabled" and "verify status" are taken from the IRQ handler,
> using a mutex to ensure serialized access.

Doesn't build now.