Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc5beea9-0613-640b-b0dd-e54221c2fc06@meta.com>
Date:   Tue, 17 Jan 2023 21:02:20 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH 1/3] selftests/bpf: align kbuild messages to standard
Content-Language: en-US
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>
Cc:     bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
References: <20230118-kbuild-alignment-v1-0-eb5e9fd55c92@weissschuh.net>
 <20230118-kbuild-alignment-v1-1-eb5e9fd55c92@weissschuh.net>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230118-kbuild-alignment-v1-1-eb5e9fd55c92@weissschuh.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amRxZ1ZiMWlrWWtNdDBiR3pOS0wzTzRCV0hpVnFaSGs4WU1RN29SNndrTXRC?=
 =?utf-8?B?VytyRC93NFREVVZkV21ZalhORnM3N1V1bFBEbm0vWU9LOGprYzkxV0dQZnFT?=
 =?utf-8?B?T3NxdnNWOHQvc0FNa0l6OEdiTkR0U3c5MUcxZWJCMTljeHgrdEY5Zjg4TDJs?=
 =?utf-8?B?QXYxelFmeFdaQTBIc2FvWFgxb2ZFV1hsYUJ1RkRhK0ZYU2dtdS9yUlIzTFVa?=
 =?utf-8?B?Q2ZoYk5XMGFLWXNuZEZaVTJpUVhRdGEySTN4Y3A1Q2tJTGdYUVVRbzE0aTl0?=
 =?utf-8?B?dDdmUEJlQWRPVGxrRkV4d2xZU1IyVUV0dEgweWdneUY5MmRLN0I0Y29Zb1Bu?=
 =?utf-8?B?ZHV4Umw5SjNaZ3g3N0l5MWk3VGpMSzMwVytMNXRuWnNNWmtRdzJ3QjJzeXYv?=
 =?utf-8?B?U3E5U0F1WmhlOUZhQkVTQVQ4ZUFlOE1xdlhQM1hLK2c3UUNQYm1YR0Y1ZzBU?=
 =?utf-8?B?YnlSNThOWVh0VWZVZ0IyUTlUcUlHYlhtbWZFOVNwTmRjQkJUZytkeVlmam5F?=
 =?utf-8?B?WlBPTXdHNFIybGlsL24zNndMR0lQZlZrWkVQVFovWHVwamZnR3VjamgvcHlv?=
 =?utf-8?B?ekgxT0xsY2dramlyQmtIS1dJaUY3MDB0ZFBacENaMTA2T0RWQWVyQll1UllY?=
 =?utf-8?B?THlJdy9hUHFFRm8yWDFlK2YrRW9IWVVUajFwblVvZ2dMZzhvVFRUOXFob0RX?=
 =?utf-8?B?WE1pR09lUjgvSDJtZkJEMnoyOTlmWWZwbnFMMHdGb1dOWXMwczVWZFg2bk8r?=
 =?utf-8?B?a0pybjdsSWpYM204WkxQSHZMRHkxVUM2YUtRVDEvTWpJL1QvOHpGWjJpZ29r?=
 =?utf-8?B?dzBYbitjN3grSUZ1V1Z6WUQ4dXBqUm1MOFlNQnc4VUxEdnBQd0xmYXRLVHo2?=
 =?utf-8?B?VHk1NkFicjhINFlINTAycDQxZ0NBd2I1aW9MMGVsSnN2MlJud2dpWWpXV3Uy?=
 =?utf-8?B?TXY2a1g5cm9aWmk5cEJhRGRhVzl5MHJwcC9lZmdNTlZxZWJXU2lwRFB3dGV6?=
 =?utf-8?B?OWpqejBvV2pBZks1OHh0UnJ3UWRZN2RGc0h0czJ3WEJuajBTT3dpejhtTmRo?=
 =?utf-8?B?MGFyMDlsc01ZcDJiOUdpNUJKc0V6U3RmcWk2MTlKT1RlY0dIK3l4SWprclVR?=
 =?utf-8?B?K09hZ0dPT2hLVnhsYm9sV1ZWcXNJbnFnS1FjdDJoVUl5VVRMUy9rblArazY4?=
 =?utf-8?B?WXRldVpXWmNtNkpVdWtNNnpQWTJjZ2gvQ2tBWEs0VzJ3a1poem5mbEFHaWFr?=
 =?utf-8?B?QUJQWEkwQ3N6V0tJdGpNTzY5MVNSNHdRUm45N1FLcnE1WWdDTUlhZVN6RjJv?=
 =?utf-8?B?S2R4V3BIUzBLSHNJSUxlTHlMcjlQUFFVOXFFQkowUEZyclI4WmkzZmlxUXIr?=
 =?utf-8?B?OUZpb25senVpNDJsT2haMGlMMGZvYVdaQzRzYk13MjVPSGF1MXF3bFJqRDVO?=
 =?utf-8?B?SGhpR3NWTi9neDF1UFR3M1FIZUdwS0xlaG1KRnNGbzV1c29qeXFGQ0tDcTRV?=
 =?utf-8?B?b2dNR2NWS1ZlRnVyZ25GVk8vWEIwbjFJVW5ZUmRscU1yZDJxNldGcmg2b2Nt?=
 =?utf-8?B?ZUphRHM0OHVxNm5VMnZ1QUxzTDlkZFBSZFJTWlpUOEl1YThvd3p4bWtIUHc5?=
 =?utf-8?B?dmNRVWFzZUh5K0pZbC9sTmpweGxnbWhmYmYwbjZaVWZQY00vVnJoWFpwQmRE?=
 =?utf-8?B?RXhsdlJsTHhtSEVSSTFVbjE2RFlBdkRpQ3NKL29kSjZWQUFHRDhqVmtNaXhz?=
 =?utf-8?B?ZmoyOUU0ZTZ5ZEVGWTRmUERmdGRKTys5bFhkTVViWHdDTmVaRDlHRHNJOFUy?=
 =?utf-8?B?eXhtci9DUkNUclJjcDJNYnoyVGFBREFLL3k2T3FTdk5qNDMySWlxeW5jODZi?=
 =?utf-8?B?ZkZjdjU5N1lKSVhVMEExYVpWUFlCOExIbXJjSy9BNVJ6dzUvV3hEdk5pK1Fk?=
 =?utf-8?B?Z05jUnMybFMvcXZJQkdIZytwNWgwNkNlVU1pdU9HZjlzOTR6MUpxTU5BeGxP?=
 =?utf-8?B?Zit2RUoyZTA1ZXpTUG5qSi8ySXZpSVRYUWk3ZkxCbWpqZWJrNlNhQ1RhNjZB?=
 =?utf-8?B?dmlZSG1aVmNmeFJiVzZCSXkvRHN0RmltN29QUm5vVzh3cVVFdmMwSFJIWndR?=
 =?utf-8?B?ci80TUdIckhJL0N2RW5NT2QrMC90dXFlMTZrWE5RNWhsMU0xcVB4WS82bjhW?=
 =?utf-8?B?bUE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4aaaf65-18b7-48d5-2ea4-08daf9112f22
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 05:02:22.9063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9wCafTl5SUurTyNc9KeAZSsEBp/oWdmfd+OoAO9VaeBTw2l16OTtdStshajjlL0Y
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB4868
X-Proofpoint-GUID: cnx_Rd1zpZm2BBK8oyoD15xc1uXSm2o7
X-Proofpoint-ORIG-GUID: cnx_Rd1zpZm2BBK8oyoD15xc1uXSm2o7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-18_01,2023-01-17_01,2022-06-22_01
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/17/23 7:52 PM, Thomas Weißschuh wrote:
> The common layout for kbuild messages is as follows:
> 
> - 2 spaces
> - 7 or more characters for the action
> - 1 space
> - name of the file being built/generated
> 
> The custom message formatting included an additional space in the action
> part, which leads to misalignments with the rest of kbuild.

Could you give an example to show the output before/after the patch, and
how it leads to mis-alignment and why it is a problem?

> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>   tools/testing/selftests/bpf/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index c22c43bbee19..5190c19295d4 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -98,7 +98,7 @@ Q =
>   msg =
>   else
>   Q = @
> -msg = @printf '  %-8s%s %s%s\n' "$(1)" "$(if $(2), [$(2)])" "$(notdir $(3))" "$(if $(4), $(4))";
> +msg = @printf '  %-7s%s %s%s\n' "$(1)" "$(if $(2), [$(2)])" "$(notdir $(3))" "$(if $(4), $(4))";
>   MAKEFLAGS += --no-print-directory
>   submake_extras := feature_display=0
>   endif
>