Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230115210535.4085-1-apantykhin@gmail.com> <CAGS_qxpoGCXAK=q+unFoYKN0GtH8V9Ojmntz0YZrae8zBeX-qw@mail.gmail.com>
In-Reply-To: <CAGS_qxpoGCXAK=q+unFoYKN0GtH8V9Ojmntz0YZrae8zBeX-qw@mail.gmail.com>
From:   Alexander Pantyukhin <apantykhin@gmail.com>
Date:   Wed, 18 Jan 2023 09:33:02 +0400
Message-ID: <CAPi66w-D-x_rhv+eQBSPqmqpK3nF2_VuizZPA9dZ0kL1=XAf-w@mail.gmail.com>
Subject: Re: [PATCH] tools/testing/kunit/kunit.py: remove redundant double check
To:     Daniel Latypov <dlatypov@google.com>
Cc:     brendan.higgins@linux.dev, davidgow@google.com,
        linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Daniel.
Thank you very much for your review!
Could you advise me whom I can address the V2 patch "to"?

Best, Alex.

=D1=81=D1=80, 18 =D1=8F=D0=BD=D0=B2. 2023 =D0=B3. =D0=B2 01:56, Daniel Laty=
pov <dlatypov@google.com>:
>
> On Sun, Jan 15, 2023 at 1:05 PM Alexander Pantyukhin
> <apantykhin@gmail.com> wrote:
> >
> > The build_tests function contained the doulbe checking for not success
>
> very nit: if we're fixing the "doulbe" typo, can we also do
>   "the doulbe" =3D> "double" (drop the "the")
>
> > result. It is fixed in the current patch. Additional small
> > simplifications of code like useing ternary if were applied (avoid use
> > the same operation by calculation times differ in two places).
> >
> > Signed-off-by: Alexander Pantyukhin <apantykhin@gmail.com>
>
> Reviewed-by: Daniel Latypov <dlatypov@google.com>
>
> Thanks!
> I can't believe we never noticed the duplicate `if not success` blocks
> before now.
>
> Some minor suggestions below if we're already going to send a v2 out for =
typos.
>
> > ---
> >  tools/testing/kunit/kunit.py | 17 +++++------------
> >  1 file changed, 5 insertions(+), 12 deletions(-)
> >
> > diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.p=
y
> > index 43fbe96318fe..481c213818bd 100755
> > --- a/tools/testing/kunit/kunit.py
> > +++ b/tools/testing/kunit/kunit.py
> > @@ -77,10 +77,8 @@ def config_tests(linux: kunit_kernel.LinuxSourceTree=
,
> >         config_start =3D time.time()
> >         success =3D linux.build_reconfig(request.build_dir, request.mak=
e_options)
> >         config_end =3D time.time()
> > -       if not success:
> > -               return KunitResult(KunitStatus.CONFIG_FAILURE,
> > -                                  config_end - config_start)
> > -       return KunitResult(KunitStatus.SUCCESS,
> > +       status =3D KunitStatus.SUCCESS if success else KunitStatus.CONF=
IG_FAILURE
> > +       return KunitResult(status,
> >                            config_end - config_start)
>
> nit: perhaps we can shorten this to one line, i.e.
>   return KunitResult(status, config_end - config_start)
>
> >
> >  def build_tests(linux: kunit_kernel.LinuxSourceTree,
> > @@ -92,13 +90,8 @@ def build_tests(linux: kunit_kernel.LinuxSourceTree,
> >                                      request.build_dir,
> >                                      request.make_options)
> >         build_end =3D time.time()
> > -       if not success:
> > -               return KunitResult(KunitStatus.BUILD_FAILURE,
> > -                                  build_end - build_start)
> > -       if not success:
> > -               return KunitResult(KunitStatus.BUILD_FAILURE,
> > -                                  build_end - build_start)
>
> Oh huh, I guess this duplication comes from commit 45ba7a893ad8
> ("kunit: kunit_tool: Separate out config/build/exec/parse")
>
> @@ -64,78 +84,167 @@ def run_tests(linux: kunit_kernel.LinuxSourceTree,
>         build_end =3D time.time()
>         if not success:
>                 return KunitResult(KunitStatus.BUILD_FAILURE, 'could
> not build kernel')
> +       if not success:
> +               return KunitResult(KunitStatus.BUILD_FAILURE,
> +                                  'could not build kernel',
>
> > -       return KunitResult(KunitStatus.SUCCESS,
> > +       status =3D KunitStatus.SUCCESS if success else KunitStatus.BUIL=
D_FAILURE
> > +       return KunitResult(status,
> >                            build_end - build_start)
>
> ditto here,
>   return KunitResult(status, build_end - build_start)
>
> >
> >  def config_and_build_tests(linux: kunit_kernel.LinuxSourceTree,
> > @@ -145,7 +138,7 @@ def exec_tests(linux: kunit_kernel.LinuxSourceTree,=
 request: KunitExecRequest) -
> >                 tests =3D _list_tests(linux, request)
> >                 if request.run_isolated =3D=3D 'test':
> >                         filter_globs =3D tests
> > -               if request.run_isolated =3D=3D 'suite':
> > +               elif request.run_isolated =3D=3D 'suite':
>
> This is better, thanks.
>
> Daniel