Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1673977558-7648-1-git-send-email-quic_jhugo@quicinc.com>
In-Reply-To: <1673977558-7648-1-git-send-email-quic_jhugo@quicinc.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Wed, 18 Jan 2023 08:16:12 +0200
Message-ID: <CAFCwf10mAFEJNkZCNBuzz1_dAOP2fgEXU2M2okkq77PTa0MWoQ@mail.gmail.com>
Subject: Re: [PATCH] accel: Add .mmap to DRM_ACCEL_FOPS
To:     Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc:     jacek.lawrynowicz@linux.intel.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 17, 2023 at 7:48 PM Jeffrey Hugo <quic_jhugo@quicinc.com> wrote:
>
> In reviewing the ivpu driver, DEFINE_DRM_ACCEL_FOPS could have been used
> if DRM_ACCEL_FOPS defined .mmap to be drm_gem_mmap.  Lets add that since
> accel drivers are a variant of drm drivers, modern drm drivers are
> expected to use GEM, and mmap() is a common operation that is expected
> to be heavily used in accel drivers thus the common accel driver should
> be able to just use DEFINE_DRM_ACCEL_FOPS() for convenience.
>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> ---
>  include/drm/drm_accel.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_accel.h b/include/drm/drm_accel.h
> index 65c0affb..d495506 100644
> --- a/include/drm/drm_accel.h
> +++ b/include/drm/drm_accel.h
> @@ -27,7 +27,8 @@
>         .compat_ioctl   = drm_compat_ioctl,\
>         .poll           = drm_poll,\
>         .read           = drm_read,\
> -       .llseek         = noop_llseek
> +       .llseek         = noop_llseek, \
> +       .mmap           = drm_gem_mmap
>
>  /**
>   * DEFINE_DRM_ACCEL_FOPS() - macro to generate file operations for accelerators drivers
> --
> 2.7.4
>

Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
I'll merge it through my tree.
Thanks,
Oded