Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <086444df-568b-d394-c190-9f206cad9222@amd.com>
Date:   Wed, 18 Jan 2023 11:41:23 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v6] x86/sev: Add SEV-SNP guest feature negotiation support
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
        bp@alien8.de
Cc:     mingo@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com,
        seanjc@google.com, pbonzini@redhat.com, thomas.lendacky@amd.com,
        michael.roth@amd.com, zhi.wang.linux@gmail.com,
        David Rientjes <rientjes@google.com>, stable@kernel.org
References: <20230116091036.72579-1-nikunj@amd.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20230116091036.72579-1-nikunj@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXlqU3VqYU4vUERqcHJWU0hEcXpEMDBXZ0NsdG4rMDN6bmtlcHhwZlpwUFBR?=
 =?utf-8?B?bzlQbnk3UExOaWk1TEVGaUtlMEsxWnNYbWIyNGcrdkF0M2Qrb1ZaZS96TUNn?=
 =?utf-8?B?MnhTcFJqOHdQQlZoZjZNTUdhQUZjSmtMVGhhWExkVVJBTXFWZmpEVlJVMS9n?=
 =?utf-8?B?RjNhSDAvb1NMbXlCMkk3Z0w0R0dNcjZFbUNLMzJqeGd2dDlTd29WSTRwU0V0?=
 =?utf-8?B?UXFLRFRJaDJicEdGQmNtWlpaeDlDNmVhZ0hjVjZwWGRCYm1kcjJQNE8xaDBz?=
 =?utf-8?B?SEo5aGVzMnc2NTBjMk0xT3JuY283TkF1eWZJUU9VOENyMWdiZFdhK0pkV3BR?=
 =?utf-8?B?Q0p4ZlFSQ2xjblExak11MUxHbyttSVVGVTREN0ZrMXQ0N1d2cVhUTEsvOVF0?=
 =?utf-8?B?bDRkTitGQThMdGdwMVBRWW9hNkIxYk9OUWh1NU43WENma1BUWU1LRko4K1pu?=
 =?utf-8?B?WXZJQVppMXY2ZHNGUGlUbjRqNXF2S0NZWHhjdExZRHV5TGhSWFN5azVEeUNQ?=
 =?utf-8?B?ZUl5L1FPK3J2ekpzWWFGa2hvSW9sNzNxYWtXWG5KeHlCNWxGV0w0MENGdllF?=
 =?utf-8?B?UnZ0U2ZOcXkyQXlXdE5qQ21tdWVibUIxTXFYQkxKN01yVnZDb0dPc2JiYzhL?=
 =?utf-8?B?emhuOERnbVhDV05idExDRWlJMU84UHZ3bVkxbmNrS2JmTGtweERDNC9HSFRO?=
 =?utf-8?B?ZGRkT25ROUhuMTZLdEh6cEZBakY2SDZQUi9MT0grUzZxQkovcEpkUzhDQkpq?=
 =?utf-8?B?eGhBd1FHVnJncWNJMTh3OUtGMUhwRmltL1ZhRERpYlF6UlNuYVdNRDFyUmtK?=
 =?utf-8?B?aUtsTmYvQjZreGwvM3FsVzhsaGQrOU9Od1FEVGFHcXNpaTVyL0hGU2w0dHE5?=
 =?utf-8?B?eU5GeWs2S2daZWhYT3pEMFFwVkNiVWpnaElSZjVmMzJWV2F0MEpiZDdCNGJQ?=
 =?utf-8?B?WExZTmRhWjAwV284ZHBYNTlPWEU1WE9lSjdQeWRhbkVhMExic2JiUWVURnp5?=
 =?utf-8?B?VkJUSGZSc3B6ZnFMcWJ5OTFwdm50NThmNFFKZC9IelkrbDVBWDNXSnAzb0Vz?=
 =?utf-8?B?M05MQ29aM2hqY3drbzBLYUd0RzBvVEg0ZDUwK1pKOWtjMUJ5OHdVVTRFQlZo?=
 =?utf-8?B?L0pDZ3BTV1hlWVB3NFhZQ29BOGpCeVFUZm10djRtUlhsUlRsYkJ6dFNHSW94?=
 =?utf-8?B?dXltdU04QU45aUcxRnFvVDEzOWcwMnp4SlRFZ2tGNUFKcjM2TU5IdGxOWEE0?=
 =?utf-8?B?L2M2bVFrMTFUWVJYWWx1VG9hT2FMaHZxZ24raW5kQVRUSStkVVZsNjdsSjA3?=
 =?utf-8?B?ZDN3djJpbVFLK0ljZG5zam83YkZiQktlRnZUZTRvMjZTc01iZU1zN1dLUlhv?=
 =?utf-8?B?UWZ3UnZTdFg5bytkRTVVQWZVV3JlUWIyR3VpSjNaTTYwSUZ0Z1o4dUdwTmtG?=
 =?utf-8?B?d2ZpOHFVK0RSTzhKcmZWLzhkdkRsN3pXSGptMmk2ZGVCWFh3ZEY2aEVvaGVG?=
 =?utf-8?B?NGhFYVZNQUFTVUlWN09md3N3N2ZFTXJvQnJ1blI3WDc0eGFFc1U2c1VyRitW?=
 =?utf-8?B?Rm1tR3pmd09tdEI4NDZpSDNjeFZiL0taQ0t0S2h0WUxLV2xubWp2anpEZEZk?=
 =?utf-8?B?bXNLVUF3UjI0VStOdWpnS3c2cXc0MDdXY3E3ZmZXSjJCOWJyMUtFY2dnUXI4?=
 =?utf-8?B?bDFsYTU4ejd2T1VURHFjV0w4OHhwNk5rTEU3UW1lT0xEMHBFekhnc2VKSGVB?=
 =?utf-8?B?NzR0ZXlVbFoyRHdmNVE3aWtNbGZIODhWRURsa1Z6VVVTN3lXVHZhamV6VzRK?=
 =?utf-8?B?QWE4M0Z5bFBlU0JzcVZ3OXNqam9lNk5ncXI0ZDBHamhhNzlNbkRxME9GZFFH?=
 =?utf-8?B?N1czRE5OS3dUeWxkUXFxcjVYRzVzRG9CekttNDQ5NmV4cUZNM3lFRDJxSGRt?=
 =?utf-8?B?bUp5b2pBbHppUXRZbkYxWldpTTRqOGtaaEJjV1lXeVpsQkE4Vm9mWTNHcGky?=
 =?utf-8?B?VE5BVmRFdXlZaXpJSDZZcFBJdnkzTUlreVZuWElwcWJpNDZiSGtnNHQzVW1E?=
 =?utf-8?B?MmFCT3N1Qk1DbytueTVodzBEOElKZXFqS1FYWkhjSmFpT21aZUlQbVhqTU94?=
 =?utf-8?Q?D42a9tJoIvv3gmarcI5BkxlZt?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 713282ed-4a04-48f8-3ac1-08daf91adb17
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 06:11:37.0294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z44pg06FyPZ8pBSl4EgZ54AfxEVkkHu1jYuaem7lxc2sV5IOSIeA3gwPReNipsHvldAFNQ8O1Kxqr4wJP5n+YA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8502
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 16/01/23 14:40, Nikunj A Dadhania wrote:
> +static void __noreturn sev_es_ghcb_terminate(struct ghcb *ghcb, unsigned int set,
> +					     unsigned int reason, u64 exit_info_2)
> +{

Found this today:

In file included from arch/x86/kernel/sev.c:519:
At top level:
arch/x86/kernel/sev-shared.c:167:24: warning: ‘sev_es_ghcb_terminate’ defined but not used [-Wunused-function]
  167 | static void __noreturn sev_es_ghcb_terminate(struct ghcb *ghcb, unsigned int set,
      |                        ^~~~~~~~~~~~~~~~~~~~~

I am wondering why I did not get this error in my build testing.

sev-shared.c gets included from two files boot/compressed/sev.c and kernel/sev.c, sev_es_ghcb_terminate() 
has only one user. I will move helper function to boot/compressed/sev.c and send an updated version.


Regards
Nikunj