Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c3bd64a-164b-7ff2-ebf0-c8f9c2f94b72@amd.com>
Date:   Wed, 18 Jan 2023 09:51:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH drm-next 02/14] drm/exec: fix memory leak in
 drm_exec_prepare_obj()
Content-Language: en-US
To:     Danilo Krummrich <dakr@redhat.com>, daniel@ffwll.ch,
        airlied@redhat.com, bskeggs@redhat.com, jason@jlekstrand.net,
        tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net
Cc:     dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230118061256.2689-1-dakr@redhat.com>
 <20230118061256.2689-3-dakr@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230118061256.2689-3-dakr@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTFJYVpQRXo0VEpod1RiNXI2QllYOVlvY1k2RVJLc2tqQmxRTGtBVm9sRWZ0?=
 =?utf-8?B?Sy96TkFxanh3ZkZQOW1JbWNWRzl5ZWFQai9ZNmtMaGN4a09DTitWcXNaVVNX?=
 =?utf-8?B?RDI0czlRdFJDOW9qR1BJeC9Mc3k0Z25jK1pzYnpESjdJaWZnUzRadjlIdEpU?=
 =?utf-8?B?Qzh5K2ErNldCQ0NpSjMrQ0hNdHY2T21YTmI0VC9VV1EyaUpYaHpQTzVIcGhL?=
 =?utf-8?B?ZnhsUUV0T2xyek9qb3ZmUHNzeWdtaDcyNXc5SFpNMDFCNTdlaUxnVHNCZXRt?=
 =?utf-8?B?Vmo4Q3o4eW1taVVJbG5EcU9WQit2ZG9YVnhvcCtiWWZ3a0dDQmtQR0t1U1hx?=
 =?utf-8?B?QjBqbnNCOUhBemJmdmwrTzIrbmdySjMxcDVtTU43VDdFcC85VjJzb3h1bENH?=
 =?utf-8?B?aXBnL1JRbFdJNGVpMndjNDIzNXJEQ2dTa3FxbllZcjdGdjNGNzdXRnJ6SkRQ?=
 =?utf-8?B?cXFaaVM2S21wTEppeTA1aVl6SjFyNkxtQi9SbXhGTCtxN0JTV1F2RmZsVUNJ?=
 =?utf-8?B?blUwUlVxTnMyalh1YzErV1ZTbW5Da1FJM2RYbWVsSUMyNDB6aG5ITWFQVkY0?=
 =?utf-8?B?N3ZYTlh5Z01jZEg0SlorOXN3bFIrbXE3aEZzV1ZYMFJxUERGZFp4VGxtbnlU?=
 =?utf-8?B?L0sxZUFjazdPbUhxVitldmdJamE5dlJZWWUzL1VMTFNMeUlhb1phdEZXTVBj?=
 =?utf-8?B?aENzS3RDK0NkNVRRaERnYlpJbTVrVU41VDh6eS92cFlabkxHVyszUFZQWDdo?=
 =?utf-8?B?RHFkTWthYk5LTmhvM3pORjdicG42Nnh0V1E4M242ajJDSFlCMklRYXlBNmJS?=
 =?utf-8?B?MXNpZXZiRTdHMGZ5bHNEQ1ZFejIzVTQzWXoyT3pkYkZSY1hTRGIvZCtnOGF3?=
 =?utf-8?B?MHB6TEh6TTM1YlJYZlJwK3M2Z0NlbUNvK3lOTXVrSFVwK3hZZGphejFxOE0w?=
 =?utf-8?B?Y1FUeEg2a0JpbDhubko5WDlYR01rK3dsRUZNd24vQk1sWGpsZDl3bll3TmRP?=
 =?utf-8?B?ME4vZENYYUtUdEpKVWl2WXJRdHpEVEthc1dDcUFiZkt1ckxDTVN2c2JIaXZJ?=
 =?utf-8?B?TXRHZWE1bEFVVk1Gd3FOd0Rsc0tYcWlSQU1aRzF1RGxIL28vcisydEhiVXNT?=
 =?utf-8?B?QXlNTEZEcUFOR1pUV0hHT01lN1VlSmxLQVRmbFY5OE8wb2hNYmVjTGJma0ZX?=
 =?utf-8?B?MDVMZ3FMQ3JmWk5ySDlCU1hiVGJvVGpvdHRiMW5DVFdycVlETHNTZjN3WEhF?=
 =?utf-8?B?MHRhTlVSaHR1bTVXV2l0NzZlMDNaMUw5RUhTLzdjUTVLVENPVzFnZEhvMTJa?=
 =?utf-8?B?eDU0ZERjK0R0MVFMaE5YSDArdUVLdUtkZXRveHR4dXlzL2JublZORWZVUXZB?=
 =?utf-8?B?UTJyNDBqcEFqamlUNFhHREVOSnFVVE5ZR0Y2eDcxTVZSbnhWRTdRVVpoN1g1?=
 =?utf-8?B?SE81QXpzVDRva2F2QWxiTkpKNlQ4d2N5ZFcyZjh6WnQvUnZodXdqdzRDcFlE?=
 =?utf-8?B?Yjl3UlFKelR4Uzg3VjlMbUZmYmRuczdlWmhLQnFFc0Q4U0VkV0huWWJqVDk4?=
 =?utf-8?B?WTExRDNlQW05N1pvMmdCZWNwbVhCMWJicituRkhWZ3BtNE44NWFPc2x1eUdX?=
 =?utf-8?B?ZlJncWUzMTJIdEVFTVdZa2dOdVdKaVl6bkpVMStZNUNwM0ZTUTIzc2VRd04x?=
 =?utf-8?B?UWx4SVBIdTBnOWN3NEYzcW0vV0EvVEllNUtpVVJCR1FLRzRJSkpDeTUwNm9m?=
 =?utf-8?B?QVIzdmtrc3BOZld1c1VVMjBqem5mK0greGtGZXByUVRHUmZSMkVVbk5ISTZK?=
 =?utf-8?B?cVdUOXFMYnVVdVI4Q1VxbGlpTHFhZ3NDZjR0dld6UFppMEdxU1VJVUxVZStv?=
 =?utf-8?B?NjB1cDJLMitqWEJxSHVYeklVOXNmcGduZkFrTGwvYWpvMTRGUlltTUpId1BX?=
 =?utf-8?B?bldRQlowWmpRQmlSSWQ0Rm9vWE1EN0tkblJiZXE0K0dLZHBjOWMrcVZVNCtG?=
 =?utf-8?B?NXc5QnB6UzJCU2lZMkxOUHZ4Q2xyRkhnTStYaW9HSUE1VUtNSlJscEpDcXZO?=
 =?utf-8?B?bmpsQTBibUxFNC84ZU5qMHVpVEsydG1lRnZ4ajVCRjZ2ZkxKdnlvcGdGamxs?=
 =?utf-8?B?a3dNUE40Z2hlRklHS1JlNlV2bXgrK1JTSS9qN3c2VmVsQzhvN0IxcDZybFlR?=
 =?utf-8?Q?sXiqYQJcw0fWrRZxLJ48n1F6SDFfo9heCvn8Cq1F19tO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7886a82e-8e4e-4baa-df1a-08daf931448f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3589.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 08:52:02.8308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9RVMhxuegYjd4hRk5bNnOcGR6v9SbwxP05r7rEOs2QRmQOvHZa4H2sqvW8L4c2De
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4870
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

That one should probably be squashed into the original patch.

Christian.

Am 18.01.23 um 07:12 schrieb Danilo Krummrich:
> Don't call drm_gem_object_get() unconditionally.
>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
>   drivers/gpu/drm/drm_exec.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c
> index ed2106c22786..5713a589a6a3 100644
> --- a/drivers/gpu/drm/drm_exec.c
> +++ b/drivers/gpu/drm/drm_exec.c
> @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, struct drm_gem_object *obj,
>   			goto error_unlock;
>   	}
>   
> -	drm_gem_object_get(obj);
>   	return 0;
>   
>   error_unlock: