Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6185127rwb; Wed, 18 Jan 2023 02:10:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXuScMrRF71WhP/yoBhV/qvakpc9BIQX++EEBwwGlKydTPsDiUlW+CW5HTecD8lVHqI7XxvQ X-Received: by 2002:a17:906:dfda:b0:871:e9a0:ebaa with SMTP id jt26-20020a170906dfda00b00871e9a0ebaamr6334568ejc.31.1674036624711; Wed, 18 Jan 2023 02:10:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674036624; cv=none; d=google.com; s=arc-20160816; b=QtRMcpZtlsK0mqJaY9pk1LUF/qgk9OCb4G1m9M2Zkxq2xSHKsuFApyP/WgpvHWKLz7 d9RLzg5ySeuNVZUF8SmiCeyjpYYUUEMsLicY04w7wyEwqy3JOZUutcB80xyNvCZtih44 iF8fvvkYkc86r+9W+adML8UzYdEm2zbWIk0PpamOKJPuWcOrtx7UrW8LUHmrFXd+vERs /GeFT9kz/heEwiOg6R0OfM0oU6pBd2xe3PmaoIU2hr8Jc38cLd0sXKBVvfNrvKeR4TrR ot/04fcC3m7Uz/6XnnSAHUhgH9MvgdlIcb40qUBsf7svLF0iS0mE9Fxso53I+p+eacXS dBKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+gTV5p7FRGD5TbGjgHsInj3fpbsleUzYJDQTdl1tVKU=; b=X4Wy3cesps7tBtcVnRJxasK0SL/Botu0QsfAbRy+a1fTcoV8UNYdT4crg23EJHz/zk SX/nw/9Y/I18I6LZSnXhkUVATpHiVS7qeseWQLb9G2a9XkZMAuQehY4japq1Rs/90gbg VefDIKGo/aoN6Ykmp3r0WJK/iblm4DDFfCZ9sM8okZAw5AwRumEUY+u0xp3c9CXHP7lw LWvLZ1MUKcBkKVZO5VDILFFVJyTMPYl2Fz2MxYqI0iVP2H35xNewafahYKHPsxaYBUZM cYUq3HaTALNpDbKim9SvW4hP86RNMpZrATQ3VGujO0xopyKVKrBEPVD5gJWA20WUBfwC MlFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=onJ2d5SB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bb7-20020a1709070a0700b0084d4a07de68si30075215ejc.477.2023.01.18.02.10.13; Wed, 18 Jan 2023 02:10:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=onJ2d5SB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbjARKCW (ORCPT + 45 others); Wed, 18 Jan 2023 05:02:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229947AbjARJxN (ORCPT ); Wed, 18 Jan 2023 04:53:13 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A338B15567; Wed, 18 Jan 2023 01:04:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CF8861734; Wed, 18 Jan 2023 09:04:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91599C433D2; Wed, 18 Jan 2023 09:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674032698; bh=Og++GJb7hTbwoPbP/PbiJ4khLA5V7ZfC8ZOMe7Q2oZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=onJ2d5SBJ3KicWcxuISKEZT7OC+yjoOjMYNpXkzOF27Sw+/vekm9D5AVL04vwguKX kiwMGVYZ6Snu7m60/z9LjxONpccDUYHmJdKb25OWSMswXpZm2mfnWjLi7fE5XVor6L Yv6vF8K8XQ8o/l3tSpkfur4wgRK5MXXKNQKnN1D53/pr4m+SwZ3a44ojPoeTAG4M26 KVk4aOp6YJE8xmNi6vwBlVUgVp9+c83JN/3xt0s0aYKXoHsPMc1PGC9Z2+8ESRGbPj IE4YnyeW6hJ8XQV02EqOuEY740XzYR0IzoAecPbs7FcIhWAIKtpSWLtiazZuqk3MKC M1dOIEK7kX6YQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pI4Nm-0001Is-Mt; Wed, 18 Jan 2023 10:05:22 +0100 Date: Wed, 18 Jan 2023 10:05:22 +0100 From: Johan Hovold To: Thomas Gleixner Cc: Johan Hovold , Marc Zyngier , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 03/19] irqdomain: Drop leftover brackets Message-ID: References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-4-johan+linaro@kernel.org> <877cxklv09.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877cxklv09.ffs@tglx> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2023 at 10:19:02PM +0100, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > > Drop some unnecessary brackets that were left in place when the > > corresponding code was updated. > > This is really the wrong patch order. Real fixes first, then the > cleanups and cosmetics. Yeah, that's what I'd normally do. Perhaps I took Marc's: No, let's put the code in shape *first*, then add work on the locking, as it should make the patch simpler. Backports aren't my concern, really. https://lore.kernel.org/lkml/87v8rhwf9r.wl-maz@kernel.org/ too literally. Johan