Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <94fc297c-2cef-4c37-a623-3996c8dbc48f@amd.com>
Date:   Wed, 18 Jan 2023 14:36:41 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2] HID: amd_sfh: Add support for tablet-mode-switch
 sensor
To:     Jiri Kosina <jikos@kernel.org>, Adrian Freund <adrian@freund.io>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Basavaraj Natikar <basavaraj.natikar@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "Luke D. Jones" <luke@ljones.dev>, Ivan Dovgal <iv.dovg@gmail.com>
References: <20221218214723.14735-1-adrian@freund.io>
 <nycvar.YFH.7.76.2301180948450.1734@cbobk.fhfr.pm>
Content-Language: en-US
From:   Basavaraj Natikar <bnatikar@amd.com>
In-Reply-To: <nycvar.YFH.7.76.2301180948450.1734@cbobk.fhfr.pm>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXF1bVRGNXNCNkNObVVwU2N5YjdkZU5TaytSOEtObnAyNm5qdmNLTUNQaWt1?=
 =?utf-8?B?TVJuSVRVSGhtcURzTWJBYVY1YWt4M0MyTzNCZWFkZVg5VFMxYXhlR1FnYmtY?=
 =?utf-8?B?ak9lWkFpQVp4SGp0eER3aitqajcvQUxsb2FpWmVPYzJaTkF0MTQycWFJdjJF?=
 =?utf-8?B?Y3g5ekdNZ3V4TzQ1dWtDSitTV3p5OWFGdGw1cWtNS04ybTFERGVxd0txOU9W?=
 =?utf-8?B?M1VvS2FPUlk2VVVJbEFka0MvVTBDcXdUck0yS2MvRnZSdlNHL2QySTZOb0Vq?=
 =?utf-8?B?Z2V6YnRsM1pJV3dlQ2ZFeFgvdWxnV1RpRWRSS2xFdmZLZVUyRThJQjRkdVNq?=
 =?utf-8?B?bnNjNUtwK0o5ekljTnE0KzFPTHlvUVlaNG56RU9KYUFqRS9XRW9RTW1vOVJj?=
 =?utf-8?B?T1VFaVgxdHdHdlFvUnl1SE9oNlpmczRqUmpXV2FpQ3RzM0FmWjkrUER6bDZN?=
 =?utf-8?B?Ykg0SmM5VUI4N2tZd1krY05wWG1VTEdSK3krbXZUUHNWWlRuTmVVQWNCTEgr?=
 =?utf-8?B?dk8xZnc4NWxCSktmNFlNS0FKRXBNU1QySjZlNWVQdGY5NndKcDY3K0h2TGpD?=
 =?utf-8?B?WWpmY08rczJObTFBbkFwVFRrd3VIQ3pyRzAwSDJIVTlkejBaZ1k4Y3B5ZHBy?=
 =?utf-8?B?VUNnby9lNEluTStIRTVZZVM4b00xYkwrNnZzS3FiRDVoNUFMOGlIOFJocSti?=
 =?utf-8?B?bDZPNDdXU0NGbHZjcnZibi8rajJpTmZGSVRrcXhkMWdaQnZKZktmc1dZbUJM?=
 =?utf-8?B?R05ZeDlTVFFqd3loL3Z2S3liaUh2MVRWTExpTzJvY05rMHYrdGRveVZJL0NF?=
 =?utf-8?B?MTRnNlFCV0M5bklDbVFDZ3ZPdEpIcDJyWHAyTkd0WlRsc29zck1aUE54dlZX?=
 =?utf-8?B?MGpHMUZMU1Y1Ym1ZYkRJcGlwN25XclArM3JySzFIdWpGbGFiVjA5enVsWFNX?=
 =?utf-8?B?M0dPbVhMNlZCUjBsYjZLM0tyVUtpRlZHUVkzVmczS2YxVTZCQWNBemFnUWU2?=
 =?utf-8?B?SmxFaU1SdjBybXFoejlIb3Fuem0rQUoydjJkV0YvUSt4UGRQNkJFV2Q0WkxM?=
 =?utf-8?B?MjRVdnFBYmJRYkhKaHNrcmF0T0NRd0ZhcFRlZ0kxUGovOVJXQW92dFU2S0hj?=
 =?utf-8?B?b3k0aXNUWXY3RjdxOThJS0dCcWIvbUwwWXBHZXNGeHI3ZDUyY2tBTUQ2OS9W?=
 =?utf-8?B?YXdhNjd6S1M2aGdSYXpHVWtsVS9ta214N0FNeExidXlaRlhzWndoMkMrR1RQ?=
 =?utf-8?B?ZkZNTDB4SlZUVTBEYm9yYjFMOU1palFHbERUdEt2MnJxYngvWGdNR09jL1k0?=
 =?utf-8?B?V2pnM3JpM0V1d0hyUEtoN25OMTdWTmRJK3BzdXBXZkt5S1dBdk55WVhObVU1?=
 =?utf-8?B?aTBjYzBlMVk0a0RmVVFhVXVMUDkwbHFrTXJnUStVWUVIR0R6Umc0ck5yc25h?=
 =?utf-8?B?TC9RVXFlQzVlV1hOZGI2WUhIOUlPRy9VWFg3djNmU1ptNkhvQk0xb012WkhQ?=
 =?utf-8?B?MmtxYnkvaExENW9KMjc4S2JMTTN2bFRIY1JzTitnQzc1azdWODkrblVMeFBK?=
 =?utf-8?B?TDJjTkRic0xFdkJFM1JPMnVqYzFXZkh1TU04elRjTmVOYzV6R1NnQmg3VVZX?=
 =?utf-8?B?L2NDZy9mckRhSUFCL3dJbllrQzNESmxoM3RNcmdHOFBTRDZqWE5aM092b09o?=
 =?utf-8?B?WjhaRjZtdWpWYjZ2VXluYTdLaGdGZ1d5UVM2cFVLNVlUT2VGMnR6VVNGZjdP?=
 =?utf-8?B?TDhXL0J2bHd0SElwVDFpVEVzWC9rTTFXZDFWR01QVkxxZm1OcEhiVW52andJ?=
 =?utf-8?B?c2c0SkZKUG9iaWVONXdhUWRGKzljZzA3ZEI3ZlBYNGJ2L2ZudnFRTW45Z2lO?=
 =?utf-8?B?YmVpZ2F0S2lvYWNBa2tQcG96UDBKRjY0MTg0NEZHZ0lHaDVTSWlVNndDdDdY?=
 =?utf-8?B?ajhpelV5VTFQeWRMTEhRcmhmTWVzR2NXL0h0MWdUU2c4YTVxcXIxSHFTdkhw?=
 =?utf-8?B?UWVCVEpSVUt6TkdzZDlaRWNjaFdjT0hGQkwyaE8vNmp5RnlsKzNQLzVRTWxS?=
 =?utf-8?B?c0RRd1BSdC9YeHFVcEZuMCtNaTNINzVoTnMzMlIva3JhYXJwYnh3N3VhV3Uv?=
 =?utf-8?Q?uxsxIug2PFyBJ1za1ZFCVcuy7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f5f9053-740e-49f1-0342-08daf933570b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 09:06:52.8926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8aiXNEoALEoQJJtI+NqyimaN57J8S/YluyUIpQP79I4r0DCpFIaTWRL5ofOqI/iI4XHFyxvybNfRhc3umVTMBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6308
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/18/2023 2:19 PM, Jiri Kosina wrote:
> On Sun, 18 Dec 2022, Adrian Freund wrote:
>
>> This patch adds support for the tablet mode switch sensors on
>> convertible devices where that sensor is managed by AMD SFH, like the
>> Asus Flow X13 and the Lenovo ThinkPad L13 Yoga Gen2 (AMD).
>>
>> Co-developed-by: Ivan Dovgal <iv.dovg@gmail.com>
>> Signed-off-by: Ivan Dovgal <iv.dovg@gmail.com>
>> Co-developed-by: Luke D. Jones <luke@ljones.dev>
>> Signed-off-by: Luke D. Jones <luke@ljones.dev>
>> Signed-off-by: Adrian Freund <adrian@freund.io>

Whole patch does not take any input data validation from any sensors

Please specify what are valid values?

Thanks,
--
Basavaraj